[~supittma] So what is the best effort result here?
Did you found any unusable elements? Something that will not work or look ugly?
If not let's move with that .
By themes I meant colors only so once we are aligned with colors - and by default I think we are it is ok.
I think the best outcome from this is to do the best efforts of:
- checking if everything work
- fixing some obvious style problems
We should avoid using css to style that and provide themes but this could render a lots of troubles.
Basing on all of this I think that:
- " Let the light theme be enough (my suggestion), " but I would like to see more UI people's opinions on this.
From what I see them implementation is quite easy it'self, but building build your own theme provider,
https://github.com/prisma/graphql-playground/blob/5b019b862f2a82396b0cccb2020e17dcb6215e7a/packages/graphql-playground-react/src/components/Theme/ThemeProvider.tsx
However this can be done only inside playground code which is not something we can do.
https://github.com/prisma/graphql-playground/blob/5b019b862f2a82396b0cccb2020e17dcb6215e7a/packages/graphql-playground-react/src/components/Theme/index.ts#L4 |
|
