Hi [~austincunningham],
Following a few comments.
1. When the app is unbinding we add just add the delete_at on it, then to binding the same app again, we need check if has some the app in order to just make the code deleted_at == NULL . However, in the example, above is not this method that one which is used then I think that I am no longer afraid that this change broke the current implementation.
2. However, the nomenclature is important and any dev when seeing a method with the name GetAppByID will not be expected that it will NOT return the soft-deleted ones. The best way, IMHO, is you rename the method since I believe that it is no longer used in other places to make clear as "GetActiveAppByID".
|
|
