[~weil] [~chrisfoley] I think adding support for this is overkill.
The entire audit logging to the stdout is happening here: https://github.com/aliok/apollo-voyager-server/blob/cabf7c573da12da4b377048e748bb954642611ce/packages/voyager-audit/src/auditLog.ts#L37
And this is actually an interface: https://github.com/aliok/apollo-voyager-server/blob/cabf7c573da12da4b377048e748bb954642611ce/packages/voyager-audit/src/api/AuditLogger.ts#L6
It is only 3 methods.
So, users simply need to implement their own methods and then pass that audit logger to Voyager config. Like here: https://github.com/aliok/apollo-voyager-server/blob/cabf7c573da12da4b377048e748bb954642611ce/examples/auditLogging/server.js#L38
We can definitely add support for "blocked fields" or something similar in the default implementation, but I think implementing the audit logging interface and logging what you like and blocking what you not like is much easier. Remember, this is a framework we're providing. That means, user has to do some coding to use it the way they like.
What do you think?
{quote}
allow users to provide their own abstraction
{quote}
We already support this IMO.
cc [~darahayes] [~wtrocki] |
|
