HI [~grdryn] ,
The changes performed in this PR make some the Prometheus Alerts stop to work. Note the changes performed here affect all project and it was not properly tested and indeed it can have more consequences since the permissions regard the finaliser and used by the backup feature, for example, was removed.
So, IMHO the best approach is reverted the changes performed and @grdryn please feel free to open tasks for we track all needs for all changes that you performed here. Note that if you change the rules and the API for all CR/CRDS as was done here we need to do a full regression test in the project and we need to cover:
- The monitoring and backup features
- Check if the APP will still be creating and deleting from the service with success which is using the finaliser
- Check if as the `make uninstall` will still working well when has or not apps since it will use the finaliser as well.
Note that the same is valid for UPS and probably for MDC as well.
The images of the error which was found already with the changes performed here are attached in the JIRA: AEROGEAR-9703
c/c [~weil] [~aliok2] |
|
