| Hi Enda Phelan Regards the following points added by you in the description:
It should also not return an empty string as default. There should be no content
Please check the PR where it was implemented and see that it is working according to David Ffrench definitions. Also, it goes according to what is defined in the swagger doc. If it finishes with success it will return the HTTP Code 200 since it is a PUT and an empty body {}. I cannot see any requirement/need that justify a change on it. Enda Phelan could you add here any reason/need to justify a change on that? David Ffrench do you see any need to change its response in the case of success?
It should also be checking if the version exists before trying to update it, because currently, it will try to update a version even it does not exist and return a 500.
- I understand that you are asking in this JIRA that we implement 2 validations one to check if the app is related to/associated to the versions and a second one to check if all versions exist before trying to do the update and return bad request in this situation.
- So, we can split it to make easier the implementation and validations
|