Matthias Wessendorf
created
an issue
AeroGear Push
/
AGPUSH-1250
Java client lib improvements
Issue Type:
Task
Assignee:
Sebastien Blanc
Created:
27/Jan/15 1:53 PM
Priority:
Minor
Reporter:
Matthias Wessendorf
Inconsistent UTF_8 usage:
https://github.com/aerogear/java-adm/blob/master/src/main/java/org/jboss/aerogear/adm/AdmService.java#L152
and
https://github.com/aerogear/java-adm/blob/master/src/main/java/org/jboss/aerogear/adm/TokenService.java#L115
original AdmService did not use
https://github.com/aerogear/java-adm/blob/master/src/main/java/org/jboss/aerogear/adm/AdmService.java#L121
- why?
Should the following moved to an Constants interface:
https://github.com/aerogear/java-adm/blob/master/src/main/java/org/jboss/aerogear/adm/AdmService.java#L110-L113
and
https://github.com/aerogear/java-adm/blob/master/src/main/java/org/jboss/aerogear/adm/TokenService.java#L81-L82
handling of HttpsURLConnection is similar in two classes. Perhaps parts of that could be moved to a common (util) class (that includes the two parseResponse() as well)?
should the following be moved into a precalculated StringBuilder?
https://github.com/aerogear/java-adm/blob/master/src/main/java/org/jboss/aerogear/adm/TokenService.java#L53-L56
do we really need this lib:
https://github.com/aerogear/java-adm/blob/master/pom.xml#L39-L42
Add Comment
This message was sent by Atlassian JIRA
(v6.3.11#6341-
sha1:83c4d29
)