Message Title

This error was found in a log of the ups-sync-service (during provision) which was causing ups pod to crash.

2019/03/04 16:38:01 Entering watch loop

2019/03/04 16:38:11 Error creating push client: secrets "unified-push-server" not found

panic: runtime error: invalid memory address or nil pointer dereference

[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xe2d5b8]

goroutine 6 [running]:

github.com/aerogear/ups-config-operator/pkg/configOperator.(*UpsClientImpl).getApplicationId(0xc42034a870, 0x114eb80, 0xc42034a870)

	/go/src/github.com/aerogear/ups-config-operator/pkg/configOperator/upsClient.go:232 +0x8

github.com/aerogear/ups-config-operator/pkg/configOperator.ConfigOperator.compareUPSVariantsWithClientConfigs(0x112cfc0, 0xc42036a2b0, 0x112ffe0, 0xc42000e6e0, 0x114c120, 0xc42036a2c0)

	/go/src/github.com/aerogear/ups-config-operator/pkg/configOperator/configOperator.go:123 +0x79

github.com/aerogear/ups-config-operator/pkg/configOperator.ConfigOperator.startPollingUPS(0x112cfc0, 0xc42036a2b0, 0x112ffe0, 0xc42000e6e0, 0x114c120, 0xc42036a2c0)

	/go/src/github.com/aerogear/ups-config-operator/pkg/configOperator/configOperator.go:58 +0x67

created by github.com/aerogear/ups-config-operator/pkg/configOperator.ConfigOperator.StartService

	/go/src/github.com/aerogear/ups-config-operator/pkg/configOperator/configOperator.go:43 +0x96

I found out that the task for creating ups app is run during provision even if the ups/ups-sync-service is not running properly yet (it's crashing because of the error above).

After a while, ups and ups-sync-service starts working properly, but in a meanwhile, this task is triggered twice, so it may cause to create two identical applications.

Wei Li wdyt about adding an additional health check, that would be run before the task that creates the ups app, so it ensures that the task for creating the app is run once and successfully? E.g. to check /rest/applications endpoint, which returns 200 only when all ups containers are ready?