| while(true) and break ahouls be avoided. The current logic can be refactored into something like:
ObjectMessage message = receiveVariantMetricInformation(pushMessageInformation.getId()); |
while (message != null) { |
updateVariantMetrics(pushMessageInformation, (VariantMetricInformation) message.getObject()); |
message = receiveVariantMetricInformation(pushMessageInformation.getId()); |
}
|
https://github.com/matzew/aerogear-unifiedpush-server/blob/0e75417f6d7acad93b413803bf84bf4bd285c1d4/push/sender/src/main/java/org/jboss/aerogear/unifiedpush/message/MetricsCollector.java#L104-L113 |