Hi,

Am 27.08.2012 15:37 schrieb "Emmanuel Bernard" <emmanuel@hibernate.org>:
>
>
> On 27 août 2012, at 10:51, Gunnar Morling wrote:
>>
>> For the “getter“ approach, getMethodValidator() would be defined on ValidatorFactory, right? At least that was the original idea.
>
>
> Ah. I was thinking `getMethodValidator()` was hosted to `Validator`. The negative I could see are:
>
> 1. `ValidatorContext` needs to be updated too

> 2. we would require to allow injection of `MethodValidator` in injectable environments

> 3. we will need to duplicate `getConstraintsForClass` and `unwrap` in `MethodValidator`

Hmmm, you're right about 1. and 2. No biggie though IMO.

I'm not sure about getConstraintsForClass(). Would it really be duplicated? I think the following options would be possible:

* Validator#getConstraintsForClass() could return a descriptor describing all (bean and method) constraints. No getConstraintsForClass() on MethodValidator.

* Validator#getConstraintsForClass() returns a descriptor of the bean constraints, MethodValidator#getConstraintsForClass() returns a descriptor representing the method level constraints.

Which one did you have in mind?

Regarding unwrap(), I'm tempted to say we should have it anyways on MethodValidator, or did you mean to unwrap via an implementation-specific Validator interface? Also in the fluent approach, I think I'd slightly prefer

MyMethodValidator mv = myValidator.getMethodValidator().unwrap(MyMethodValidator.class);

MyMethodValidator mv = myValidator.unwrap(MyValidator.class).getMethodValidator();

The main reason being, that it is more obvious and one doesn't need a specific Validator interface if one only wants to expose a specific MethodValidator interface. It doesn't make a huge difference, though.

> Independently, they don't weight much (except point 3) but as a whole I wonder if that's the right approach.
> What would be the negative points of putting it on `Validator`? It requires one extra method call. Any other?

I'd just find it more natural to retrieve a (method) validator from a validator factory instead from another validator. That way it's more regular IMO.

>
> Emmanuel
>

--Gunnar

>
> _______________________________________________
> beanvalidation-dev mailing list
> beanvalidation-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
>