Hi Gunnar,

1. Constraint composition: I agree with Guillaume, I thinks is better let the providers do their own implementation.
2. Email regex: Good for me.
3. @Positive/@Negative: Ok.

Thanks!

Marco



On Fri, Mar 24, 2017 at 3:54 PM, Guillaume Smet <guillaume.smet@gmail.com> wrote:
Hi Gunnar,

On Fri, Mar 24, 2017 at 2:43 PM, Gunnar Morling <gunnar@hibernate.org> wrote:
* Should @NotEmpty mandate the usage of constraint composition (as
it's done in the PRs)? It essentially prescribes an "implementation",
i.e. providers wouldn't even need a constraint validator for it. But
then this excludes any more efficient implementation a provider may
have (well, they could by special-handling this constraint).

I'm not convinced it's such a good idea to use constraint composition for @NotBlank and @NotEmpty. I would let the implementation to the providers, especially since using constraint composition does not really buy us anything in this case.

--
Guillaume

_______________________________________________
beanvalidation-dev mailing list
beanvalidation-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/beanvalidation-dev