I disagree to merge the current version of cdi/pull/272.

1. The current wording is not clear.

Esp. the part: "the transaction is in an illegal state".

I understand that it should mean an IllegalStateException is thrown
during Transaction.registerSynchronization() but I think we should
rather follow the javadoc of this method.

See also https://github.com/cdi-spec/cdi/pull/272#discussion_r58493520

2. Observer ordering

It might be useful to simulate the observer ordering as if the callback
was sucessfully registered, e.g. BEFORE_COMPLETION notified before
AFTER_COMPLETION and AFTER_FAILURE.

See also https://github.com/cdi-spec/cdi/pull/272#issuecomment-206161278
and ongoing discussion.

Martin

Dne 6.4.2016 v 09:32 Antoine Sabot-Durand napsal(a):
> You'll find the minutes here:
>
> https://docs.google.com/document/d/1yxhW--C2b-SKs6nVw8m3nkwfgBBL5aoOz3Hoyg5TWRA/edit?usp=sharing
>
>
> _______________________________________________
> cdi-dev mailing list
> cdi-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/cdi-dev
>
> Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.
>

--
Martin Kouba
Software Engineer
Red Hat, Czech Republic