[dna-commits] DNA SVN: r1537 - in trunk: dna-graph/src/test/java/org/jboss/dna/graph/connector/path and 3 other directories.

Author: rhauch Date: 2010-01-06 18:49:23 -0500 (Wed, 06 Jan 2010) New Revision: 1537 Modified: trunk/.gitignore trunk/dna-graph/src/test/java/org/jboss/dna/graph/connector/path/AbstractPathRepositorySourceTest.java trunk/extensions/dna-connector-svn/src/main/java/org/jboss/dna/connector/svn/SvnRepository.java trunk/extensions/dna-connector-svn/src/test/java/org/jboss/dna/connector/svn/SvnRepositorySourceTest.java trunk/extensions/dna-sequencer-classfile/src/test/java/org/jboss/dna/sequencer/classfile/metadata/ClassFileMetadataReaderTest.java Log: Minor modifications to correct or suppress 'unchecked' warnings. Also updated .gitignore file with new 'dna-sequencer-classfile' project. Modified: trunk/.gitignore =================================================================== --- trunk/.gitignore 2010-01-06 23:48:32 UTC (rev 1536) +++ trunk/.gitignore 2010-01-06 23:49:23 UTC (rev 1537) @@ -56,6 +56,7 @@ /extensions/dna-connector-svn/target /extensions/dna-mimetype-detector-aperture/.settings /extensions/dna-mimetype-detector-aperture/target +/extensions/dna-sequencer-classfile/target /extensions/dna-sequencer-cnd/target /extensions/dna-sequencer-ddl/target /extensions/dna-sequencer-esbMessage/target Modified: trunk/dna-graph/src/test/java/org/jboss/dna/graph/connector/path/AbstractPathRepositorySourceTest.java =================================================================== --- trunk/dna-graph/src/test/java/org/jboss/dna/graph/connector/path/AbstractPathRepositorySourceTest.java 2010-01-06 23:48:32 UTC (rev 1536) +++ trunk/dna-graph/src/test/java/org/jboss/dna/graph/connector/path/AbstractPathRepositorySourceTest.java 2010-01-06 23:49:23 UTC (rev 1537) @@ -23,12 +23,10 @@ */ package org.jboss.dna.graph.connector.path; - import static org.hamcrest.core.Is.is; import static org.hamcrest.core.IsNot.not; import static org.hamcrest.core.IsNull.notNullValue; import static org.junit.Assert.assertThat; -import javax.naming.NamingException; import javax.naming.Reference; import org.jboss.dna.graph.connector.RepositoryConnection; import org.jboss.dna.graph.connector.RepositorySourceCapabilities; @@ -65,7 +63,7 @@ return null; } - public Reference getReference() throws NamingException { + public Reference getReference() { return null; } }; Modified: trunk/extensions/dna-connector-svn/src/main/java/org/jboss/dna/connector/svn/SvnRepository.java =================================================================== --- trunk/extensions/dna-connector-svn/src/main/java/org/jboss/dna/connector/svn/SvnRepository.java 2010-01-06 23:48:32 UTC (rev 1536) +++ trunk/extensions/dna-connector-svn/src/main/java/org/jboss/dna/connector/svn/SvnRepository.java 2010-01-06 23:49:23 UTC (rev 1537) @@ -59,7 +59,7 @@ public class SvnRepository extends WritablePathRepository { - protected static final String DEFAULT_MIME_TYPE = "application/octet-stream"; + private static final String DEFAULT_MIME_TYPE = "application/octet-stream"; protected static final byte[] EMPTY_BYTE_ARRAY = new byte[0]; protected final SvnRepositorySource source; Modified: trunk/extensions/dna-connector-svn/src/test/java/org/jboss/dna/connector/svn/SvnRepositorySourceTest.java =================================================================== --- trunk/extensions/dna-connector-svn/src/test/java/org/jboss/dna/connector/svn/SvnRepositorySourceTest.java 2010-01-06 23:48:32 UTC (rev 1536) +++ trunk/extensions/dna-connector-svn/src/test/java/org/jboss/dna/connector/svn/SvnRepositorySourceTest.java 2010-01-06 23:49:23 UTC (rev 1537) @@ -154,12 +154,11 @@ assertThat(source.getName(), is(isNull())); } - @Test public void shouldHaveDefaultRetryLimit() { assertThat(source.getRetryLimit(), is(SvnRepositorySource.DEFAULT_RETRY_LIMIT)); } - + @Test( expected = IllegalArgumentException.class ) public void shouldNotAllowNullSVNUrl() { source.setRepositoryRootUrl(null); @@ -187,31 +186,30 @@ assertThat(source.getRetryLimit(), is(i)); } } - + @Test( expected = RepositorySourceException.class ) public void shouldFailToCreateConnectionIfSourceHasNoName() { source.setName(null); source.getConnection(); } - + @Test( expected = RepositorySourceException.class ) public void shouldFailToCreateConnectionIfSourceHasNoUsername() { source.setUsername(null); source.getConnection(); } - + @Test( expected = RepositorySourceException.class ) public void shouldFailToCreateConnectionIfSourceHasNoPassword() { source.setPassword(null); source.getConnection(); } - + @Test public void shouldCreateConnection() throws Exception { connection = source.getConnection(); assertThat(connection, is(notNullValue())); } - @Test public void shouldCreateJndiReferenceAndRecreatedObjectFromReference() throws Exception { Modified: trunk/extensions/dna-sequencer-classfile/src/test/java/org/jboss/dna/sequencer/classfile/metadata/ClassFileMetadataReaderTest.java =================================================================== --- trunk/extensions/dna-sequencer-classfile/src/test/java/org/jboss/dna/sequencer/classfile/metadata/ClassFileMetadataReaderTest.java 2010-01-06 23:48:32 UTC (rev 1536) +++ trunk/extensions/dna-sequencer-classfile/src/test/java/org/jboss/dna/sequencer/classfile/metadata/ClassFileMetadataReaderTest.java 2010-01-06 23:49:23 UTC (rev 1537) @@ -92,11 +92,11 @@ ClassMetadata cmd = ClassFileMetadataReader.instance(input); assertThat(cmd, instanceOf(EnumMetadata.class)); - EnumMetadata emd = (EnumMetadata) cmd; - + EnumMetadata emd = (EnumMetadata)cmd; + List<String> enumValues = Arrays.asList(new String[] {"VALUE_A", "VALUE_B", "VALUE_C"}); assertThat(emd.getValues(), is(enumValues)); - + for (FieldMetadata fmd : emd.getFields()) { assertThat(fmd.getName(), not(anyOf(is("VALUE_A"), is("VALUE_B"), is("VALUE_C")))); } @@ -141,7 +141,7 @@ checkConstructors(cmd, clazz); } - @SuppressWarnings( "unchecked" ) + @SuppressWarnings( {"unchecked", "synthetic-access"} ) private void checkFields( ClassMetadata cmd, Class<?> clazz ) throws Exception { Map<FieldKey, Field> clazzFields = new HashMap<FieldKey, Field>(); @@ -181,6 +181,7 @@ } } + @SuppressWarnings( "synthetic-access" ) private void checkMethods( ClassMetadata cmd, Class<?> clazz ) throws Exception { Map<MethodKey, Method> clazzMethods = new HashMap<MethodKey, Method>(); @@ -218,7 +219,6 @@ assertThat(metaMethod.getAnnotations().size(), is(clazzMethod.getDeclaredAnnotations().length)); - // Can't really check this since some annotations are not runtime annotations // for (AnnotationMetadata amd : metaMethod.getAnnotations()) { // Class<Annotation> annotationClass = (Class<Annotation>)Class.forName(amd.getAnnotationClassName()); @@ -229,7 +229,7 @@ } } - @SuppressWarnings( "unchecked" ) + @SuppressWarnings( {"unchecked", "synthetic-access"} ) private void checkConstructors( ClassMetadata cmd, Class<?> clazz ) throws Exception { Map<MethodKey, Constructor> clazzCtors = new HashMap<MethodKey, Constructor>();