Author: jverhaeg(a)redhat.com Date: 2008-06-18 15:01:04 -0400 (Wed, 18 Jun 2008) New Revision: 301 Modified: trunk/dna-common/src/main/java/org/jboss/dna/common/collection/SimpleProblems.java Log: DNA-164: Changed iterator method to return iterator for Collections.emptyList if no problems exist. Modified: trunk/dna-common/src/main/java/org/jboss/dna/common/collection/SimpleProblems.java =================================================================== --- trunk/dna-common/src/main/java/org/jboss/dna/common/collection/SimpleProblems.java 2008-06-18 18:53:54 UTC (rev 300) +++ trunk/dna-common/src/main/java/org/jboss/dna/common/collection/SimpleProblems.java 2008-06-18 19:01:04 UTC (rev 301) @@ -21,6 +21,7 @@ */ package org.jboss.dna.common.collection; +import java.util.Collections; import java.util.Iterator; import java.util.LinkedList; import java.util.List; @@ -37,6 +38,8 @@ @NotThreadSafe public class SimpleProblems implements Problems { + private static final List<Problem> EMPTY_PROBLEMS = Collections.emptyList(); + private List<Problem> problems; public void addError( I18n message, @@ -245,14 +248,12 @@ } /** - * <p> * {@inheritDoc} - * </p> * * @see org.jboss.dna.common.collection.Problems#iterator() */ public Iterator<Problem> iterator() { - return problems.iterator(); + return (problems == null ? EMPTY_PROBLEMS.iterator() : problems.iterator()); } protected void addProblem( Problem problem ) {