[JBoss JIRA] Created: (DNA-180) Change exceptions to use I18n
by Randall Hauch (JIRA)
Change exceptions to use I18n
-----------------------------
Key: DNA-180
URL: https://jira.jboss.org/jira/browse/DNA-180
Project: DNA
Issue Type: Task
Components: Common, Connectors, Federation, Maven Classloader, Sequencers, SPI
Affects Versions: 0.1
Reporter: Randall Hauch
Assignee: Randall Hauch
Fix For: 0.2
The runtime exceptions used in DNA take String messages, but everywhere they're used we pass an I18n.text() result into the constructor. These exceptions should be changed to take an I18n and parameters, and to delay the actual processing of the localization. This would make it possible to allow people in different locales to view the exceptions correctly (i.e., a web application where administrators can view the problems/errors). We probably should have a base class that represents a DNA exception that does most (if not all) of this work.
This should be an easy change, although it will likely have a large (but straighforward) impact on the code base.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 9 months
[JBoss JIRA] Created: (DNA-189) Change RepositorySource to extend the ManagedRepositoryConnectionFactory interface, so it has management methods
by Randall Hauch (JIRA)
Change RepositorySource to extend the ManagedRepositoryConnectionFactory interface, so it has management methods
----------------------------------------------------------------------------------------------------------------
Key: DNA-189
URL: https://jira.jboss.org/jira/browse/DNA-189
Project: DNA
Issue Type: Task
Components: SPI
Reporter: Randall Hauch
Assignee: Randall Hauch
Fix For: 0.2
The RepositorySource only has methods for getting/setting properties and creating connections. This means that managing the set of connections is not part of the interface, and this results in the RepositorySource instances needing to be wrapped by RepositoryConnectionPools. This makes it more difficult (and less consistent) to manage the instances.
Change name of RepositoryConnectionPool interface to ManagedRepositoryConnectionFactory
Change RepositorySource to extend the ManagedRepositoryConnectionFactory interface (rather than RepositoryConnectionFactory)
Change name of BasicRepositoryConnectionPool to RepositoryConnectionPool (since there is no "pool" interface anymore)
Create an AbstractRepositorySource implementation that uses a pool to manage the instances
Change the existing RepositorySource implementations to extend AbstractRepositorySource (this is not required, but it does encapsulate the management of the connections)
Clean up RepositorySourceManager, since it no longer needs to distinguish between RepositorySource and pools (since all RepositorySource are now manageable)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 9 months