[dna-issues] [JBoss JIRA] Commented: (DNA-58) Create repository configuration and component

[ https://jira.jboss.org/jira/browse/DNA-58?page=com.atlassian.jira.plugin.... ] Randall Hauch commented on DNA-58: ---------------------------------- Refactored the DnaConfiguration class to use more interfaces and to move those interfaces (and reusable implementations) into a Configurator class that uses generics. DnaConfiguration instantiates a configurator, but also implements some of the high-level interfaces by delegating them to the wrapped configurator instance. This allows DnaConfiguration to appear to be doing the configurating, but in reality it is the wrapped builder that is doing it. Also, DnaConfiguration (or other components) can choose which "aspects" of configuration it is to expose by inheriting controlling which higher-level interfaces are implemented. Since delegation is used, this works very well. This is a more complicated design, but it is far more extensible and reusable. A JcrConfiguration class was also created that works in the same way as DnaConfiguration, except that it uses a different type parameter (so all the interfaces return JcrConfiguration). It thus gets to reuse all of the Configurator logic. However, JcrConfiguration doesn't implement all of the "aspects", essentially hiding certain services (e.g., sequencers, since they don't yet work with our implementation). This change also made a few minor corrections to the JavaDoc and visibility modifiers on the classes in the 'org.jboss.dna.jcr' package. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira