[ https://jira.jboss.org/jira/browse/DNA-369?page=com.atlassian.jira.plugin... ] Brian Carothers updated DNA-369: -------------------------------- Attachment: DNA-369.patch Attached a patch that conservatively checks all child nodes and properties of changed nodes before they are saved. The approach is conservative in that is does not consider the dna:nodeDefinition property on the node in case the definition for the node has been modified. Although the API does not currently allow modification of existing node types, this is a planned feature and a requirement for JCR 2.0 implementation. This patch does not eliminate the race condition between adding a child item based on a definition that is being modified, but it does reduce the window of time in which that error can occur. The patch also adds a save-time check that all mandatory properties and nodes are populated. This is a requirement of the specification. Finally, the patch adds some node types and configuration properties to the JR TCK to enable a few of the tests that depend on very specific properties to pass. Apologies for the patch including a few gibberish lines of the Session.move patch in SessionCache.save. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/DNA-369?page=com.atlassian.jira.plugin... ] Randall Hauch updated DNA-369: ------------------------------ Fix Version/s: 0.4 Targeted to 0.4. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/DNA-369?page=com.atlassian.jira.plugin... ] Randall Hauch commented on DNA-369: ----------------------------------- Applied the patches from this issue and DNA-365. Unfortunately, they couldn't easily be applied separately. Note that several TCK unit tests had to be commented out (relative to the patch), since they must be testing behavior that is not yet committed to trunk. (There were a few regressions, but it looks like they're actually related to DNA-374.) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira