[ https://jira.jboss.org/jira/browse/DNA-370?page=com.atlassian.jira.plugin... ] Randall Hauch updated DNA-370: ------------------------------ Fix Version/s: 0.6 (was: 0.5) Pushing all non-essential issues from 0.5 to 0.6. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/DNA-370?page=com.atlassian.jira.plugin... ] Brian Carothers updated DNA-370: -------------------------------- Attachment: JpaConnector_with_clone_support.patch I have modified the CopyBranchRequest to support the concept of UUID conflict behavior in an earlier patch. This indicates whether UUID collisions should be handled by throwing an exception, removing the existing node and replacing it with the node from the copy, or always using new UUIDs to avoid collisions entirely. This was pretty simple to support in the InMemoryRepository, but required some pretty major work in JpaConnector, including modification of the primary key of ChildEntity. I'm attaching the JpaConnector portion of the overall work for a review and/or sanity check. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/DNA-370?page=com.atlassian.jira.plugin... ] Brian Carothers updated DNA-370: -------------------------------- Attachment: DNA-370_copy_behavior.patch Applied the attached patch (DNA-370_copy_behavior) to add support for UuidConflictBehavior in the graph layer and each of the three connectors that currently support writes. This includes the previous patch to modify the JPA connector and required some fairly heavy modifications of the JBoss Cache connector to support efficient look-ups by UUID. The patch also corrects some configuration to allow the JR TCK clone tests to start working. This will result in one false negative in the nightly TCK compatibility build, as there is a clone test that assumes the repository supports locking. There is still some work left to be done to fully support clone. If removeExisting is true, the JCR layer must first identify any conflicts and speculatively remove them to make sure that removing the existing nodes won't violate type constraints. This check cannot be done at the graph or connector layer, as those layers are unaware of the JCR typing semantics. Additionally, the update method must still be implemented. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/DNA-370?page=com.atlassian.jira.plugin... ] Brian Carothers updated DNA-370: -------------------------------- Attachment: DNA-370_clone_request.patch I tried to make workspace.update work with the existing CopyBranchRequest, but it required some changes that would have made the semantics of to(...) and into(...) ambiguous and dependent on whether the UUID conflict behavior was ALWAYS_CREATE_NEW or not. Instead, I pulled the UUID behavior out of the CopyBranchRequest and added it into a new request - CloneBranchRequest. This provides clear semantics for copy (always creates new UUIDs, may be between workspaces or within a single workspace, may function at the property or node level) and clone (always preserves UUIDs, only works between workspaces, may remove nodes from target workspace, only works at the node level). The attached patch adds the new request and all of the associated changes on the graph side (adding clone operation) and the connector (implementing clone behavior for writable connectors) and modifies the workspace.clone and node.update operations accordingly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/DNA-370?page=com.atlassian.jira.plugin... ] Randall Hauch resolved DNA-370. ------------------------------- Resolution: Done Assignee: Brian Carothers Marking as resolved, since it was committed to SVN a few weeks back, and updated during the SessionCache redesign (DNA-466). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira