[ https://jira.jboss.org/jira/browse/DNA-341?page=com.atlassian.jira.plugin... ] Randall Hauch commented on DNA-341: ----------------------------------- The Graph API currently has a RemovePropertiesRequest that takes a set of property names to be removed. (This could be optimized to have another RemovePropertyRequest that would be optionally supported, with a default implementation in the RequestProcessor that would use RemovePropertiesRequest.) However, it is also possible to use UpdatePropertiesRequest, and the expected behavior is currently to remove any property with no values. This latter behavior could be changed to make UpdatePropertiesRequest purely update (no remove), and require the use of RemovePropertiesRequest for any remove operations. I'm not sure what the impact of this would be in terms of existing connectors or components that use the Graph interface. Another option would be to continue to allow UpdatePropertiesRequest to define removal operations, but to distinguish between setting a property to have no values versus removing the property. The former could be accomplished by using an empty array, while the latter could be defined by a null array reference. Either way, there is likely to be an impact on existing connectors, components that directly use the requests (e.g., the Graph API implementation), and maybe even higher-level components. Fortunately, there have already been significant changes to the request and connector framework within this release, so the impact to JBoss DNA users is not much different than is current for 0.4. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/DNA-341?page=com.atlassian.jira.plugin... ] Randall Hauch updated DNA-341: ------------------------------ Attachment: DNA-341.patch Attached a patch that changes the connector API. Specifically the semantics and a few method signatures of UpdatePropertiesRequest class were changed to no longer assume that an empty property should be removed; rather, the names of properties that are to be removed are tracked explicitly, and the number of values in a property no longer has any relationship to whether the property is to be removed. All connectors were changed to apply these new semantics. A number of other changes to the connector API were made. New SetPropertyRequest and RemovePropertyRequest requests types were added as being more efficient when a single property is being set or removed. These are optional requests, meaning that the RequestProcessor has default implementations for the corresponding "process" methods that convert the reqeusts to UpdatedPropertiesRequest. Thus, a connector doesn't have to implement these, but it may be more efficient for it to do so. Also, the Graph batch implementation was improved to optimize adjacent calls to set/remove properties on the same node. In other words, if a batch is used to set a property on node A and then is immediately used to set another property on the same node, the batch will combine the two requests. However, this optimization does not apply if any other operations are performed between the set/remove property operations. Finally, a minor error was found and corrected in how the connector unit tests reported the (trivial) metrics for creating nodes. The total times (line 2) were correct, but the average and the times for additional nodes (line 3) were all incorrect. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/DNA-341?page=com.atlassian.jira.plugin... ] Randall Hauch resolved DNA-341. ------------------------------- Resolution: Done Marking as resolved. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira