[JBoss JIRA] Created: (DNA-399) Need to Add Session.checkPermission Calls to Guard Read, Add Node, Set Property, and Remove Item Access
6:54 p.m.
Need to Add Session.checkPermission Calls to Guard Read, Add Node, Set Property, and
Remove Item Access
-------------------------------------------------------------------------------------------------------
Key: DNA-399
URL: https://jira.jboss.org/jira/browse/DNA-399
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.4
Reporter: Brian Carothers
Fix For: 0.5
Now that JcrSession.checkPermission works (assuming patch takes), we need to add
checkPermission calls to guard "read", "add_node", "remove",
and "set_property" access, as per spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:51 p.m.
New subject: [JBoss JIRA] Updated: (DNA-399) Need to Add Session.checkPermission Calls to Guard Read, Add Node, Set Property, and Remove Item Access
[
https://jira.jboss.org/jira/browse/DNA-399?page=com.atlassian.jira.plugin...
]
Randall Hauch updated DNA-399:
------------------------------
Fix Version/s: 0.6
(was: 0.5)
Retargeting to fix in 0.6, since 0.5 has been shortened and made more focused.
Need to Add Session.checkPermission Calls to Guard Read, Add Node,
Set Property, and Remove Item Access
-------------------------------------------------------------------------------------------------------
Key: DNA-399
URL: https://jira.jboss.org/jira/browse/DNA-399
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.4
Reporter: Brian Carothers
Fix For: 0.6
Now that JcrSession.checkPermission works (assuming patch takes), we need to add
checkPermission calls to guard "read", "add_node", "remove",
and "set_property" access, as per spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 a.m.
New subject: [JBoss JIRA] Updated: (DNA-399) Need to Add Session.checkPermission Calls to Guard Read, Add Node, Set Property, and Remove Item Access
[
https://jira.jboss.org/jira/browse/DNA-399?page=com.atlassian.jira.plugin...
]
Brian Carothers updated DNA-399:
--------------------------------
Attachment: DNA-399.patch
Applied attached patch that adds permission checks to item reads, item removes, property
modification and node addition calls and adds a new test case that extends the JR TCK
framework, and adds a new workspace in RepositoryStubImpl creatively named
'otherWorkspace';
Adding the extra workspace will cause some false regressions in the nightly TCK run as it
enables 3 cloning tests that silently passed when there was only one workspace in the
repository.
I will leave this defect open for a few days (and probably post a forum topic) to try to
get some feedback on if this is sufficient security for the 1.0 release. I am curious
whether there is any interest in being able to assign roles on a per repository and
workspace basis in the case of multiple repositories feeding from a single JAAS source, if
there is interest in adding an admin role that is required for type and namespace
registration, or any other needed enhancements.
Need to Add Session.checkPermission Calls to Guard Read, Add Node,
Set Property, and Remove Item Access
-------------------------------------------------------------------------------------------------------
Key: DNA-399
URL: https://jira.jboss.org/jira/browse/DNA-399
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.4
Reporter: Brian Carothers
Fix For: 0.6
Attachments: DNA-399.patch
Now that JcrSession.checkPermission works (assuming patch takes), we need to add
checkPermission calls to guard "read", "add_node", "remove",
and "set_property" access, as per spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:08 p.m.
New subject: [JBoss JIRA] Updated: (DNA-399) Need to Add Session.checkPermission Calls to Guard Read, Add Node, Set Property, and Remove Item Access
[
https://jira.jboss.org/jira/browse/DNA-399?page=com.atlassian.jira.plugin...
]
Brian Carothers updated DNA-399:
--------------------------------
JBoss Forum Reference:
http://www.jboss.org/index.html?module=bb&op=viewtopic&t=156950
Added forum topic:
http://www.jboss.org/index.html?module=bb&op=viewtopic&t=156950
Need to Add Session.checkPermission Calls to Guard Read, Add Node,
Set Property, and Remove Item Access
-------------------------------------------------------------------------------------------------------
Key: DNA-399
URL: https://jira.jboss.org/jira/browse/DNA-399
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.4
Reporter: Brian Carothers
Fix For: 0.6
Attachments: DNA-399.patch
Now that JcrSession.checkPermission works (assuming patch takes), we need to add
checkPermission calls to guard "read", "add_node", "remove",
and "set_property" access, as per spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:14 a.m.
New subject: [JBoss JIRA] Resolved: (DNA-399) Need to Add Session.checkPermission Calls to Guard Read, Add Node, Set Property, and Remove Item Access
[
https://jira.jboss.org/jira/browse/DNA-399?page=com.atlassian.jira.plugin...
]
Brian Carothers resolved DNA-399.
---------------------------------
Resolution: Done
Assignee: Brian Carothers
Applied DNA-399_forum_feedback.patch to complete defect resolution. Any additional
feedback can be incorporated into a separate issue.
Need to Add Session.checkPermission Calls to Guard Read, Add Node,
Set Property, and Remove Item Access
-------------------------------------------------------------------------------------------------------
Key: DNA-399
URL: https://jira.jboss.org/jira/browse/DNA-399
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.4
Reporter: Brian Carothers
Assignee: Brian Carothers
Fix For: 0.6
Attachments: DNA-399.patch, DNA-399_forum_feedback.patch
Now that JcrSession.checkPermission works (assuming patch takes), we need to add
checkPermission calls to guard "read", "add_node", "remove",
and "set_property" access, as per spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:14 a.m.
New subject: [JBoss JIRA] Updated: (DNA-399) Need to Add Session.checkPermission Calls to Guard Read, Add Node, Set Property, and Remove Item Access
[
https://jira.jboss.org/jira/browse/DNA-399?page=com.atlassian.jira.plugin...
]
Brian Carothers updated DNA-399:
--------------------------------
Attachment: DNA-399_forum_feedback.patch
Attached patch that incorporates the feedback-to-date from the forum topic. An additional
"admin" role is added and security checks for permanently registering and
unregistering types and namespaces were added that check for this role. The admin role is
a superset of the readwrite role, which is itself a superset of the readonly role. The
pattern for mapping roles was changed to be <role name>[.<repository
name>[.<workspace name>]] instead of <role name>[.<workspace name>].
Finally, JcrRepository.login was modified to not allow users to log into workspaces to
which they do not have at least readonly access.
JcrWorkspace.getAccessibleWorkspaceNames() was also modified to filter out workspace names
to which the user does not have at least readonly access.
Need to Add Session.checkPermission Calls to Guard Read, Add Node,
Set Property, and Remove Item Access
-------------------------------------------------------------------------------------------------------
Key: DNA-399
URL: https://jira.jboss.org/jira/browse/DNA-399
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.4
Reporter: Brian Carothers
Fix For: 0.6
Attachments: DNA-399.patch, DNA-399_forum_feedback.patch
Now that JcrSession.checkPermission works (assuming patch takes), we need to add
checkPermission calls to guard "read", "add_node", "remove",
and "set_property" access, as per spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5475
days inactive
5525
days old
5 comments
2 participants
participants (2)
-
Brian Carothers (JIRA) -
Randall Hauch (JIRA)