[
https://jira.jboss.org/jira/browse/DNA-441?page=com.atlassian.jira.plugin...
]
Brian Carothers updated DNA-441:
--------------------------------
Attachment: DNA-441.patch
Attached patch that adds some additional tests for constraint violations and permissions.
It's pretty prosaic, except for SessionCache.compensateForWorkspaceChildChange(UUID,
UUID, UUID, Name). From the Javadoc for the method:
The JCR specification assumes that reading a node into the session does not imply reading
the relationship between the node and its children into the session. As a performance
optimization, DNA eagerly loads the list of child names and UUIDs (but not the child nodes
themselves). This creates an issue when direct writes are performed through the
workspace. The act of modifying a node is assumed to imply loading its children, but we
must load the node in order to modify it.
This method provides a way to signal that a child should be added to one parent and,
optionally, removed from another. The cache of loaded nodes and the cache of changed
nodes are modified accordingly, but no additional graph requests are batched.
This is not overly invasive, but I'll leave it our for review for a day or two because
of the SessionCache change. The patch basically completes the copy(String, String and
move(String, String) implementations, but the last workspace move and copy TCK tests
can't be uncommented because they each contain one test that assumes the repository
supports locking.
JcrWorkspace.move and .clone Don't Check Node Type Constraints or
Permissions
-----------------------------------------------------------------------------
Key: DNA-441
URL:
https://jira.jboss.org/jira/browse/DNA-441
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.4
Reporter: Brian Carothers
Fix For: 0.5
Attachments: DNA-441.patch
The workspace move and copy operations are missing some of the required checks, impacting
the JR TCK nightly tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira