[JBoss JIRA] Created: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
10:11 a.m.
Creating A New Property And Changing An Existing Property Should Have Different
ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Fix For: 0.7
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:28 a.m.
New subject: [JBoss JIRA] Updated: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
[
https://jira.jboss.org/jira/browse/DNA-549?page=com.atlassian.jira.plugin...
]
Randall Hauch updated DNA-549:
------------------------------
Priority: Blocker (was: Major)
These are blockers for the release.
Creating A New Property And Changing An Existing Property Should Have
Different ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Priority: Blocker
Fix For: 0.7
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:37 p.m.
New subject: [JBoss JIRA] Commented: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
[
https://jira.jboss.org/jira/browse/DNA-549?page=com.atlassian.jira.plugin...
]
Randall Hauch commented on DNA-549:
-----------------------------------
Added fields to the UpdatePropertiesRequest and SetPropertyRequest to record which
properties were created vs changed. Since this is a change to the request classes
involving new methods that must be called when processing these requests, all the
connectors were checked and changed if required. All tests pass.
Creating A New Property And Changing An Existing Property Should Have
Different ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Priority: Blocker
Fix For: 0.7
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:39 p.m.
New subject: [JBoss JIRA] Resolved: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
[
https://jira.jboss.org/jira/browse/DNA-549?page=com.atlassian.jira.plugin...
]
Randall Hauch resolved DNA-549.
-------------------------------
Resolution: Done
Assignee: Randall Hauch
Marking as resolved, since this appears to have solved the issue.
Creating A New Property And Changing An Existing Property Should Have
Different ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Assignee: Randall Hauch
Priority: Blocker
Fix For: 0.7
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:45 p.m.
New subject: [JBoss JIRA] Reopened: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
[
https://jira.jboss.org/jira/browse/DNA-549?page=com.atlassian.jira.plugin...
]
Dan Florian reopened DNA-549:
-----------------------------
The UpdateValuesRequest also has the same problem. According to the documentation for this
class it can be used for a new or an existing property. There is no way to tell using the
existing API. This is needed by the ObservationManager implementation.
Creating A New Property And Changing An Existing Property Should Have
Different ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Assignee: Randall Hauch
Priority: Blocker
Fix For: 0.7
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:57 p.m.
New subject: [JBoss JIRA] Updated: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
[
https://jira.jboss.org/jira/browse/DNA-549?page=com.atlassian.jira.plugin...
]
Brian Carothers updated DNA-549:
--------------------------------
Attachment: DNA-549.patch
Attached patch that adds a boolean method (isNewProperty()) that indicates whether a
property was created as a result of processing this request. It's a parallel to the
same method in SetPropertyRequest.
Creating A New Property And Changing An Existing Property Should Have
Different ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Assignee: Randall Hauch
Priority: Blocker
Fix For: 0.7
Attachments: DNA-549.patch
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:04 a.m.
New subject: [JBoss JIRA] Commented: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
[
https://jira.jboss.org/jira/browse/DNA-549?page=com.atlassian.jira.plugin...
]
Randall Hauch commented on DNA-549:
-----------------------------------
Looks good. Exactly what I was thinking of. I vote to commit.
Creating A New Property And Changing An Existing Property Should Have
Different ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Assignee: Randall Hauch
Priority: Blocker
Fix For: 0.7
Attachments: DNA-549.patch
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:27 a.m.
New subject: [JBoss JIRA] Resolved: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
[
https://jira.jboss.org/jira/browse/DNA-549?page=com.atlassian.jira.plugin...
]
Brian Carothers resolved DNA-549.
---------------------------------
Resolution: Done
Committed patch to resolve defect
Creating A New Property And Changing An Existing Property Should Have
Different ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Assignee: Randall Hauch
Priority: Blocker
Fix For: 0.7
Attachments: DNA-549.patch
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:52 p.m.
New subject: [JBoss JIRA] Reopened: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
[
https://jira.jboss.org/jira/browse/DNA-549?page=com.atlassian.jira.plugin...
]
Dan Florian reopened DNA-549:
-----------------------------
Assignee: Dan Florian (was: Randall Hauch)
The RequestProcessor needs to set the actual Property on the UpdatePropertiesRequest as
the property is needed during observation event handling. Currently the request only
contains the property name.
Creating A New Property And Changing An Existing Property Should Have
Different ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Assignee: Dan Florian
Priority: Blocker
Fix For: 0.7
Attachments: DNA-549.patch
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:15 p.m.
New subject: [JBoss JIRA] Resolved: (DNA-549) Creating A New Property And Changing An Existing Property Should Have Different ChangeRequest Types
[
https://jira.jboss.org/jira/browse/DNA-549?page=com.atlassian.jira.plugin...
]
Dan Florian resolved DNA-549.
-----------------------------
Resolution: Done
The RequestProcessor now sets the actual Property on the UpdatePropertiesRequest. This
property is used by the NetChangeObserver during observation event handling.
Creating A New Property And Changing An Existing Property Should Have
Different ChangeRequest Types
---------------------------------------------------------------------------------------------------
Key: DNA-549
URL: https://jira.jboss.org/jira/browse/DNA-549
Project: DNA
Issue Type: Bug
Components: JCR
Affects Versions: 0.6
Reporter: Dan Florian
Assignee: Dan Florian
Priority: Blocker
Fix For: 0.7
Attachments: DNA-549.patch
There is no way to differentiate between when a new property is created and when an
existing property is set. Both are handled using the SetPropertyRequest. The JCR spec
clearly states the difference between these two cases as each one has their own event
type.
Work to change to the relevant change requests, update connectors, and update the
NetChangeObserver will need to be done.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5948
days inactive
6008
days old
9 comments
3 participants
participants (3)
-
Brian Carothers (JIRA) -
Dan Florian (JIRA)
-
Randall Hauch (JIRA)