[
https://jira.jboss.org/jira/browse/DNA-376?page=com.atlassian.jira.plugin...
]
Brian Carothers resolved DNA-376.
---------------------------------
Fix Version/s: 0.5
(was: 0.6)
Resolution: Done
Assignee: Brian Carothers (was: Randall Hauch)
Resolved defect by applying DNA-376_final.patch which:
- Adds "before" property to MoveBranchRequest which can be used in lieu of the
"into" property. If the before is populated, the node should moved into the
parent of the "before" location and located immediately before the child node
with the "before" location. Added test case to WriteableConnectorTest to test
this behavior.
- Modified writable connectors to support "before" property on MoveBranchRequest
and no longer require that "into" property is not null.
- Added support for "before" preposition on Graph and Graph.Batch for move
operation.
- Modified JCR layer to support ordering of child nodes with AbstractJcrNode.orderBefore
by adding a method to SessionCache.NodeEditor and adding comparable operations to
ImmutableChildren and ChangedChildren
- Uncommented relevant tests in JcrTckTest
Add request to change the order of a child node (or nodes) relative
to the other children
-----------------------------------------------------------------------------------------
Key: DNA-376
URL:
https://jira.jboss.org/jira/browse/DNA-376
Project: DNA
Issue Type: Feature Request
Components: API, Graph
Affects Versions: 0.3
Reporter: Randall Hauch
Assignee: Brian Carothers
Priority: Blocker
Fix For: 0.5
Attachments: DNA-376.patch, DNA-376_final.patch, DNA-376_for_commit.patch
The current DNA Graph model does support ordered children, and while rename can be used
to change the order of same-name-siblings, there currently is no way to change the order
of the child nodes. This is required to fully implement the JCR API.
JCR handles this functionality by provided a method that essentially changes the position
of a single child node. The "Node.orderBefore(String childNameToBeMoved, String
nameOfChildAtPosition)" can be used by calling on the parent node and supplying the
name (with SNS index if needed) of the child to be moved and the name of the child before
which the other child is to be moved.
This same model can be used for the graph request. It also would allow adding in the
future another optional request that would contain multiple reorders, and that could be
implemented in RequestProcessor to break into multiple ReorderChildRequest instances.
The existing (writable) connectors will all be affected, since this will be a new
mandatory request.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira