Hey Adam, nice work on all this! Its looking great. One question. Is this going to work on all operating systems?
https://github.com/forge/addon-gradle/compare/1e501ac1f3f7...d8a4cdd3b859#L7L30
You might want to ask george and Vineet about this because I think we have a common way to handle OS path canonicalization.
Keep up the great work!
---
Lincoln Baxter's Droid
http://ocpsoft.org
"Keep it Simple"
Branch: refs/heads/master
Home: https://github.com/forge/addon-gradle
Commit: ddd10ce6bc84b9c219a593afc97a7cb728e046f8
https://github.com/forge/addon-gradle/commit/ddd10ce6bc84b9c219a593afc97a7cb728e046f8
Author: Adam Wyłuda <adamwyl92@gmail.com>
Date: 2013-08-08 (Thu, 08 Aug 2013)
Changed paths:
M impl/src/main/java/org/jboss/forge/addon/gradle/parser/GradleSourceUtil.java
M impl/src/test/java/org/jboss/forge/addon/gradle/parser/GradleSourceUtilTest.java
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/GradleFacetTest.java
Log Message:
-----------
Fix GradleSourceUtil.insertTask()
Commit: 71587e673afa3e89650a39530f82875934d8e132
https://github.com/forge/addon-gradle/commit/71587e673afa3e89650a39530f82875934d8e132
Author: Adam Wyłuda <adamwyl92@gmail.com>
Date: 2013-08-08 (Thu, 08 Aug 2013)
Changed paths:
M impl-projects/src/main/java/org/jboss/forge/addon/gradle/projects/GradleFacetImpl.java
M impl/src/main/java/org/jboss/forge/addon/gradle/parser/GradleSourceUtil.java
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/GradleTestProjectProvider.java
M tests/src/test/resources/build.gradle
Log Message:
-----------
Improve GradleFacet implementation and fix test (now passes all)
Commit: 24cd34bf40e4aaaa4a4bad42a5acf7edee8ba62f
https://github.com/forge/addon-gradle/commit/24cd34bf40e4aaaa4a4bad42a5acf7edee8ba62f
Author: Adam Wyłuda <adamwyl92@gmail.com>
Date: 2013-08-08 (Thu, 08 Aug 2013)
Changed paths:
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/GradleTestProjectProvider.java
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/ProjectAssert.java
Log Message:
-----------
Fix ProjectAssert
Commit: d8a4cdd3b859ef2e59c080da1a8739a2cc2c0a03
https://github.com/forge/addon-gradle/commit/d8a4cdd3b859ef2e59c080da1a8739a2cc2c0a03
Author: Adam Wyłuda <adamwyl92@gmail.com>
Date: 2013-08-08 (Thu, 08 Aug 2013)
Changed paths:
M impl-projects/src/main/java/org/jboss/forge/addon/gradle/projects/GradleProjectLocator.java
M impl-projects/src/main/java/org/jboss/forge/addon/gradle/projects/facets/GradleResourceFacet.java
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/facets/GradleResourceFacetTest.java
Log Message:
-----------
Implement GradleResourceFacet
Compare: https://github.com/forge/addon-gradle/compare/1e501ac1f3f7...d8a4cdd3b859
_______________________________________________
forge-commits mailing list
forge-commits@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/forge-commits