Hello George (and all),

I understand. As a suggestion, could I make a case (implying a JIRA issue and following patch, I presume :) ) for placing the codestyle configuration for IDEs and Maven plugins within a "Codestyle" maven project, placed within the root of the the Forge Core repository? (Or somewhere else, if you deem there is a better location).

The approach has been used smoothly within several large-scale projects, so I feel decently confident that it works well. 
Moreover, I have an somewhat documented example of this approach if you feel like taking a look:

  1. Maven site documentation and partial explanation found at https://bytebucket.org/lennartj/nazgul_tools/wiki/mavenSite/2.0.8/codestyle/index.html
  2. Repository available for cloning at   hg clone https://bitbucket.org/lennartj/nazgul_tools

Let me know if you feel this is not worth investigating. Otherwise, I will place a JIRA, create a patch, introduce some code quality plugins in Maven and provide a Intellij IDEA integration, hopefully with the exact same codestyle as the current Eclipse one.
Fair?



2013/7/24 <ggastald@redhat.com>
Hello Lennart,

Welcome to the forge-dev list! My name is George and I am one of the core developers of JBoss Forge. Please find your answers below:

1) The only code formatter we use in Forge core is the https://github.com/forge/core/blob/master/eclipse-code-formatter-profile.xml
2) Absolutely, code quality plugins are very important and we would appreciate using them as part of the build.

As always, pull-requests with an associated JIRA ( http://issues.jboss.org/browse/FORGE) are more than welcome! :)

Best Regards and Keep Forgin' !

George Gastaldi



On 07/24/2013 02:15 PM, Lennart Jörelid wrote:
Hello all,

Hope you are enjoying some high-quality vacation time this time of the year.

Two Forge-Dev newbie questions here:

  1. I am in the process of creating a few patches or suggestions for Forge, and wonder if we have a codestyle XML or JAR for IntelliJ IDEA which matches the codestyle used in Forge. I have snooped around a tad on the site and in the repo, but so far could not find any. 
  2. While it is nice to use any IDE to define codestyle, it is even better if some code quality plugins run within Maven can validate/enforce the code quality within our development. I can find some (rather nonintrusive) plugin version definitions within the jboss-parent-10.pom, but not any actual codestyle enforcements (at least not within the Forge project). Have I missed them, or have the dev community agreed that we do not need code quality plugins run?
Thanks in advance.

:)
--
+==============================+
| Bästa hälsningar,
| [sw. "Best regards"]
|
| Lennart Jörelid
| EAI Architect & Integrator
|
| jGuru Europe AB
| Mölnlycke - Kista
|
| Email: lj@jguru.se
| URL:   www.jguru.se
| Phone
| (skype):    jgurueurope
| (intl):     +46 708 507 603
| (domestic): 0708 - 507 603
+==============================+
 


_______________________________________________
forge-dev mailing list
forge-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/forge-dev

--
George Gastaldi | Senior Software Engineer
JBoss Forge Team
Red Hat

_______________________________________________
forge-dev mailing list
forge-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/forge-dev



-- 
--
+==============================+
| Bästa hälsningar,
| [sw. "Best regards"]
|
| Lennart Jörelid
| EAI Architect & Integrator
|
| jGuru Europe AB
| Mölnlycke - Kista
|
| Email: lj@jguru.se
| URL:   www.jguru.se
| Phone
| (skype):    jgurueurope
| (intl):     +46 708 507 603
| (domestic): 0708 - 507 603
+==============================+