On Tue, Jul 17, 2012 at 5:11 PM, Lincoln Baxter, III <lincolnbaxter@gmail.com> wrote:

Hey James,

Awesome work on the AS7 plugin enhancements. I have a few comments :)

It looks like pressing CTRL-C kills the appserver, which may or may not be a good thing.

[as7-test] as7-test $
[as7-test] as7-test $ [killed]
[as7-test] as7-test $ 16:57:46,157 INFO [org.jboss.as.osgi] (MSC service thread 1-3) JBAS011942: Stopping OSGi Framework
16:57:46,188 INFO [org.jboss.as.logging] JBAS011503: Restored bootstrap log handlers
16:57:46,200 INFO [com.arjuna.ats.jbossatx] ARJUNA032018: Destroying TransactionManagerService
16:57:46,204 INFO [com.arjuna.ats.jbossatx] ARJUNA032014: Stopping transaction recovery manager
16:57:46,214 INFO [org.jboss.as] JBAS015950: JBoss AS 7.1.1.Final "Brontes" stopped in 65ms

[as7-test] as7-test $

Also looks like once that is done, when you exit the project, the plugin tries to shut down the server?

[as7-test] as7-test $
[as7-test] as7-test $ cd ..
***INFO*** An event occurred that requires the server be shutdown.
[no project] Desktop $

Also, when downloading AS7, you probably want to activate the shell Wait: https://github.com/forge/core/blob/master/shell/src/test/java/org/jboss/forge/shell/WaitTest.java#L32

[generated-pom] as7 $
[generated-pom] as7 $ as7 setup
? The Java Home '/System/Library/Frameworks/JavaVM.framework/Versions/1.6.0/Home' is already set, would you like to override it? [y/N]
? A default version of 7.1.1.Final is already set, would you like to override it? [y/N]
? Enter path for JBoss AS or leave blank to download:
? You are about to download JBoss AS 7.1.1.Final to '/Users/lbaxter/Desktop/as7/target/jboss-as-dist' which could take a while. Would you like to continue? [Y/n]
***SUCCESS*** Installed [AS7ServerFacet] successfully.
[generated-pom] as7 $

Looks great!

--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."