[JBoss JIRA] (FORGE-1116) Move forge.compatibility.IDE to the Environment Addon
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1116?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-1116.
----------------------------------
Fix Version/s: (was: 2.x Future)
Resolution: Won't Fix
UIProvider.isGUI() should be used instead.
> Move forge.compatibility.IDE to the Environment Addon
> -----------------------------------------------------
>
> Key: FORGE-1116
> URL: https://issues.jboss.org/browse/FORGE-1116
> Project: Forge
> Issue Type: Feature Request
> Components: Builtin Plugins
> Affects Versions: 2.0.0.Alpha10
> Reporter: Lincoln Baxter III
>
> From the shell addon:
> {code}
> public void startupDefaultShell(@Observes PostStartup startup) throws Exception
> {
> if (!Boolean.getBoolean("forge.compatibility.IDE"))
> {
> Settings settings = new SettingsBuilder().create();
> this.shell = shellFactory.createShell(settings);
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (FORGE-1137) Refactor ServletFacet
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1137?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-1137.
----------------------------------
Fix Version/s: (was: 2.x Future)
Resolution: Won't Fix
We can reopen this issue later if there is any demand for it
> Refactor ServletFacet
> ---------------------
>
> Key: FORGE-1137
> URL: https://issues.jboss.org/browse/FORGE-1137
> Project: Forge
> Issue Type: Enhancement
> Components: Java EE APIs
> Affects Versions: 2.0.0.Alpha11
> Reporter: George Gastaldi
>
> {quote}
> <gastaldi> in Forge 2.x, should the ServletFacetImpl.isInstalled() check for web.xml existence to assert that it is installed ?
> <gastaldi> I think it should only check if the required deps are met
> <gastaldi> and @RequireFacet(WebResourcesFacet.class) perhaps
> <lincolnthree> gastaldi: why this change? (leading question)
> <gastaldi> FORGE-1135
> <jbossbot> jira [FORGE-1135] ServletFacetImpl overrides isInstalled of BaseJavaEEFacet but doesnt call super.isInstalled [Closed (Done) Bug, Major, Thomas Frühbeck] https://issues.jboss.org/browse/FORGE-1135
> <gastaldi> if we think about it, checking for the web.xml presence doesn't make much sense in it
> <lincolnthree> why is that?
> <gastaldi> suppose you're writing a java library that depends on Servlet API
> <vineetreynolds> Servlet 3.0
> <gastaldi> yes
> <gastaldi> Why would you need web.xml in it?
> <lincolnthree> im playing devil's advocate here
> <vineetreynolds> Even web-framgment.xml changes the equation
> <lincolnthree> i'd say that we should have 2 facets then, or 3 facets
> <vineetreynolds> It could be a jar with a web-fragment.xml
> <lincolnthree> ServletFacet25
> <lincolnthree> ServletFacet30
> <vineetreynolds> Yes, like SW
> <vineetreynolds> Activate based on version value in the XML
> <vineetreynolds> version="2.5", version="3.0"
> <lincolnthree> ServletFragmentFacet30
> <gastaldi> I think we should move the org.jboss.forge.addon.javaee.facets.ServletFacet.getConfig() to another facet
> <gastaldi> WebResourcesFacet perhaps
> <lincolnthree> gastaldi: WebResourceFacet is even less tied to servlet than servlet it
> <lincolnthree> is
> <lincolnthree> that just adds src/web/resources
> <lincolnthree> err
> <lincolnthree> src/main/webapp
> <vineetreynolds> Right
> <gastaldi> sure, just saying that maybe it doesn't make much sense to be in ServletFacet
> <vineetreynolds> Do we even need a ServletFacet ?
> <lincolnthree> gastaldi: I don't see why not
> <vineetreynolds> nvm
> <vineetreynolds> We need a facet for the dependency
> <lincolnthree> vineetreynolds: yes
> <vineetreynolds> ServletAPIFacet
> <gastaldi> yeah, something like that
> <lincolnthree> ServletApiFacet30
> <gastaldi> like Faces does
> <vineetreynolds> I dont think we should tie to the web.xml file
> <vineetreynolds> unless we need to
> <lincolnthree> vineetreynolds: if there is a web.xml file, it should be respected
> <lincolnthree> if there is not, it should not be required for 3.0
> <lincolnthree> but for 2.5 it should be
> <vineetreynolds> Well, the dependency is more important imho
> <gastaldi> lincolnthree, unless the PackagingType != WAR
> <gastaldi> if it's a library, web.xml is never required in the current project
> <lincolnthree> gastaldi: sure
> <gastaldi> hence, should use named web-fragment
> <gastaldi> s/use/be
> <lincolnthree> gastaldi: again… only in 3.0
> <gastaldi> yea
> <gastaldi> in 2.5 should not rely on any descriptor if PackagingType is not WAR
> <lincolnthree> correct
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (FORGE-1172) Port the JPA commands
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1172?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-1172.
----------------------------------
Assignee: George Gastaldi
Fix Version/s: 2.0.0.Alpha14
(was: 2.0.0.Final)
Resolution: Done
Field and setup plugins were migrated. update-entity should be reviewed if belongs to the JPA scope
> Port the JPA commands
> ---------------------
>
> Key: FORGE-1172
> URL: https://issues.jboss.org/browse/FORGE-1172
> Project: Forge
> Issue Type: Sub-task
> Components: Builtin Plugins
> Reporter: Vineet Reynolds
> Assignee: George Gastaldi
> Fix For: 2.0.0.Alpha14
>
>
> Commands in Forge 1:
> * persistence setup
> * persistence <default_command>
> * entity new-entity
> * field <default_command>
> * field custom
> * field boolean
> * field int
> * field long
> * field number
> * field temporal
> * field string
> * field lob
> * field oneToOne
> * field manyToMany
> * field oneToMany
> * field manyToOne
> * update-entity hashcode-and-equals
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (FORGE-1199) Cannot use JAXB inside a plugin
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1199?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III closed FORGE-1199.
-------------------------------------
Fix Version/s: (was: 1.x Future)
Resolution: Out of Date
Hey Luca, could you try this with a Forge 2 plugin? There are a lot of issues with Forge 1 classloading that we are not going to fix in Forge 1 branch, that is why we are doing the Forge 2 rewrite.
Thanks! Sorry for the trouble.
> Cannot use JAXB inside a plugin
> -------------------------------
>
> Key: FORGE-1199
> URL: https://issues.jboss.org/browse/FORGE-1199
> Project: Forge
> Issue Type: Bug
> Affects Versions: 1.4.0.Final
> Reporter: Luca Masini
>
> I need to unmarshal some XML using JAXB.
> If I try to add this dependency:
> <dependency>
> <groupId>com.sun.xml.bind</groupId>
> <artifactId>jaxb-xjc</artifactId>
> <version>2.2.1</version>
> <scope>compile</scope>
> <exclusions>
> <exclusion>
> <groupId>com.sun.xml.bind</groupId>
> <artifactId>jaxb-impl</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> and then to create a JAXB Context:
> final JAXBContext context = JAXBContext.newInstance(Model.class);
> then I got an exception when launching the plugin:
> javax.xml.bind.JAXBException
> - with linked exception:
> [java.lang.ClassNotFoundException: com.sun.xml.internal.bind.v2.ContextFactory from [Module "it.xxxxxxx.forge.prova-plugin:1.0.0-SNAPSHOT-c1d512df-2daa-4ebe-ae7a-154e102bb88d" from local module loader @15aaf0b3 (roots: /Applications/sviluppo/jboss/forge-distribution-1.4.0.Final/modules,/Users/ictlm1/.forge/plugins,/Users/ictlm1/Documents/progetti/forge)]]
> at javax.xml.bind.ContextFinder.newInstance(ContextFinder.java:187)
> at javax.xml.bind.ContextFinder.find(ContextFinder.java:376)
> at javax.xml.bind.JAXBContext.newInstance(JAXBContext.java:574)
> at javax.xml.bind.JAXBContext.newInstance(JAXBContext.java:522)
> at it.xxx.forge.parser.Parser.parse(Parser.java:17)
> at it.xxx.forge.forge.CreateEntitiesPlugin.parse(CreateEntitiesPlugin.java:19)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.jboss.forge.shell.command.Execution.perform(Execution.java:160)
> ...
> ...
> Caused by: java.lang.ClassNotFoundException: com.sun.xml.internal.bind.v2.ContextFactory from [Module "it.esselunga.forge.prova-plugin:1.0.0-SNAPSHOT-c1d512df-2daa-4ebe-ae7a-154e102bb88d" from local module loader @15aaf0b3 (roots: /Applications/sviluppo/jboss/forge-distribution-1.4.0.Final/modules,/Users/ictlm1/.forge/plugins,/Users/ictlm1/Documents/progetti/forge)]
> at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:190)
> at org.jboss.modules.ConcurrentClassLoader.performLoadClassUnchecked(ConcurrentClassLoader.java:468)
> at org.jboss.modules.ConcurrentClassLoader.performLoadClassChecked(ConcurrentClassLoader.java:456)
> at org.jboss.modules.ConcurrentClassLoader.performLoadClass(ConcurrentClassLoader.java:398)
> at org.jboss.modules.ConcurrentClassLoader.loadClass(ConcurrentClassLoader.java:120)
> at javax.xml.bind.ContextFinder.safeLoadClass(ContextFinder.java:481)
> at javax.xml.bind.ContextFinder.newInstance(ContextFinder.java:185)
> ... 41 more
> ContextFactory is part of rt.jar with is bundled with the JDK, how can I tell the ModuleClassLoader to let me load it ??
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months