[JBoss JIRA] (FORGE-1303) Use Weld's new Singleton API
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1303?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III commented on FORGE-1303:
-------------------------------------------
Well, we obviously try not to rely on TCCL, but there's a chance that addons may use it. But really I think the only reason that we overrode this was because Weld's default singleton provider has some print-out statements in it that we didn't want to show up on the console.
{code}
public void set(T object) {
// TODO remove this
System.out.println("Adding singleton for " + getClassLoader());
store.put(getClassLoader(), object);
}
{code}
> Use Weld's new Singleton API
> ----------------------------
>
> Key: FORGE-1303
> URL: https://issues.jboss.org/browse/FORGE-1303
> Project: Forge
> Issue Type: Task
> Components: Furnace (Container)
> Reporter: Jozef Hartinger
>
> Since Weld 2.1 it is possible to use the new Singleton API http://docs.jboss.org/weld/javadoc/2.1/weld-spi/org/jboss/weld/bootstrap/...
> A String identifier was added to all Singleton's methods. The identifier is used to identify a Weld container. As a result, it is no longer necessary to use the TCCL to identify the right Weld container.
> I am not sure if Forge currently sets the TCCL just because Weld required it in the past or if it is used for something else but either way the new SPI should simplify integration.
> For each module Forge should generate a unique id and pass it to Weld when calling WeldBootstrap.startContainer().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (FORGE-1304) Top level facets are not detected as installed even though subtype facets are installed
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1304?page=com.atlassian.jira.plugin... ]
Vineet Reynolds updated FORGE-1304:
-----------------------------------
Summary: Top level facets are not detected as installed even though subtype facets are installed (was: Top level facets are not detected as installed even though lower-level facets are installed)
> Top level facets are not detected as installed even though subtype facets are installed
> ---------------------------------------------------------------------------------------
>
> Key: FORGE-1304
> URL: https://issues.jboss.org/browse/FORGE-1304
> Project: Forge
> Issue Type: Bug
> Components: Plugin API
> Reporter: Vineet Reynolds
>
> The invocation {{project.getFacet(ServletFacet.class)}} returns null event though the project has the Servlet 3.0 facet associated with it.
> This requires explicit invocations like {{project.getFacet(ServletFacet_3_0.class)}}, {{project.getFacet(ServletFacet_3_1.class)}} etc.
> This also affects other top-level facets like the CDI and EJB facets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (FORGE-1305) Introduce an API equivalent to AbstractProjectCommand for UIWizardStep
by Vineet Reynolds (JIRA)
Vineet Reynolds created FORGE-1305:
--------------------------------------
Summary: Introduce an API equivalent to AbstractProjectCommand for UIWizardStep
Key: FORGE-1305
URL: https://issues.jboss.org/browse/FORGE-1305
Project: Forge
Issue Type: Feature Request
Components: UI - API
Affects Versions: 2.0.0.Alpha14
Reporter: Vineet Reynolds
The {{AbstractProjectCommand}} type corresponding to the {{UICommand}} type provides access to the current project via the {{getSelectedProject(context)}} API.
There is no such project-inclusive equivalent API for the {{UIWizardStep}}, to provide the selected project to UIWizardStep implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (FORGE-1304) Top level facets are not detected as installed even though lower-level facets are installed
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1304?page=com.atlassian.jira.plugin... ]
Vineet Reynolds updated FORGE-1304:
-----------------------------------
Description:
The invocation {{project.getFacet(ServletFacet.class)}} returns null event though the project has the Servlet 3.0 facet associated with it.
This requires explicit invocations like {{project.getFacet(ServletFacet_3_0.class)}}, {{project.getFacet(ServletFacet_3_1.class)}} etc.
This also affects other top-level facets like the CDI and EJB facets.
was:
The invocation {{project.getFacet(ServletFacet.class)}} returns null event though the project has the Servlet 3.0 facet associated with it.
This requires explicit invocations like {{project.getFacet(ServletFacet_3_0.class)}}.
This also affects other top-level facets like the CDI and EJB facets.
> Top level facets are not detected as installed even though lower-level facets are installed
> -------------------------------------------------------------------------------------------
>
> Key: FORGE-1304
> URL: https://issues.jboss.org/browse/FORGE-1304
> Project: Forge
> Issue Type: Bug
> Components: Plugin API
> Reporter: Vineet Reynolds
>
> The invocation {{project.getFacet(ServletFacet.class)}} returns null event though the project has the Servlet 3.0 facet associated with it.
> This requires explicit invocations like {{project.getFacet(ServletFacet_3_0.class)}}, {{project.getFacet(ServletFacet_3_1.class)}} etc.
> This also affects other top-level facets like the CDI and EJB facets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (FORGE-1303) Use Weld's new Singleton API
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1303?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III commented on FORGE-1303:
-------------------------------------------
It would be difficult for us to use this since we don't use WeldBootstrap, we actually just use an extension of the Weld class itself, so that we can provide our own custom ResourceLoader (which may or may not be required anymore.)
> Use Weld's new Singleton API
> ----------------------------
>
> Key: FORGE-1303
> URL: https://issues.jboss.org/browse/FORGE-1303
> Project: Forge
> Issue Type: Task
> Components: Furnace (Container)
> Reporter: Jozef Hartinger
>
> Since Weld 2.1 it is possible to use the new Singleton API http://docs.jboss.org/weld/javadoc/2.1/weld-spi/org/jboss/weld/bootstrap/...
> A String identifier was added to all Singleton's methods. The identifier is used to identify a Weld container. As a result, it is no longer necessary to use the TCCL to identify the right Weld container.
> I am not sure if Forge currently sets the TCCL just because Weld required it in the past or if it is used for something else but either way the new SPI should simplify integration.
> For each module Forge should generate a unique id and pass it to Weld when calling WeldBootstrap.startContainer().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (FORGE-1279) forge install-plugin gives NullPointerException
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1279?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-1279.
----------------------------------
Assignee: George Gastaldi
Fix Version/s: 1.4.3.Final
Resolution: Done
Added null check and issue seems to be resolved
> forge install-plugin gives NullPointerException
> -----------------------------------------------
>
> Key: FORGE-1279
> URL: https://issues.jboss.org/browse/FORGE-1279
> Project: Forge
> Issue Type: Bug
> Components: Forge Build
> Affects Versions: 1.4.2.Final
> Environment: Windows 7
> Reporter: Guy Matthews
> Assignee: George Gastaldi
> Priority: Minor
> Fix For: 1.4.3.Final
>
>
> Typing the command:
> forge install-plugin arquillian
> hangs a long time, and then gives the below NullPointerException. Could we at least get a more detailed error message?
> java.lang.NullPointerException
> at org.jboss.forge.shell.plugins.PluginManager.installFromProject(PluginManager.java:160)
> at org.jboss.forge.shell.plugins.builtin.ForgePlugin.installFromGit(ForgePlugin.java:387)
> at org.jboss.forge.shell.plugins.builtin.ForgePlugin.installFromIndex(ForgePlugin.java:206)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.forge.shell.command.Execution.perform(Execution.java:160)
> at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:109)
> at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:47)
> at org.jboss.forge.shell.ShellImpl$ExecutorThread.run(ShellImpl.java:796)
> at org.jboss.forge.shell.ShellImpl.execute(ShellImpl.java:819)
> at org.jboss.forge.shell.ShellImpl.doShell(ShellImpl.java:609)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.weld.bean.proxy.AbstractBeanInstance.invoke(AbstractBeanInstance.java:48)
> at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:125)
> at org.jboss.forge.shell.ShellImpl$Proxy$_$$_WeldClientProxy.doShell(ShellImpl$Proxy$_$$_WeldClientProxy.java)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163)
> at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299)
> at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188)
> at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59)
> at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265)
> at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234)
> at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635)
> at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:622)
> at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:616)
> at org.jboss.forge.shell.Bootstrap$1.run(Bootstrap.java:186)
> at java.lang.Thread.run(Thread.java:722)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month