[JBoss JIRA] (FORGE-944) Thoughts on CLI renaming on Forge 2
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-944?page=com.atlassian.jira.plugin.... ]
Lincoln Baxter III commented on FORGE-944:
------------------------------------------
Some notes - we basically agree with the "jpa-new-entity" syntax.
https://docs.google.com/document/d/1AVvyz9XsU3pEswkZJFw4iNEkTBtSrnhNqrQ1E...
> Thoughts on CLI renaming on Forge 2
> -----------------------------------
>
> Key: FORGE-944
> URL: https://issues.jboss.org/browse/FORGE-944
> Project: Forge
> Issue Type: Enhancement
> Components: Brainstorming
> Affects Versions: 2.x Future
> Reporter: Antonio Goncalves
> Priority: Optional
> Labels: cli, renaming
> Fix For: 2.x Future
>
>
> I was talking about having CLI naming conventions on the forum and George and Lincoln suggested to add these ideas on a JIRA. So here is my humble contribution to record all the ideas about renaming commands.
> Disclaimer : I haven't used Forge for a long time, I've just started using it again, so some of the following ideas might not be accurate
> As a new comer in Forge I felt the commands were not that intuitive. I loved the following :
> {code}
> java new-enum-type
> java new-itnerface
> java new-class
> {code}
>
> So I was expecting to have something similar in all the other techologies, such as JPA :
> {code}
> jpa new-entity (instead of entity --named)
> jpa new-embedable
> jpa new-mapped-superclass --named Person
> jpa new-entity --named Vet --extends Person
> {code}
> Lincoln suggested having single-level command keywords only such as :
> {code}
> jpa-new-entity (instead of entity --named)
> jpa-new-embedable
> jpa-new-mapped-superclass --named Person
> jpa-new-entity --named Vet --extends Person
> {code}
> h3. Verbs and keywords
> When you look at the commansd, there are several common verbs and keywords than come often :
> {code}
> add : ejb-add-transaction-attribute
> new : beans-new-bean, faces-new-view, new-project (prefer project-new)
> list : list-web-resources, beans list-interceptors, beans list-alternatives, list-scaffold-providers
> setup : ejb setup, entity setup
> put : i18n put
> remove : i18n remove, project remove-property
> execute : execute-java
> set : maven set-groupid
> find : forge find-plugin
> install :
> update : forge update-abort, gitignore update-repo
> run : run-url
> info : analytics info
> {code}
> That brings several thoughts :
> * {{ls}} is used as well as {{list}}, should this be homogenize (e.g. beans-ls-interceptors)
> * {{rm}} is used as well as {{remove}}, should this be homogenize (e.g. i18n-rm, project-rm-property)
> * The difference between {{execute}} and {{run}} is not clear, should this be homogenize and only use one ?
> * Also there is {{execute}} and {{exec}}, this should be homogenize (e.g. {{execute-java}} and {{exec}})
> * Confusion between {{new}} and {{add}}. You create a new class with {{java-new-class}} and shouldn't you add a field and a method to existing class ({{java-add-field}} instead of {{java-new-field}})
> * Some confusion between {{maven}} and {{project}}
> * Is there any difference between {{set}} and {{update}} ? {{maven set-artifactid}} updates the already existing artifactId and {{gitignore update-repo}} updates an existing repo
> * we use {{field}} (e.g. {{java-add-field}}) and then property ({{constraint Future --onProperty date}}), it should be fiels ({{constraint Future --onField date}})
> In many commands you find a type argument such as ({{type}}, {{scaffoldType}}, {{fieldType}} :
> {code}
> scaffold setup --scaffoldType faces
> field manyToMany --named specialties --fieldType ~.model.Specialty.java
> field temporal --type DATE --named date
> {code}
> Why not having only {{type}} in all the cases :
> {code}
> scaffold-setup --type faces
> jpa-add-field manyToMany --named specialties --type ~.model.Specialty.java
> jpa-add-field temporal --named date --type DATE
> {code}
> h3. Grammar
> The CLI grammar could look like this :
> {code}
> command = shell | forge command ;
> forge command = technology,-action,[-artifact] [{--argument value}] ;
> shell = cat | cd | cp | edit | find | grep | ls ...
> technology = project | scaffold | beans | constraint | java | jpa | i18n | ejb ...
> action = add | new | ls | rm | setup ...
> artifact = providers | interceptors | class | filter...
> argument = named | onField | type | extends
> {code}
> h3. Examples
> So if we take that grammar and apply single-level command keywords, we could have things like that :
> {code}
> mkdir
> ls
> ls-commands -all
> project-new --named MyPro
> scaffold-ls-providers
> scaffold-templates --scaffoldType faces
> beans-ls-interceptors
> constraint-new-constraint --named MyConstraint
> constraint-add-constraint MyConstraint --onField MyProp
> java-new-class --named MyClass
> java-add-field 'private List<Vet> vets'
> java-add-method 'public List<Vet> getVetList() {return null;}'
> java-add-annotation --type XmlRootElement --onClass MyClass
> java-add-annotation --type XmlAttribute --onField MyProp
> jpa-new-mapped-superclass --named Person
> jpa-new-entity --named Vet --extends Person
> jpa-add-field manyToOne --named owner --type ~.model.Owner.java
> i18n-add-locale --locale PT
> ejb-new-stateless --named MyStateless
> ejb-new-singleton --named MySingleton --implements MyInterface AndAnotherInterface
> ejb-add-transaction-attribute --type NEVER
> ejb-add-transaction-attribute --type NEVER --onMethod MyNeverMethod
> faces-new-view --named MyView
> faces-set-project-stage --stage PRODUCTION
> servlet-new-filter --named MyFilter
> rest-new-endpoint --named MyEndpoint --extends MyRestExtension
> mvn-build --notest
> {code}
> Scaffolding is a bit tricky because it's extendable and you could end up with
> {code}
> scaffold-ui-from-entity ~.model.*
> scaffold-rest-endpoint-from-entity ~.model.*
> scaffold-dao-from-entity ~.model.*
> scaffold-ejb-service-from-dao ~.dao.*
> scaffold-rest-endpoint-from-dao ~.dao.*
> {code}
> Or something like that
> {code}
> scaffold --ui --from-entity ~.model.*
> scaffold --rest-endpoint --from-entity ~.model.*
> scaffold --dao --from-entity ~.model.*
> scaffold --ejb-service --from-dao ~.dao.*
> scaffold --rest-endpoint --from-dao ~.dao.*
> {code}
> Here are my 2 cents thoughts on a topic that I'm discovering. As you all know, naming is really important and should be looked at carefully. Let's use this JIRA to exchange ideas.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (FORGE-1066) Integer entity field generates NPE in getSearchPredicates
by Antonio Goncalves (JIRA)
Antonio Goncalves created FORGE-1066:
----------------------------------------
Summary: Integer entity field generates NPE in getSearchPredicates
Key: FORGE-1066
URL: https://issues.jboss.org/browse/FORGE-1066
Project: Forge
Issue Type: Bug
Components: Scaffold
Affects Versions: 1.3.3.Final
Reporter: Antonio Goncalves
When I add an Integer attribute to an entity with the following command :
{code}
entity --named Book ;
field number --type java.lang.Integer --named nbOfPage ;
{code}
It creates the following
{code}
@Entity
public class Book implements Serializable
{
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
@Column(name = "id", updatable = false, nullable = false)
private Long id = null;
@Version
@Column(name = "version")
private int version = 0;
@Column
private Integer nbOfPage;
...
}
{code}
The generated Faces {{BookBean}} handles it as a datatype instead of an object, so it gets an NPE if the attribute is null. The generated code is :
{code}
private Predicate[] getSearchPredicates(Root<Book> root)
{
...
Integer nbOfPage = this.example.getNbOfPage();
if (nbOfPage != 0)
...
}
{code}
But it should check null value :
{code}
private Predicate[] getSearchPredicates(Root<Book> root)
{
...
Integer nbOfPage = this.example.getNbOfPage();
if (nbOfPage != null && nbOfPage != 0)
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (FORGE-1054) Forge OpenShift plugin hangs when creating a JBoss app in Windows
by weiweijiang jiang (JIRA)
[ https://issues.jboss.org/browse/FORGE-1054?page=com.atlassian.jira.plugin... ]
weiweijiang jiang commented on FORGE-1054:
------------------------------------------
Also got this issue when testing devenv_stage_429, and log is :
[adfdfasdf] adfdfasdf $ rhc setup
***INFO*** Loaded OpenShift configuration from C:\Users\window7/.openshift/expre
ss.conf
? Enter the application name [adfdfasdf] [adfdfasdf]
***INFO*** Using RHLOGIN:wjiang@redhat.com for https://ec2-54-221-0-244.compute-
1.amazonaws.com
? Enter your Red Hat Openshift password: ******
***INFO*** Found OpenShift User: wjiang(a)redhat.com
Choose a JBoss Cartridge:
1 - [Cartridge [name=jbossews-2.0]]*
2 - [Cartridge [name=jbossews-1.0]]
3 - [Cartridge [name=jbosseap-6.0]]
4 - [Cartridge [name=jbossas-7]]
? Choose an option by typing the number of the selection [*-default] [0]
***INFO*** Using JBoss Cartridge: jbossews-2.0
Initialized empty Git repository in C:/Users/window7/Downloads/forge-distributio
n-1.3.3.Final/adfdfasdf/.git/
***INFO*** Waiting for OpenShift to propagate DNS
***INFO*** Trying to contact http://adfdfasdf-wjiang.dev.rhcloud.com/ (attempt 1
of 500)
Updating openshift
> Forge OpenShift plugin hangs when creating a JBoss app in Windows
> -----------------------------------------------------------------
>
> Key: FORGE-1054
> URL: https://issues.jboss.org/browse/FORGE-1054
> Project: Forge
> Issue Type: Bug
> Affects Versions: 1.3.3.Final
> Environment: Window7
> Git-1.8.3-preview2013.6.1 jdk-7u25-windows-x64
> Reporter: nan wei
>
> Description of problem:
> When creating a jboss app, app creation process hang there.
> Version:
> forge-distribution-1.3.3.Final.zip
> Window7
> Git-1.8.3-preview2013.6.1 jdk-7u25-windows-x64
> How reproducible:
> always
> Steps to Reproduce:
> 1. Ensure that you have already installed a Java 6+ JDK.
> 1.1 install jdk-7u25-windows-x64
> 1.2 set JAVA_HOME.
> 2. Download Forge 1.3.2.Final and Un-zip Forge into a folder on your hard-disk, this folder will be your FORGE_HOME.
> 2.1 Add '$FORGE_HOME/bin' to your windows path.
> 2.2 installing Git(Git-1.8.3-preview2013.6.1)
> 3. Open a command prompt and run 'forge.bat'.
> 4. Install OpenShift plugin for forge.
> 5. create a jboss app.
> Actual results:
> [forge-openshift-demo] forge-openshift-demo $ rhc setup
> ***INFO*** Loaded OpenShift configuration from C:\Users\nanwei/.openshift/expres
> s.conf
> ? Enter the application name [forgeopenshiftd] [forgeopenshiftd] wsy
> ***INFO*** Using RHLOGIN:nwei for https://10.4.59.171
> ? Enter your Red Hat Openshift password: ******
> ***INFO*** Found OpenShift User: nwei
> Choose a JBoss Cartridge:
>
> 1 - [Cartridge [name=jbosseap-6.0]]*
> 2 - [Cartridge [name=jbossews-2.0]]
> 3 - [Cartridge [name=jbossews-1.0]]
>
> ? Choose an option by typing the number of the selection [*-default] [0] 1
> ***INFO*** Using JBoss Cartridge: jbosseap-6.0
> Initialized empty Git repository in C:/Users/nanwei/Downloads/forge/bin/forge-op
> enshift-demo/.git/
> ***INFO*** Waiting for OpenShift to propagate DNS
> ***INFO*** Trying to contact http://forge-nweidomain.osetestv2.com/ (attempt 1 of
> 500)
> Updating openshift
> Expected results:
> The process will hang there for ever.
> Additional info:
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months