[JBoss JIRA] (FORGE-1125) Images path in forge-style.css is missing the contextPath
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1125?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-1125:
----------------------------------------
Gerry,
Could you submit a Pull request with the changes? If done in time, we can still make it to 1.4.1.Final, to be released tonight or tomorrow morning.
Best Regards,
George Gastaldi
> Images path in forge-style.css is missing the contextPath
> ---------------------------------------------------------
&…
[View More]gt;
> Key: FORGE-1125
> URL: https://issues.jboss.org/browse/FORGE-1125
> Project: Forge
> Issue Type: Feature Request
> Components: Scaffold
> Affects Versions: 1.3.3.Final
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Priority: Trivial
> Fix For: 1.4.0.Final
>
>
> {quote}
> <jp_2013> One thing I noticed about the scaffolding is that the CSS images don't seem to work. I had to update the background-image url to have #{request.contextPath}/resources/ in front of the file names
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[View Less]
11 years, 7 months
[JBoss JIRA] (FORGE-1125) Images path in forge-style.css is missing the contextPath
by Gerry Matte (JIRA)
[ https://issues.jboss.org/browse/FORGE-1125?page=com.atlassian.jira.plugin... ]
Gerry Matte commented on FORGE-1125:
------------------------------------
I don't believe this change was effective in resolving the problem. The css references that used to contain only the file name in the url are now preceded by the context-path and /resources/ but the entire string within the url() must be enclosed in single quotes. The current change only precedes the file name with the context path and /…
[View More]resources/
IMHO the context path is not required .... only the /resources/ must precede the file name AND the entire relative path string must be enclosed in single quotes.
I encountered this problem while debugging my webapp's custom exception handler - I noted that unexpected 404 errors were being caught by my exception handler although they were not visible to the end user browser (because they were image resources not found rather than an entire page not found).
My solution was to enclose all url file names in forge-style.css within single quotes and to also prefix the file name with /resources/
Thusly, line 241 which had been:
background-image: url(search.png);
became
background-image: url('/resources/search.png');
The lines that required these changes were 241,281,288,359,384, and 434.
(Note that 434 was not modified as part of FORGE-1125 fix)
> Images path in forge-style.css is missing the contextPath
> ---------------------------------------------------------
>
> Key: FORGE-1125
> URL: https://issues.jboss.org/browse/FORGE-1125
> Project: Forge
> Issue Type: Feature Request
> Components: Scaffold
> Affects Versions: 1.3.3.Final
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Priority: Trivial
> Fix For: 1.4.0.Final
>
>
> {quote}
> <jp_2013> One thing I noticed about the scaffolding is that the CSS images don't seem to work. I had to update the background-image url to have #{request.contextPath}/resources/ in front of the file names
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[View Less]
11 years, 7 months
[JBoss JIRA] (FORGE-1209) Imported<?>.isSatisfied ignores custom scopes
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1209?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-1209:
-----------------------------------
Description:
Imported.isSatisfied returns true for objects without an active context.
eg:
{code:java}
@CommandScoped
public class CommandScopedModel
{code}
The following test fails:
Having :
{code:java}
@Inject
private Imported<CommandScopedModel> modelInstance;
{code}
Considering that the custom scope context is …
[View More]implemented correctly, the following code fails in the first assertion:
{code:java}
@Test
public void testImportedWithCustomScope() throws Exception
{
Assert.assertFalse("Should not be satisfied since there is no Context in scope", modelInstance.isSatisfied());
Assert.assertTrue(wizardTester.isValid());
Assert.assertTrue("Should be satisfied since there command context was initialized", modelInstance.isSatisfied());
wizardTester.finish(null);
Assert.assertFalse("Should not be satisfied since there is no Context in scope after finish is called",
modelInstance.isSatisfied());
}
{code}
This is implemented in the ui-addon: {{org.jboss.forge.addon.ui.scope.CommandScopedTest.testImportedWithCustomScope()}}
was:
Imported.isSatisfied returns true for objects without an active contexts.
eg:
{code:java}
@CommandScoped
public class CommandScopedModel
{code}
The following test fails:
Having :
{code:java}
@Inject
private Imported<CommandScopedModel> modelInstance;
{code}
Considering that the custom scope context is implemented correctly, the following code fails in the first assertion:
{code:java}
@Test
public void testImportedWithCustomScope() throws Exception
{
Assert.assertFalse("Should not be satisfied since there is no Context in scope", modelInstance.isSatisfied());
Assert.assertTrue(wizardTester.isValid());
Assert.assertTrue("Should be satisfied since there command context was initialized", modelInstance.isSatisfied());
wizardTester.finish(null);
Assert.assertFalse("Should not be satisfied since there is no Context in scope after finish is called",
modelInstance.isSatisfied());
}
{code}
This is implemented in the ui-addon: {{org.jboss.forge.addon.ui.scope.CommandScopedTest.testImportedWithCustomScope()}}
> Imported<?>.isSatisfied ignores custom scopes
> ---------------------------------------------
>
> Key: FORGE-1209
> URL: https://issues.jboss.org/browse/FORGE-1209
> Project: Forge
> Issue Type: Bug
> Components: Furnace (Container)
> Reporter: George Gastaldi
> Fix For: 2.x Future
>
>
> Imported.isSatisfied returns true for objects without an active context.
> eg:
> {code:java}
> @CommandScoped
> public class CommandScopedModel
> {code}
> The following test fails:
> Having :
> {code:java}
> @Inject
> private Imported<CommandScopedModel> modelInstance;
> {code}
> Considering that the custom scope context is implemented correctly, the following code fails in the first assertion:
> {code:java}
> @Test
> public void testImportedWithCustomScope() throws Exception
> {
> Assert.assertFalse("Should not be satisfied since there is no Context in scope", modelInstance.isSatisfied());
> Assert.assertTrue(wizardTester.isValid());
> Assert.assertTrue("Should be satisfied since there command context was initialized", modelInstance.isSatisfied());
> wizardTester.finish(null);
> Assert.assertFalse("Should not be satisfied since there is no Context in scope after finish is called",
> modelInstance.isSatisfied());
> }
> {code}
> This is implemented in the ui-addon: {{org.jboss.forge.addon.ui.scope.CommandScopedTest.testImportedWithCustomScope()}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[View Less]
11 years, 7 months
[JBoss JIRA] (FORGE-1209) Imported<?>.isSatisfied ignores custom scopes
by George Gastaldi (JIRA)
George Gastaldi created FORGE-1209:
--------------------------------------
Summary: Imported<?>.isSatisfied ignores custom scopes
Key: FORGE-1209
URL: https://issues.jboss.org/browse/FORGE-1209
Project: Forge
Issue Type: Bug
Components: Furnace (Container)
Reporter: George Gastaldi
Fix For: 2.x Future
Imported.isSatisfied returns true for objects without an active contexts.
eg:
{…
[View More]code:java}
@CommandScoped
public class CommandScopedModel
{code}
The following test fails:
Having :
{code:java}
@Inject
private Imported<CommandScopedModel> modelInstance;
{code}
Considering that the custom scope context is implemented correctly, the following code fails in the first assertion:
{code:java}
@Test
public void testImportedWithCustomScope() throws Exception
{
Assert.assertFalse("Should not be satisfied since there is no Context in scope", modelInstance.isSatisfied());
Assert.assertTrue(wizardTester.isValid());
Assert.assertTrue("Should be satisfied since there command context was initialized", modelInstance.isSatisfied());
wizardTester.finish(null);
Assert.assertFalse("Should not be satisfied since there is no Context in scope after finish is called",
modelInstance.isSatisfied());
}
{code}
This is implemented in the ui-addon: {{org.jboss.forge.addon.ui.scope.CommandScopedTest.testImportedWithCustomScope()}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[View Less]
11 years, 7 months
[JBoss JIRA] (FORGE-1102) Support detection/registration/installation of undeclared dependent facets
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1102?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III commented on FORGE-1102:
-------------------------------------------
Final API:
{code}@FacetConstraint{code}
and
{code}
@FacetConstraints({
@FacetConstraint(value = OtherFacet.class, type = FacetConstraintType.REQUIRED)
})
{code}
> Support detection/registration/installation of undeclared dependent facets
> ----------------------------------------------------…
[View More]----------------------
>
> Key: FORGE-1102
> URL: https://issues.jboss.org/browse/FORGE-1102
> Project: Forge
> Issue Type: Feature Request
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Assignee: Lincoln Baxter III
> Fix For: 2.0.0.Alpha12
>
>
> Based on FORGE-1101, facets that are not declared via {{@RequiresFacet}} may not be visible via {{Project.hasFacet()}} at the right time since the {{ProjectFactory}}'s registry may not process these facets in the right order. It would be a good idea to hint the {{ProjectFactory}} that a particular Facet may have to be registered.
> To explain further, the {{RestFacet}} does not declare any dependencies on the {{RestWebXmlFacet}} and the {{RestApplicationFacet}}. These facets are therefore not always detected via the {{project.hasFacet()}} invocations.
> Declaring them as facets via a {{@RequiresOnlyOneFacet}} annotation could be one solution to ensure that only one facet within a group should be sufficient to satisfy the desired constraints on a Faceted type. Likewise, we could also add support for optional facets that are may be installed if possible, via a {{@OptionalFacets}} annotation.
> This would probably be better supported in 2.x instead of 1.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[View Less]
11 years, 7 months
[JBoss JIRA] (FORGE-1207) @RequiresFacet not found
by Robb Greathouse (JIRA)
Robb Greathouse created FORGE-1207:
--------------------------------------
Summary: @RequiresFacet not found
Key: FORGE-1207
URL: https://issues.jboss.org/browse/FORGE-1207
Project: Forge
Issue Type: Feature Request
Components: Addon Manager
Affects Versions: 2.0.0.Alpha12
Environment: Switchyard plugin SwitchYardFacet
Reporter: Robb Greathouse
org.jboss.forge.addon.facets.constraints.…
[View More]RequiresFacet;
Can not be found. Simply removing @RequiresFacet({ DependencyFacet.class, MavenPluginFacet.class, PackagingFacet.class })
Causes tests to not run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[View Less]
11 years, 7 months