[JBoss JIRA] (FORGE-1410) Rename services-list to service-list
by Antonio Goncalves (JIRA)
Antonio Goncalves created FORGE-1410:
----------------------------------------
Summary: Rename services-list to service-list
Key: FORGE-1410
URL: https://issues.jboss.org/browse/FORGE-1410
Project: Forge
Issue Type: Sub-task
Components: UI - Shell
Affects Versions: 2.0.0.Beta4
Reporter: Antonio Goncalves
As for [FORGE-1396], all the commands should be in singular (not plural). So {{services-list}} should be renamed to {{service-list}} (without 's').
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (FORGE-1396) Singular or Plural ?
by Antonio Goncalves (JIRA)
[ https://issues.jboss.org/browse/FORGE-1396?page=com.atlassian.jira.plugin... ]
Antonio Goncalves closed FORGE-1396.
------------------------------------
Resolution: Done
> Singular or Plural ?
> --------------------
>
> Key: FORGE-1396
> URL: https://issues.jboss.org/browse/FORGE-1396
> Project: Forge
> Issue Type: Sub-task
> Components: UI - Shell
> Affects Versions: 2.0.0.Beta4
> Reporter: Antonio Goncalves
>
> For listing all the services we use the {{services-list}} command. Here, {{services}} is in plural. But if we have several commands related to services, we might end-up with a mixture of singular and plural :
> {code}
> services-list
> service-register-as-serviceloader
> {code}
> Same thing could happen if we list all add-ons (here I'm supposing that the command {{addons-list}} exits) :
> {code}
> addons-list
> addon-build-and-install
> addon-install
> addon-new-command
> addon-remove
> {code}
> Is the mixture or plural and singular ok ? Shouldn't it all be in singular :
> {code}
> addon-list
> service-list
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (FORGE-1409) Expose UIContext's Attributes as a Map
by George Gastaldi (JIRA)
George Gastaldi created FORGE-1409:
--------------------------------------
Summary: Expose UIContext's Attributes as a Map
Key: FORGE-1409
URL: https://issues.jboss.org/browse/FORGE-1409
Project: Forge
Issue Type: Enhancement
Components: UI - API
Affects Versions: 2.0.0.Beta4
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 2.0.0.Final
By declaring the UIContext attributes as a Map, it's possible to take advantage of the {{java.util.Map}} methods (like size(), containsKey()) without the need to encapsulate it in the UIContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (FORGE-1396) Singular or Plural ?
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1396?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III commented on FORGE-1396:
-------------------------------------------
Thanks Catherine!
> Singular or Plural ?
> --------------------
>
> Key: FORGE-1396
> URL: https://issues.jboss.org/browse/FORGE-1396
> Project: Forge
> Issue Type: Sub-task
> Components: UI - Shell
> Affects Versions: 2.0.0.Beta4
> Reporter: Antonio Goncalves
>
> For listing all the services we use the {{services-list}} command. Here, {{services}} is in plural. But if we have several commands related to services, we might end-up with a mixture of singular and plural :
> {code}
> services-list
> service-register-as-serviceloader
> {code}
> Same thing could happen if we list all add-ons (here I'm supposing that the command {{addons-list}} exits) :
> {code}
> addons-list
> addon-build-and-install
> addon-install
> addon-new-command
> addon-remove
> {code}
> Is the mixture or plural and singular ok ? Shouldn't it all be in singular :
> {code}
> addon-list
> service-list
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (FORGE-1407) Shell is missing options in wizards where default values allow immediately moving to next step
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1407?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III closed FORGE-1407.
-------------------------------------
Assignee: Lincoln Baxter III
Fix Version/s: 2.0.0.Final
Resolution: Done
> Shell is missing options in wizards where default values allow immediately moving to next step
> ----------------------------------------------------------------------------------------------
>
> Key: FORGE-1407
> URL: https://issues.jboss.org/browse/FORGE-1407
> Project: Forge
> Issue Type: Feature Request
> Components: UI - Shell
> Affects Versions: 2.0.0.Beta4
> Reporter: Lincoln Baxter III
> Assignee: Lincoln Baxter III
> Fix For: 2.0.0.Final
>
>
> Should have a lot more options:
> {code}
> [jpa-demo]$ jpa-setup
> --dataSourceName --dbType --persistenceUnitName
> {code}
> The problem is here in ShellWizard.java (in shell addon)
> {code}
> private CommandLineParser populate(ShellContext shellContext, String line,
> final Map<String, InputComponent<?, ?>> inputs)
> throws Exception
> {
> inputs.putAll(getController().getInputs());
> CommandLineParser parser = commandLineUtil.generateParser(getController(), shellContext, inputs);
> CommandLine cmdLine = parser.parse(line, true);
> Map<String, InputComponent<?, ?>> populatedInputs = commandLineUtil.populateUIInputs(cmdLine, inputs);
> if (getController().isValid())
> {
> if (getController().canMoveToNextStep())
> {
> // The bug is here. we are immediately moving to the next step and removing all inputs that are not populated.
> // this really needs to know if we have defaulted to next step or actually moved there willingly
> // it should not remove old choices until a new choice has been made
> getController().next().initialize();
> inputs.keySet().retainAll(populatedInputs.keySet());
> parser = populate(shellContext, line, inputs);
> }
> }
> return parser;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months
[JBoss JIRA] (FORGE-1396) Singular or Plural ?
by Catherine Robson (JIRA)
[ https://issues.jboss.org/browse/FORGE-1396?page=com.atlassian.jira.plugin... ]
Catherine Robson commented on FORGE-1396:
-----------------------------------------
I would try to go singular with all of the commands here if possible. "list-commands" makes sense plural only in that order - but I think when you change it to "command-list" for 2.0 it works as singular.
> Singular or Plural ?
> --------------------
>
> Key: FORGE-1396
> URL: https://issues.jboss.org/browse/FORGE-1396
> Project: Forge
> Issue Type: Sub-task
> Components: UI - Shell
> Affects Versions: 2.0.0.Beta4
> Reporter: Antonio Goncalves
>
> For listing all the services we use the {{services-list}} command. Here, {{services}} is in plural. But if we have several commands related to services, we might end-up with a mixture of singular and plural :
> {code}
> services-list
> service-register-as-serviceloader
> {code}
> Same thing could happen if we list all add-ons (here I'm supposing that the command {{addons-list}} exits) :
> {code}
> addons-list
> addon-build-and-install
> addon-install
> addon-new-command
> addon-remove
> {code}
> Is the mixture or plural and singular ok ? Shouldn't it all be in singular :
> {code}
> addon-list
> service-list
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 9 months