[JBoss JIRA] (FURNACE-89) Furnace Manager Resolver Maven is depending on unused Guava
by George Gastaldi (JIRA)
George Gastaldi created FURNACE-89:
--------------------------------------
Summary: Furnace Manager Resolver Maven is depending on unused Guava
Key: FURNACE-89
URL: https://issues.jboss.org/browse/FURNACE-89
Project: Forge: Furnace
Issue Type: Enhancement
Components: Maven
Affects Versions: 2.22.5.Final
Reporter: George Gastaldi
Assignee: George Gastaldi
The guava library is declared as a dependency, however it is not used in the code. This may be remains of an old Maven version dependency.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 1 month
[JBoss JIRA] (FORGE-2518) ProfileBuilder does not allow to set a build to set a default build etc
by Claus Ibsen (JIRA)
[ https://issues.jboss.org/browse/FORGE-2518?page=com.atlassian.jira.plugin... ]
Claus Ibsen commented on FORGE-2518:
------------------------------------
Thanks yeah I got it working with something similar as above.
> ProfileBuilder does not allow to set a build to set a default build etc
> -----------------------------------------------------------------------
>
> Key: FORGE-2518
> URL: https://issues.jboss.org/browse/FORGE-2518
> Project: Forge
> Issue Type: Enhancement
> Components: Build Tools - Maven
> Affects Versions: 2.20.0.Final
> Reporter: Claus Ibsen
> Labels: api-change
> Fix For: 3.x Future
>
>
> I need to add a maven profile to the maven pom using jboss forge
> {code}
> Profile profile = MavenHelpers.findProfile(pom, "f8-build");
> if (profile == null) {
> //profile = ProfileBuilder.create().setId("f8-build").
> profile = new Profile();
> profile.setId("f8-build");
> Build build = new Build();
> build.setDefaultGoal("clean install docker:build fabric8:json");
> profile.setBuild(build);
> maven.getModel().addProfile(profile);
> }
> {code}
> I tried using the org.jboss.forge.addon.maven.profiles.ProfileBuilder but it does not allow to configure the build where I need to set the default goal.
> The profile should look like
> {code}
> <profile>
> <id>f8-build</id>
> <build>
> <defaultGoal>clean install docker:build fabric8:json</defaultGoal>
> </build>
> </profile>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 1 month
[JBoss JIRA] (FORGE-2518) ProfileBuilder does not allow to set a build to set a default build etc
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2518?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-2518:
----------------------------------------
That would require some changes in the Profile API, therefore I am targetting this issue to 3.x. We are still considering if we should maintain this API or deprecate it, since it may be hard to keep up with the Maven Model changes, and possibly encourage the Maven model API usage.
Meanwhile, you can use the Maven API, as you done in your example, however you need to set the model back to persist the changes, like:
{code:java}
MavenFacet facet = project.getFacet(MavenFacet.class);
Model model = facet.getModel();
org.apache.maven.model.Profile p = ProfileBuilder.create().setId("f8-build").getAsMavenProfile();
Build build = new Build();
build.setDefaultGoal("clean install docker:build fabric8:json");
p.setBuild(build);
// Persist the model changes
facet.setModel(model);
{code}
> ProfileBuilder does not allow to set a build to set a default build etc
> -----------------------------------------------------------------------
>
> Key: FORGE-2518
> URL: https://issues.jboss.org/browse/FORGE-2518
> Project: Forge
> Issue Type: Enhancement
> Components: Build Tools - Maven
> Affects Versions: 2.20.0.Final
> Reporter: Claus Ibsen
> Labels: api-change
> Fix For: 3.x Future
>
>
> I need to add a maven profile to the maven pom using jboss forge
> {code}
> Profile profile = MavenHelpers.findProfile(pom, "f8-build");
> if (profile == null) {
> //profile = ProfileBuilder.create().setId("f8-build").
> profile = new Profile();
> profile.setId("f8-build");
> Build build = new Build();
> build.setDefaultGoal("clean install docker:build fabric8:json");
> profile.setBuild(build);
> maven.getModel().addProfile(profile);
> }
> {code}
> I tried using the org.jboss.forge.addon.maven.profiles.ProfileBuilder but it does not allow to configure the build where I need to set the default goal.
> The profile should look like
> {code}
> <profile>
> <id>f8-build</id>
> <build>
> <defaultGoal>clean install docker:build fabric8:json</defaultGoal>
> </build>
> </profile>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 1 month
[JBoss JIRA] (FORGE-2518) ProfileBuilder does not allow to set a build to set a default build etc
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2518?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2518:
-----------------------------------
Labels: api-change (was: )
> ProfileBuilder does not allow to set a build to set a default build etc
> -----------------------------------------------------------------------
>
> Key: FORGE-2518
> URL: https://issues.jboss.org/browse/FORGE-2518
> Project: Forge
> Issue Type: Enhancement
> Components: Build Tools - Maven
> Affects Versions: 2.20.0.Final
> Reporter: Claus Ibsen
> Labels: api-change
> Fix For: 3.x Future
>
>
> I need to add a maven profile to the maven pom using jboss forge
> {code}
> Profile profile = MavenHelpers.findProfile(pom, "f8-build");
> if (profile == null) {
> //profile = ProfileBuilder.create().setId("f8-build").
> profile = new Profile();
> profile.setId("f8-build");
> Build build = new Build();
> build.setDefaultGoal("clean install docker:build fabric8:json");
> profile.setBuild(build);
> maven.getModel().addProfile(profile);
> }
> {code}
> I tried using the org.jboss.forge.addon.maven.profiles.ProfileBuilder but it does not allow to configure the build where I need to set the default goal.
> The profile should look like
> {code}
> <profile>
> <id>f8-build</id>
> <build>
> <defaultGoal>clean install docker:build fabric8:json</defaultGoal>
> </build>
> </profile>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 1 month
[JBoss JIRA] (FORGE-2518) ProfileBuilder does not allow to set a build to set a default build etc
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2518?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2518:
-----------------------------------
Fix Version/s: 3.x Future
> ProfileBuilder does not allow to set a build to set a default build etc
> -----------------------------------------------------------------------
>
> Key: FORGE-2518
> URL: https://issues.jboss.org/browse/FORGE-2518
> Project: Forge
> Issue Type: Enhancement
> Components: Build Tools - Maven
> Affects Versions: 2.20.0.Final
> Reporter: Claus Ibsen
> Labels: api-change
> Fix For: 3.x Future
>
>
> I need to add a maven profile to the maven pom using jboss forge
> {code}
> Profile profile = MavenHelpers.findProfile(pom, "f8-build");
> if (profile == null) {
> //profile = ProfileBuilder.create().setId("f8-build").
> profile = new Profile();
> profile.setId("f8-build");
> Build build = new Build();
> build.setDefaultGoal("clean install docker:build fabric8:json");
> profile.setBuild(build);
> maven.getModel().addProfile(profile);
> }
> {code}
> I tried using the org.jboss.forge.addon.maven.profiles.ProfileBuilder but it does not allow to configure the build where I need to set the default goal.
> The profile should look like
> {code}
> <profile>
> <id>f8-build</id>
> <build>
> <defaultGoal>clean install docker:build fabric8:json</defaultGoal>
> </build>
> </profile>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 1 month
[JBoss JIRA] (FORGE-2519) build --profile should support tab completions
by Claus Ibsen (JIRA)
Claus Ibsen created FORGE-2519:
----------------------------------
Summary: build --profile should support tab completions
Key: FORGE-2519
URL: https://issues.jboss.org/browse/FORGE-2519
Project: Forge
Issue Type: Enhancement
Affects Versions: 2.20.0.Final
Reporter: Claus Ibsen
If you want to build the project from within forge using the build addon, then the --profile option does not support tab completions. It would be nice if it can detect which profile id's there is i nthe maven project and offer tab completions.
For example I have these 3 profiles
{code}
<profiles>
<profile>
<id>f8-build</id>
<build>
<defaultGoal>clean install docker:build fabric8:json</defaultGoal>
</build>
</profile>
<profile>
<id>f8-deploy</id>
<build>
<defaultGoal>clean install docker:build docker:push fabric8:json fabric8:apply</defaultGoal>
</build>
<properties>
<fabric8.recreate>true</fabric8.recreate>
<fabric8.imagePullPolicySnapshot>Always</fabric8.imagePullPolicySnapshot>
</properties>
</profile>
<profile>
<id>f8-local-deploy</id>
<build>
<defaultGoal>clean install docker:build fabric8:json fabric8:apply</defaultGoal>
</build>
<properties>
<fabric8.recreate>true</fabric8.recreate>
</properties>
</profile>
</profiles>
</project>
[foo]$ build --profile
{code}
And I want to execute that.
Also it would be nice if the build addon can support the same syntax as mvn does, eg if you can do
{code}
build -Pf8-local-deploy
{code}
eg using the -P as shorthand for profile.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 1 month
[JBoss JIRA] (FORGE-2518) ProfileBuilder does not allow to set a build to set a default build etc
by Claus Ibsen (JIRA)
Claus Ibsen created FORGE-2518:
----------------------------------
Summary: ProfileBuilder does not allow to set a build to set a default build etc
Key: FORGE-2518
URL: https://issues.jboss.org/browse/FORGE-2518
Project: Forge
Issue Type: Enhancement
Components: Build Tools - Maven
Affects Versions: 2.20.0.Final
Reporter: Claus Ibsen
I need to add a maven profile to the maven pom using jboss forge
{code}
Profile profile = MavenHelpers.findProfile(pom, "f8-build");
if (profile == null) {
//profile = ProfileBuilder.create().setId("f8-build").
profile = new Profile();
profile.setId("f8-build");
Build build = new Build();
build.setDefaultGoal("clean install docker:build fabric8:json");
profile.setBuild(build);
maven.getModel().addProfile(profile);
}
{code}
I tried using the org.jboss.forge.addon.maven.profiles.ProfileBuilder but it does not allow to configure the build where I need to set the default goal.
The profile should look like
{code}
<profile>
<id>f8-build</id>
<build>
<defaultGoal>clean install docker:build fabric8:json</defaultGoal>
</build>
</profile>
{code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 1 month