[JBoss JIRA] (ROASTER-61) Support native methods
by George Gastaldi (JIRA)
George Gastaldi created ROASTER-61:
--------------------------------------
Summary: Support native methods
Key: ROASTER-61
URL: https://issues.jboss.org/browse/ROASTER-61
Project: Roaster
Issue Type: Feature Request
Components: API, JDT
Affects Versions: 2.11.1.Final
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 2.11.2.Final
It would be nice to have {{Method.setNative(boolean)}} and {{Method.isNative()}}.
Care must be taken to remove the body of these methods once they are set to true. Same applies to abstract methods
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 7 months
[JBoss JIRA] (FORGE-2230) CoordinateBuilder should set null for empty parts of G:A:P:C:V
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2230?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-2230:
----------------------------------------
I've identified some code where we just check for nulls. If we take the never-null approach, we need to change this too (apparently they are broken for empty strings): {{org.jboss.forge.addon.dependencies.builder.CoordinateBuilder.toId()}}
{{org.jboss.forge.addon.dependencies.util.Dependencies.areEquivalent(Coordinate, Coordinate)}}
{{org.jboss.forge.addon.maven.util.MavenConvertUtils.coordinateToMavenArtifact(Coordinate)}}
> CoordinateBuilder should set null for empty parts of G:A:P:C:V
> --------------------------------------------------------------
>
> Key: FORGE-2230
> URL: https://issues.jboss.org/browse/FORGE-2230
> Project: Forge
> Issue Type: Enhancement
> Components: Dependencies
> Affects Versions: 2.14.0.Final
> Reporter: Ondrej Zizka
> Labels: starter
> Fix For: 2.x Future
>
>
> CoordinateBuilder, when given "G:A:::V", should set P and C to null. Having them empty strings is no good.
> Consider machine-provided lists contaning:
> org.foo:foo-bar:::4.1.2
> This should end with the same result as parsing
> org.foo:foo-bar:4.1.2
> whereas it ends up with P and C set to empty strings, and forces the user of the api to do extra check for an empty string value.
> Related:
> "Malformed coordinate. Should be groupId:artifactId:[packaging]:[classifier]:[version]");
> should read
> "Malformed coordinate. Should be groupId:artifactId:[packaging:[classifier:]][version]");
> And javadoc's
> <groupId>:<artifactId>[:<packaging>[:<classifier>]]:<version>
> should read
> <groupId>:<artifactId>[:<packaging>[:<classifier>]]:[<version>]
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 7 months