[JBoss JIRA] (FORGE-2290) Using an UICompleter does not work in interactive mode in the CLI
by Claus Ibsen (JIRA)
Claus Ibsen created FORGE-2290:
----------------------------------
Summary: Using an UICompleter does not work in interactive mode in the CLI
Key: FORGE-2290
URL: https://issues.jboss.org/browse/FORGE-2290
Project: Forge
Issue Type: Enhancement
Components: UI - Shell
Affects Versions: 2.15.2.Final
Reporter: Claus Ibsen
I have a UIInput where the end user should enter a class name for a Camel route builder class.
So I have a completer that implements the logic to find all route builders in the java source
{code}
routeBuilder.setCompleter(new RouteBuilderCompleter(facet));
{code}
And that only works from cli in non interactive mode, eg
{code}
[foo]$ camel-new-endpoint-routebuilder --componentName smtp --instanceName mail --routeBuilder com.foo.
com.foo.MyRoute com.foo.YourRoute
{code}
When pressing TAB it shows the 2 route builder classes I have.
But in interactive mode the TAB does not work
{code}
Press <ENTER> to confirm, or <CTRL>+C to cancel.
? componentName (Name of component type to add): [0-180] 146
? routeBuilder (The RouteBuilder class to use): co
{code}
I do not get any suggestions when pressing TAB.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 10 months
[JBoss JIRA] (FURNACE-21) Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FURNACE-21?page=com.atlassian.jira.plugin... ]
Ondrej Zizka edited comment on FURNACE-21 at 3/19/15 5:08 PM:
--------------------------------------------------------------
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
git co FURNACE-21-demo # tag
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().
This testcase also demonstrates how InvocationException is not being caught by catch(Exception ex), not sure why; and therefore (?) Furnace doesn't include it's cause.
was (Author: ozizka):
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
git clone FURNACE-21-demo # tag
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().
This testcase also demonstrates how InvocationException is not being caught by catch(Exception ex), not sure why; and therefore (?) Furnace doesn't include it's cause.
> Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: FURNACE-21
> URL: https://issues.jboss.org/browse/FURNACE-21
> Project: Forge: Furnace
> Issue Type: Enhancement
> Components: Runtime, Test Harness
> Reporter: Ondrej Zizka
> Assignee: George Gastaldi
>
> If the _DEFAULT_ addon (created by ForgeArchive getDeployment()) contains classes which duplicate those in dependencies (which is very easy to achieve), then various negative side effect may occur - e.g. querying for an @Annotation, or querying a Map with classes as keys, etc etc.
> Typically solving these errors is hard work.
> Forge, resp. Furnace, should WARN about duplicated classes. Maybe optionally if that would mean scanning all addons (but I assume that is being done anyway).
> In other words:
> 1) Scan whole _DEFAULT_ addon and for each class, try loading that class by FQCN from each dependency. If found, then WARN about it.
> 2) Scan all dependency addons and warn if duplicated FQCN is found.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 10 months
[JBoss JIRA] (FURNACE-21) Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FURNACE-21?page=com.atlassian.jira.plugin... ]
Ondrej Zizka edited comment on FURNACE-21 at 3/19/15 5:08 PM:
--------------------------------------------------------------
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
git checkout FURNACE-21-demo # tag
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().
This testcase also demonstrates how InvocationException is not being caught by catch(Exception ex), not sure why; and therefore (?) Furnace doesn't include it's cause.
was (Author: ozizka):
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
git co FURNACE-21-demo # tag
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().
This testcase also demonstrates how InvocationException is not being caught by catch(Exception ex), not sure why; and therefore (?) Furnace doesn't include it's cause.
> Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: FURNACE-21
> URL: https://issues.jboss.org/browse/FURNACE-21
> Project: Forge: Furnace
> Issue Type: Enhancement
> Components: Runtime, Test Harness
> Reporter: Ondrej Zizka
> Assignee: George Gastaldi
>
> If the _DEFAULT_ addon (created by ForgeArchive getDeployment()) contains classes which duplicate those in dependencies (which is very easy to achieve), then various negative side effect may occur - e.g. querying for an @Annotation, or querying a Map with classes as keys, etc etc.
> Typically solving these errors is hard work.
> Forge, resp. Furnace, should WARN about duplicated classes. Maybe optionally if that would mean scanning all addons (but I assume that is being done anyway).
> In other words:
> 1) Scan whole _DEFAULT_ addon and for each class, try loading that class by FQCN from each dependency. If found, then WARN about it.
> 2) Scan all dependency addons and warn if duplicated FQCN is found.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 10 months
[JBoss JIRA] (FURNACE-21) Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FURNACE-21?page=com.atlassian.jira.plugin... ]
Ondrej Zizka edited comment on FURNACE-21 at 3/19/15 5:08 PM:
--------------------------------------------------------------
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
git clone FURNACE-21-demo # tag
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().
This testcase also demonstrates how InvocationException is not being caught by catch(Exception ex), not sure why; and therefore (?) Furnace doesn't include it's cause.
was (Author: ozizka):
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().
This testcase also demonstrates how InvocationException is not being caught by catch(Exception ex), not sure why; and therefore (?) Furnace doesn't include it's cause.
> Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: FURNACE-21
> URL: https://issues.jboss.org/browse/FURNACE-21
> Project: Forge: Furnace
> Issue Type: Enhancement
> Components: Runtime, Test Harness
> Reporter: Ondrej Zizka
> Assignee: George Gastaldi
>
> If the _DEFAULT_ addon (created by ForgeArchive getDeployment()) contains classes which duplicate those in dependencies (which is very easy to achieve), then various negative side effect may occur - e.g. querying for an @Annotation, or querying a Map with classes as keys, etc etc.
> Typically solving these errors is hard work.
> Forge, resp. Furnace, should WARN about duplicated classes. Maybe optionally if that would mean scanning all addons (but I assume that is being done anyway).
> In other words:
> 1) Scan whole _DEFAULT_ addon and for each class, try loading that class by FQCN from each dependency. If found, then WARN about it.
> 2) Scan all dependency addons and warn if duplicated FQCN is found.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 10 months
[JBoss JIRA] (FURNACE-21) Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FURNACE-21?page=com.atlassian.jira.plugin... ]
Ondrej Zizka edited comment on FURNACE-21 at 3/19/15 4:26 PM:
--------------------------------------------------------------
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().
This testcase also demonstrates how InvocationException is not being caught by catch(Exception ex), not sure why; and therefore (?) Furnace doesn't include it's cause.
was (Author: ozizka):
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().
> Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: FURNACE-21
> URL: https://issues.jboss.org/browse/FURNACE-21
> Project: Forge: Furnace
> Issue Type: Enhancement
> Components: Runtime, Test Harness
> Reporter: Ondrej Zizka
> Assignee: George Gastaldi
>
> If the _DEFAULT_ addon (created by ForgeArchive getDeployment()) contains classes which duplicate those in dependencies (which is very easy to achieve), then various negative side effect may occur - e.g. querying for an @Annotation, or querying a Map with classes as keys, etc etc.
> Typically solving these errors is hard work.
> Forge, resp. Furnace, should WARN about duplicated classes. Maybe optionally if that would mean scanning all addons (but I assume that is being done anyway).
> In other words:
> 1) Scan whole _DEFAULT_ addon and for each class, try loading that class by FQCN from each dependency. If found, then WARN about it.
> 2) Scan all dependency addons and warn if duplicated FQCN is found.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 10 months
[JBoss JIRA] (FURNACE-21) Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FURNACE-21?page=com.atlassian.jira.plugin... ]
Ondrej Zizka commented on FURNACE-21:
-------------------------------------
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
> Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: FURNACE-21
> URL: https://issues.jboss.org/browse/FURNACE-21
> Project: Forge: Furnace
> Issue Type: Enhancement
> Components: Runtime, Test Harness
> Reporter: Ondrej Zizka
> Assignee: George Gastaldi
>
> If the _DEFAULT_ addon (created by ForgeArchive getDeployment()) contains classes which duplicate those in dependencies (which is very easy to achieve), then various negative side effect may occur - e.g. querying for an @Annotation, or querying a Map with classes as keys, etc etc.
> Typically solving these errors is hard work.
> Forge, resp. Furnace, should WARN about duplicated classes. Maybe optionally if that would mean scanning all addons (but I assume that is being done anyway).
> In other words:
> 1) Scan whole _DEFAULT_ addon and for each class, try loading that class by FQCN from each dependency. If found, then WARN about it.
> 2) Scan all dependency addons and warn if duplicated FQCN is found.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 10 months
[JBoss JIRA] (FURNACE-21) Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FURNACE-21?page=com.atlassian.jira.plugin... ]
Ondrej Zizka edited comment on FURNACE-21 at 3/19/15 4:24 PM:
--------------------------------------------------------------
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().
was (Author: ozizka):
Test case:
{code}
git clone git@github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
> Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: FURNACE-21
> URL: https://issues.jboss.org/browse/FURNACE-21
> Project: Forge: Furnace
> Issue Type: Enhancement
> Components: Runtime, Test Harness
> Reporter: Ondrej Zizka
> Assignee: George Gastaldi
>
> If the _DEFAULT_ addon (created by ForgeArchive getDeployment()) contains classes which duplicate those in dependencies (which is very easy to achieve), then various negative side effect may occur - e.g. querying for an @Annotation, or querying a Map with classes as keys, etc etc.
> Typically solving these errors is hard work.
> Forge, resp. Furnace, should WARN about duplicated classes. Maybe optionally if that would mean scanning all addons (but I assume that is being done anyway).
> In other words:
> 1) Scan whole _DEFAULT_ addon and for each class, try loading that class by FQCN from each dependency. If found, then WARN about it.
> 2) Scan all dependency addons and warn if duplicated FQCN is found.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 10 months
[JBoss JIRA] (FURNACE-21) Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FURNACE-21?page=com.atlassian.jira.plugin... ]
Ondrej Zizka commented on FURNACE-21:
-------------------------------------
Yes, maybe an exception. Typically it is an outcome of wrong deployment setup. But if you WARN about it and then let it fail "naturally", it would demonstrate to the user why that matters :) Or - if the exception contains good explanation of what it could lead to, then an exception is better.
> Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: FURNACE-21
> URL: https://issues.jboss.org/browse/FURNACE-21
> Project: Forge: Furnace
> Issue Type: Enhancement
> Components: Runtime, Test Harness
> Reporter: Ondrej Zizka
> Assignee: George Gastaldi
>
> If the _DEFAULT_ addon (created by ForgeArchive getDeployment()) contains classes which duplicate those in dependencies (which is very easy to achieve), then various negative side effect may occur - e.g. querying for an @Annotation, or querying a Map with classes as keys, etc etc.
> Typically solving these errors is hard work.
> Forge, resp. Furnace, should WARN about duplicated classes. Maybe optionally if that would mean scanning all addons (but I assume that is being done anyway).
> In other words:
> 1) Scan whole _DEFAULT_ addon and for each class, try loading that class by FQCN from each dependency. If found, then WARN about it.
> 2) Scan all dependency addons and warn if duplicated FQCN is found.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 10 months
[JBoss JIRA] (FORGE-1751) Support Wildcards for package and class names
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1751?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-1751:
-----------------------------------
Status: Closed (was: Pull Request Sent)
Resolution: Done
> Support Wildcards for package and class names
> ---------------------------------------------
>
> Key: FORGE-1751
> URL: https://issues.jboss.org/browse/FORGE-1751
> Project: Forge
> Issue Type: Feature Request
> Components: UI - Shell
> Affects Versions: 2.4.1.Final
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Priority: Critical
> Fix For: 2.15.2.Final
>
>
> In Forge 1.x it was possible to do something like:
> {code}
> scaffold-x from ~.model.Customer
> scaffold-x from ~.model.*
> {code}
> That would replace the ~ character with the top level package name.
> This is needed for scripting purposes and also very used.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 10 months