[JBoss JIRA] (FORGE-2419) Refactoring the JSF Commands
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2419?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-2419.
----------------------------------
Fix Version/s: 2.17.1.Final
(was: 2.x Future)
Resolution: Done
> Refactoring the JSF Commands
> ----------------------------
>
> Key: FORGE-2419
> URL: https://issues.jboss.org/browse/FORGE-2419
> Project: Forge
> Issue Type: Sub-task
> Components: Java EE
> Affects Versions: 2.17.0.Final
> Reporter: Antonio Goncalves
> Assignee: Antonio Goncalves
> Fix For: 2.17.1.Final
>
>
> Today the JSF methods {{FacesNewBeanCommand}}, {{FacesNewConverterCommand}} and {{FacesNewValidatorCommand}} use templating.
> For the little amount of code that is generated, it would be better to use Roaster instead. And in the refactoring process, add some tests.
> Today the JSF commands have the following hierarchy :
> {code}
> AbstractUICommand implements UICommand
> AbstractProjectCommand
> AbstractJavaEECommand
> AbstractFacesCommand implements PrerequisiteCommandsProvider
> FacesNewBeanCommand implements PrerequisiteCommandsProvider
> FacesNewConverterCommand
> FacesNewValidatorCommand
> {code}
> But most of the other Java EE commands extend {{AbstractJavaSourceCommand}} and not {{AbstractJavaEECommand}}
> {code}
> AbstractUICommand implements UICommand
> AbstractProjectCommand
> AbstractJavaSourceCommand<SOURCETYPE extends JavaSource<?>>
> AbstractCDICommand<T extends JavaSource<?>> implements PrerequisiteCommandsProvider
> CDINewBeanCommand
> CDINewDecoratorCommand
> CDINewExtensionCommand
> AbstractJPACommand<T extends JavaSource<?>> implements PrerequisiteCommandsProvider
> JPANewEntityCommand
> JPANewEntityListenerCommand
> JPANewMappedSuperclassCommand
> AbstractServletNewCommand<T extends JavaSource<?>> implements PrerequisiteCommandsProvider
> ServletNewServletCommand
> ServletNewFilterCommand
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (FORGE-2432) 'addon-remove' error message is misleading when invalid coordinates are supplied
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2432?page=com.atlassian.jira.plugin... ]
George Gastaldi moved FURNACE-3 to FORGE-2432:
----------------------------------------------
Project: Forge (was: Forge: Furnace)
Key: FORGE-2432 (was: FURNACE-3)
Component/s: Addon Manager
(was: Addon Manager)
Fix Version/s: 2.x Future
(was: 2.x Future)
> 'addon-remove' error message is misleading when invalid coordinates are supplied
> --------------------------------------------------------------------------------
>
> Key: FORGE-2432
> URL: https://issues.jboss.org/browse/FORGE-2432
> Project: Forge
> Issue Type: Enhancement
> Components: Addon Manager
> Reporter: Lincoln Baxter III
> Fix For: 2.x Future
>
> Attachments: Screen Shot 2014-12-08 at 11.17.59 AM.png
>
>
> See screenshot.
> Error message should be more descriptive:
> {code}***ERROR*** The specified addon coordinates [fooo, blah, bar ...] were not found within any configured furnace repository [repository locations] and cannot be removed.{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (FURNACE-3) 'addon-remove' error message is misleading when invalid coordinates are supplied
by Antonio Goncalves (JIRA)
[ https://issues.jboss.org/browse/FURNACE-3?page=com.atlassian.jira.plugin.... ]
Issue was automatically transitioned when Antonio Goncalves created pull request #578 in GitHub
-----------------------------------------------------------------------------------------------
Status: Pull Request Sent (was: Open)
> 'addon-remove' error message is misleading when invalid coordinates are supplied
> --------------------------------------------------------------------------------
>
> Key: FURNACE-3
> URL: https://issues.jboss.org/browse/FURNACE-3
> Project: Forge: Furnace
> Issue Type: Enhancement
> Components: Addon Manager
> Reporter: Lincoln Baxter III
> Fix For: 2.x Future
>
> Attachments: Screen Shot 2014-12-08 at 11.17.59 AM.png
>
>
> See screenshot.
> Error message should be more descriptive:
> {code}***ERROR*** The specified addon coordinates [fooo, blah, bar ...] were not found within any configured furnace repository [repository locations] and cannot be removed.{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (FORGE-2419) Refactoring the JSF Commands
by Antonio Goncalves (JIRA)
[ https://issues.jboss.org/browse/FORGE-2419?page=com.atlassian.jira.plugin... ]
Antonio Goncalves updated FORGE-2419:
-------------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/forge/core/pull/577
> Refactoring the JSF Commands
> ----------------------------
>
> Key: FORGE-2419
> URL: https://issues.jboss.org/browse/FORGE-2419
> Project: Forge
> Issue Type: Sub-task
> Components: Java EE
> Affects Versions: 2.17.0.Final
> Reporter: Antonio Goncalves
> Assignee: Antonio Goncalves
> Fix For: 2.x Future
>
>
> Today the JSF methods {{FacesNewBeanCommand}}, {{FacesNewConverterCommand}} and {{FacesNewValidatorCommand}} use templating.
> For the little amount of code that is generated, it would be better to use Roaster instead. And in the refactoring process, add some tests.
> Today the JSF commands have the following hierarchy :
> {code}
> AbstractUICommand implements UICommand
> AbstractProjectCommand
> AbstractJavaEECommand
> AbstractFacesCommand implements PrerequisiteCommandsProvider
> FacesNewBeanCommand implements PrerequisiteCommandsProvider
> FacesNewConverterCommand
> FacesNewValidatorCommand
> {code}
> But most of the other Java EE commands extend {{AbstractJavaSourceCommand}} and not {{AbstractJavaEECommand}}
> {code}
> AbstractUICommand implements UICommand
> AbstractProjectCommand
> AbstractJavaSourceCommand<SOURCETYPE extends JavaSource<?>>
> AbstractCDICommand<T extends JavaSource<?>> implements PrerequisiteCommandsProvider
> CDINewBeanCommand
> CDINewDecoratorCommand
> CDINewExtensionCommand
> AbstractJPACommand<T extends JavaSource<?>> implements PrerequisiteCommandsProvider
> JPANewEntityCommand
> JPANewEntityListenerCommand
> JPANewMappedSuperclassCommand
> AbstractServletNewCommand<T extends JavaSource<?>> implements PrerequisiteCommandsProvider
> ServletNewServletCommand
> ServletNewFilterCommand
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months