September 2015 - forge-issues - Jboss List Archives

[JBoss JIRA] (FURNACE-77) Upgrade to Arquillian 1.1.9.Final

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FURNACE-77?page=com.atlassian.jira.plugin... ] George Gastaldi reopened FURNACE-77: ------------------------------------ > Upgrade to Arquillian 1.1.9.Final > --------------------------------- > > Key: FURNACE-77 > URL: https://issues.jboss.org/browse/FURNACE-77 > Project: Forge: Furnace > Issue Type: Feature Request > Components: Test Harness > Affects Versions: 2.21.0.Final > Reporter: George Gastaldi > Assignee: George Gastaldi > Fix For: 2.21.1.Final > > > More info in http://arquillian.org/blog/2015/09/02/arquillian-core-1-1-9-Final/ -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FURNACE-77) Upgrade to Arquillian 1.1.9.Final

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FURNACE-77?page=com.atlassian.jira.plugin... ] George Gastaldi closed FURNACE-77. ---------------------------------- Resolution: Done > Upgrade to Arquillian 1.1.9.Final > --------------------------------- > > Key: FURNACE-77 > URL: https://issues.jboss.org/browse/FURNACE-77 > Project: Forge: Furnace > Issue Type: Feature Request > Components: Test Harness > Affects Versions: 2.21.0.Final > Reporter: George Gastaldi > Assignee: George Gastaldi > Fix For: 2.21.1.Final > > > More info in http://arquillian.org/blog/2015/09/02/arquillian-core-1-1-9-Final/ -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FURNACE-77) Upgrade to Arquillian 1.1.9.Final

by George Gastaldi (JIRA)

George Gastaldi created FURNACE-77: -------------------------------------- Summary: Upgrade to Arquillian 1.1.9.Final Key: FURNACE-77 URL: https://issues.jboss.org/browse/FURNACE-77 Project: Forge: Furnace Issue Type: Feature Request Components: Test Harness Affects Versions: 2.21.0.Final Reporter: George Gastaldi Assignee: George Gastaldi Fix For: 2.21.1.Final More info in http://arquillian.org/blog/2015/09/02/arquillian-core-1-1-9-Final/ -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2475) Top level packages should be created in project-new

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-2475?page=com.atlassian.jira.plugin... ] George Gastaldi closed FORGE-2475. ---------------------------------- Resolution: Done > Top level packages should be created in project-new > --------------------------------------------------- > > Key: FORGE-2475 > URL: https://issues.jboss.org/browse/FORGE-2475 > Project: Forge > Issue Type: Feature Request > Components: Parsers / File Manipulation, Projects > Affects Versions: 2.19.0.Final > Reporter: George Gastaldi > Assignee: George Gastaldi > Fix For: 2.19.1.Final > > > {{project-new}} should create the target packages when {{JavaSourceFacet}} is installed -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2475) Top level packages should be created in project-new

by George Gastaldi (JIRA)

George Gastaldi created FORGE-2475: -------------------------------------- Summary: Top level packages should be created in project-new Key: FORGE-2475 URL: https://issues.jboss.org/browse/FORGE-2475 Project: Forge Issue Type: Feature Request Components: Parsers / File Manipulation, Projects Affects Versions: 2.19.0.Final Reporter: George Gastaldi Assignee: George Gastaldi Fix For: 2.19.1.Final {{project-new}} should create the target packages when {{JavaSourceFacet}} is installed -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2469) Getting a design pattern right for add commands

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-2469?page=com.atlassian.jira.plugin... ] George Gastaldi closed FORGE-2469. ---------------------------------- Assignee: George Gastaldi Created decorators for inputs: https://github.com/forge/core/tree/master/ui#specializing-inputs > Getting a design pattern right for add commands > ----------------------------------------------- > > Key: FORGE-2469 > URL: https://issues.jboss.org/browse/FORGE-2469 > Project: Forge > Issue Type: Sub-task > Components: Java EE > Affects Versions: 2.19.0.Final > Reporter: Antonio Goncalves > Assignee: George Gastaldi > Fix For: 2.x Future > > > The {{new}} commands are straight forward, we just create a new artifact (mostly classes in the Java EE addon). {{add}} commands are meant to add code to existing code. So all the add}} commands have a {{targetClass}} attribute. The {{targetClass}} points to the current class, or can point to a different one. > The algorithm to get the {{targetClass}} is very different from command to command (see below). It would be very helpfull to find a generic design pattern that could be applicable to most of the {{add}} commands. > {code:title=JavaEqualsHashcodeCommand} > @Override > public void initializeUI(UIBuilder builder) throws Exception > { > (...) > UISelection<Object> initialSelection = uiContext.getInitialSelection(); > if (initialSelection.get() instanceof JavaResource) > { > targetClass.setValue((JavaResource) initialSelection.get()); > } > targetClass.setValueChoices(projectOperations.getProjectClasses(project)); > @Override > public Result execute(UIExecutionContext context) throws Exception > { > (...) > if (targetClass.hasMethodSignature("equals", Object.class)) > { > if (prompt.promptBoolean("Class already has an equals method. Would you like it to be overwritten?")) > {code} > {code:title=CDIAddInjectionPointCommand} > private void setupTargetClasses(UIContext uiContext) > { > UISelection<FileResource<?>> selection = uiContext.getInitialSelection(); > Project project = getSelectedProject(uiContext); > final List<JavaResource> classes = cdiOperations.getProjectInjectionPointBeans(project); > targetClass.setValueChoices(classes); > int idx = -1; > if (!selection.isEmpty()) > { > idx = classes.indexOf(selection.get()); > } > if (idx == -1) > { > idx = classes.size() - 1; > } > if (idx != -1) > { > targetClass.setDefaultValue(classes.get(idx)); > } > } > {code} > {code:title=CDIAddObserverMethodCommand} > private void setupTargetClass(UIContext uiContext, Project project) > { > UISelection<Resource<?>> resource = uiContext.getInitialSelection(); > if (resource.get() instanceof JavaResource) > { > targetClass.setDefaultValue((JavaResource) resource.get()); > } > targetClass.setValueChoices(projectOperations.getProjectClasses(project)); > } > {code} > {code:title=FacesNewValidatorMethodCommand} > public void initializeUI(UIBuilder builder) throws Exception > { > Object selection = builder.getUIContext().getInitialSelection().get(); > if (selection instanceof JavaResource) > { > targetClass.setDefaultValue((JavaResource) selection); > } > builder.add(targetClass).add(named); > } > @Override > public void validate(UIValidationContext validator) > { > try > { > JavaClassSource source = targetClass.getValue().reify(JavaResource.class).getJavaType(); > (...) > } > catch (FileNotFoundException e) > { > validator.addValidationError(targetClass, "Target Java class not found."); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2469) Getting a design pattern right for add commands

by Anonymous (JIRA)

[ https://issues.jboss.org/browse/FORGE-2469?page=com.atlassian.jira.plugin... ] Issue was automatically transitioned when George Gastaldi merged pull request #585 in GitHub -------------------------------------------------------------------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Getting a design pattern right for add commands > ----------------------------------------------- > > Key: FORGE-2469 > URL: https://issues.jboss.org/browse/FORGE-2469 > Project: Forge > Issue Type: Sub-task > Components: Java EE > Affects Versions: 2.19.0.Final > Reporter: Antonio Goncalves > Fix For: 2.x Future > > > The {{new}} commands are straight forward, we just create a new artifact (mostly classes in the Java EE addon). {{add}} commands are meant to add code to existing code. So all the add}} commands have a {{targetClass}} attribute. The {{targetClass}} points to the current class, or can point to a different one. > The algorithm to get the {{targetClass}} is very different from command to command (see below). It would be very helpfull to find a generic design pattern that could be applicable to most of the {{add}} commands. > {code:title=JavaEqualsHashcodeCommand} > @Override > public void initializeUI(UIBuilder builder) throws Exception > { > (...) > UISelection<Object> initialSelection = uiContext.getInitialSelection(); > if (initialSelection.get() instanceof JavaResource) > { > targetClass.setValue((JavaResource) initialSelection.get()); > } > targetClass.setValueChoices(projectOperations.getProjectClasses(project)); > @Override > public Result execute(UIExecutionContext context) throws Exception > { > (...) > if (targetClass.hasMethodSignature("equals", Object.class)) > { > if (prompt.promptBoolean("Class already has an equals method. Would you like it to be overwritten?")) > {code} > {code:title=CDIAddInjectionPointCommand} > private void setupTargetClasses(UIContext uiContext) > { > UISelection<FileResource<?>> selection = uiContext.getInitialSelection(); > Project project = getSelectedProject(uiContext); > final List<JavaResource> classes = cdiOperations.getProjectInjectionPointBeans(project); > targetClass.setValueChoices(classes); > int idx = -1; > if (!selection.isEmpty()) > { > idx = classes.indexOf(selection.get()); > } > if (idx == -1) > { > idx = classes.size() - 1; > } > if (idx != -1) > { > targetClass.setDefaultValue(classes.get(idx)); > } > } > {code} > {code:title=CDIAddObserverMethodCommand} > private void setupTargetClass(UIContext uiContext, Project project) > { > UISelection<Resource<?>> resource = uiContext.getInitialSelection(); > if (resource.get() instanceof JavaResource) > { > targetClass.setDefaultValue((JavaResource) resource.get()); > } > targetClass.setValueChoices(projectOperations.getProjectClasses(project)); > } > {code} > {code:title=FacesNewValidatorMethodCommand} > public void initializeUI(UIBuilder builder) throws Exception > { > Object selection = builder.getUIContext().getInitialSelection().get(); > if (selection instanceof JavaResource) > { > targetClass.setDefaultValue((JavaResource) selection); > } > builder.add(targetClass).add(named); > } > @Override > public void validate(UIValidationContext validator) > { > try > { > JavaClassSource source = targetClass.getValue().reify(JavaResource.class).getJavaType(); > (...) > } > catch (FileNotFoundException e) > { > validator.addValidationError(targetClass, "Target Java class not found."); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2469) Getting a design pattern right for add commands

by Anonymous (JIRA)

[ https://issues.jboss.org/browse/FORGE-2469?page=com.atlassian.jira.plugin... ] Issue was automatically transitioned when George Gastaldi created pull request #585 in GitHub --------------------------------------------------------------------------------------------- Status: Pull Request Sent (was: Open) > Getting a design pattern right for add commands > ----------------------------------------------- > > Key: FORGE-2469 > URL: https://issues.jboss.org/browse/FORGE-2469 > Project: Forge > Issue Type: Sub-task > Components: Java EE > Affects Versions: 2.19.0.Final > Reporter: Antonio Goncalves > Fix For: 2.x Future > > > The {{new}} commands are straight forward, we just create a new artifact (mostly classes in the Java EE addon). {{add}} commands are meant to add code to existing code. So all the add}} commands have a {{targetClass}} attribute. The {{targetClass}} points to the current class, or can point to a different one. > The algorithm to get the {{targetClass}} is very different from command to command (see below). It would be very helpfull to find a generic design pattern that could be applicable to most of the {{add}} commands. > {code:title=JavaEqualsHashcodeCommand} > @Override > public void initializeUI(UIBuilder builder) throws Exception > { > (...) > UISelection<Object> initialSelection = uiContext.getInitialSelection(); > if (initialSelection.get() instanceof JavaResource) > { > targetClass.setValue((JavaResource) initialSelection.get()); > } > targetClass.setValueChoices(projectOperations.getProjectClasses(project)); > @Override > public Result execute(UIExecutionContext context) throws Exception > { > (...) > if (targetClass.hasMethodSignature("equals", Object.class)) > { > if (prompt.promptBoolean("Class already has an equals method. Would you like it to be overwritten?")) > {code} > {code:title=CDIAddInjectionPointCommand} > private void setupTargetClasses(UIContext uiContext) > { > UISelection<FileResource<?>> selection = uiContext.getInitialSelection(); > Project project = getSelectedProject(uiContext); > final List<JavaResource> classes = cdiOperations.getProjectInjectionPointBeans(project); > targetClass.setValueChoices(classes); > int idx = -1; > if (!selection.isEmpty()) > { > idx = classes.indexOf(selection.get()); > } > if (idx == -1) > { > idx = classes.size() - 1; > } > if (idx != -1) > { > targetClass.setDefaultValue(classes.get(idx)); > } > } > {code} > {code:title=CDIAddObserverMethodCommand} > private void setupTargetClass(UIContext uiContext, Project project) > { > UISelection<Resource<?>> resource = uiContext.getInitialSelection(); > if (resource.get() instanceof JavaResource) > { > targetClass.setDefaultValue((JavaResource) resource.get()); > } > targetClass.setValueChoices(projectOperations.getProjectClasses(project)); > } > {code} > {code:title=FacesNewValidatorMethodCommand} > public void initializeUI(UIBuilder builder) throws Exception > { > Object selection = builder.getUIContext().getInitialSelection().get(); > if (selection instanceof JavaResource) > { > targetClass.setDefaultValue((JavaResource) selection); > } > builder.add(targetClass).add(named); > } > @Override > public void validate(UIValidationContext validator) > { > try > { > JavaClassSource source = targetClass.getValue().reify(JavaResource.class).getJavaType(); > (...) > } > catch (FileNotFoundException e) > { > validator.addValidationError(targetClass, "Target Java class not found."); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2474) Being able to add a constraint not just on properties

by Antonio Goncalves (JIRA)

Antonio Goncalves created FORGE-2474: ---------------------------------------- Summary: Being able to add a constraint not just on properties Key: FORGE-2474 URL: https://issues.jboss.org/browse/FORGE-2474 Project: Forge Issue Type: Sub-task Components: Java EE Affects Versions: 2.19.0.Final Reporter: Antonio Goncalves Fix For: 2.x Future At the moment we can add a constraint on a property with the command : {code} constraint-add --constraint NotNull --onProperty {code} But we can also add a constraint on a bean itself, or even on a constraint annotation. So we would need several options such as {code} constraint-add --constraint NotNull --onProperty name constraint-add --constraint NotNull --onBean MyBean constraint-add --constraint NotNull --onConstraint MyCustomConstraint {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2473) Webhook Test

by Vlastimil Eliáš (JIRA)

[ https://issues.jboss.org/browse/FORGE-2473?page=com.atlassian.jira.plugin... ] Vlastimil Eliáš deleted FORGE-2473: ----------------------------------- > Webhook Test > ------------ > > Key: FORGE-2473 > URL: https://issues.jboss.org/browse/FORGE-2473 > Project: Forge > Issue Type: Quality Risk > Environment: *Location*: http://forge.jboss.org/ > *User-Agent*: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0 > *Screen Resolution*: 1680 x 1050 > Reporter: Vlastimil Eliáš > Labels: collector-719046f7 > > test -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 8 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

forge-issues September 2015