[JBoss JIRA] (FORGE-2490) Handling of unique constraint exceptions
by Aitor Fdez-Ceballos Jiménez (JIRA)
[ https://issues.jboss.org/browse/FORGE-2490?page=com.atlassian.jira.plugin... ]
Aitor Fdez-Ceballos Jiménez commented on FORGE-2490:
----------------------------------------------------
Hi [~gastaldi], thank you for the response. Bean Validation is enabled, because the rest of the restrictions (like @NotNull, @Size etc.) are handled right.
The only problem is with unique, and acording to the first response on http://stackoverflow.com/questions/3495368/unique-constraint-with-jpa-and... "@Unique cannot be tested at the Java level reliably but could generate a database unique constraint generation. Unique is not part of the [Bean Validation] spec".
> Handling of unique constraint exceptions
> ----------------------------------------
>
> Key: FORGE-2490
> URL: https://issues.jboss.org/browse/FORGE-2490
> Project: Forge
> Issue Type: Feature Request
> Components: Scaffold
> Affects Versions: 2.19.2.Final
> Environment: Faces 2.2, Hibernate, Oracle 11g, WildFly 8.2
> Reporter: Aitor Fdez-Ceballos Jiménez
> Fix For: 2.x Future
>
>
> If you scaffold an Entity in which you have an unique constraint (i.e: java-add-annotation --onProperty testField --annotation Column(unique=true)) the generated code isn't able to handle the exception when you violate the unique, unlike other restrictions, and redirects the user to the general error page, losing the inserted data.
> Reading about this my conclusion is that JPA doesn't manage this and delegates to the database. Anyway, It would be great if the generated Forge beans could handle the restriction just like with the others and show a validation error instead of redirecting to the error page.
> I have tried with two different approaches to manage this:
> 1) Flush after the persist/merge in the bean so we can catch the SQLIntegrityConstraintViolationException in the update method and then add a proper message.
> 2) Launch a previous select query to the database to see if the value is already in the database (not very efficient / smart)
> Following the option 1 we faced another problem and we have finally extended ours beans from a "general bean" in which we have an interceptor method with @AroundInvoke annotation to handle errors from the database. This appear to be necessary sometimes when we get an EJBTransactionRolledbackException (i.e when you are editing [not creating] an object, because the exception is launched in CMTTxInterceptor so we cannot catch it in the update method)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (FORGE-2490) Handling of unique constraint exceptions
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2490?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2490:
-----------------------------------
Comment: was deleted
(was: Hi [~aitorfcj],
Have you tried enabling Bean Validation in your JPA descriptor? JPA shouldn't delegate validation to your DB.
http://docs.jboss.org/hibernate/stable/validator/reference/en-US/html_sin...)
> Handling of unique constraint exceptions
> ----------------------------------------
>
> Key: FORGE-2490
> URL: https://issues.jboss.org/browse/FORGE-2490
> Project: Forge
> Issue Type: Feature Request
> Components: Scaffold
> Affects Versions: 2.19.2.Final
> Environment: Faces 2.2, Hibernate, Oracle 11g, WildFly 8.2
> Reporter: Aitor Fdez-Ceballos Jiménez
> Fix For: 2.x Future
>
>
> If you scaffold an Entity in which you have an unique constraint (i.e: java-add-annotation --onProperty testField --annotation Column(unique=true)) the generated code isn't able to handle the exception when you violate the unique, unlike other restrictions, and redirects the user to the general error page, losing the inserted data.
> Reading about this my conclusion is that JPA doesn't manage this and delegates to the database. Anyway, It would be great if the generated Forge beans could handle the restriction just like with the others and show a validation error instead of redirecting to the error page.
> I have tried with two different approaches to manage this:
> 1) Flush after the persist/merge in the bean so we can catch the SQLIntegrityConstraintViolationException in the update method and then add a proper message.
> 2) Launch a previous select query to the database to see if the value is already in the database (not very efficient / smart)
> Following the option 1 we faced another problem and we have finally extended ours beans from a "general bean" in which we have an interceptor method with @AroundInvoke annotation to handle errors from the database. This appear to be necessary sometimes when we get an EJBTransactionRolledbackException (i.e when you are editing [not creating] an object, because the exception is launched in CMTTxInterceptor so we cannot catch it in the update method)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (FORGE-2490) Handling of unique constraint exceptions
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2490?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-2490:
----------------------------------------
Hi [~aitorfcj],
Have you tried enabling Bean Validation in your JPA descriptor? JPA shouldn't delegate validation to your DB.
http://docs.jboss.org/hibernate/stable/validator/reference/en-US/html_sin...
> Handling of unique constraint exceptions
> ----------------------------------------
>
> Key: FORGE-2490
> URL: https://issues.jboss.org/browse/FORGE-2490
> Project: Forge
> Issue Type: Feature Request
> Components: Scaffold
> Affects Versions: 2.19.2.Final
> Environment: Faces 2.2, Hibernate, Oracle 11g, WildFly 8.2
> Reporter: Aitor Fdez-Ceballos Jiménez
> Fix For: 2.x Future
>
>
> If you scaffold an Entity in which you have an unique constraint (i.e: java-add-annotation --onProperty testField --annotation Column(unique=true)) the generated code isn't able to handle the exception when you violate the unique, unlike other restrictions, and redirects the user to the general error page, losing the inserted data.
> Reading about this my conclusion is that JPA doesn't manage this and delegates to the database. Anyway, It would be great if the generated Forge beans could handle the restriction just like with the others and show a validation error instead of redirecting to the error page.
> I have tried with two different approaches to manage this:
> 1) Flush after the persist/merge in the bean so we can catch the SQLIntegrityConstraintViolationException in the update method and then add a proper message.
> 2) Launch a previous select query to the database to see if the value is already in the database (not very efficient / smart)
> Following the option 1 we faced another problem and we have finally extended ours beans from a "general bean" in which we have an interceptor method with @AroundInvoke annotation to handle errors from the database. This appear to be necessary sometimes when we get an EJBTransactionRolledbackException (i.e when you are editing [not creating] an object, because the exception is launched in CMTTxInterceptor so we cannot catch it in the update method)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (FORGE-2490) Handling of unique constraint exceptions
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2490?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2490:
-----------------------------------
Fix Version/s: 2.x Future
> Handling of unique constraint exceptions
> ----------------------------------------
>
> Key: FORGE-2490
> URL: https://issues.jboss.org/browse/FORGE-2490
> Project: Forge
> Issue Type: Feature Request
> Components: Scaffold
> Affects Versions: 2.19.2.Final
> Environment: Faces 2.2, Hibernate, Oracle 11g, WildFly 8.2
> Reporter: Aitor Fdez-Ceballos Jiménez
> Fix For: 2.x Future
>
>
> If you scaffold an Entity in which you have an unique constraint (i.e: java-add-annotation --onProperty testField --annotation Column(unique=true)) the generated code isn't able to handle the exception when you violate the unique, unlike other restrictions, and redirects the user to the general error page, losing the inserted data.
> Reading about this my conclusion is that JPA doesn't manage this and delegates to the database. Anyway, It would be great if the generated Forge beans could handle the restriction just like with the others and show a validation error instead of redirecting to the error page.
> I have tried with two different approaches to manage this:
> 1) Flush after the persist/merge in the bean so we can catch the SQLIntegrityConstraintViolationException in the update method and then add a proper message.
> 2) Launch a previous select query to the database to see if the value is already in the database (not very efficient / smart)
> Following the option 1 we faced another problem and we have finally extended ours beans from a "general bean" in which we have an interceptor method with @AroundInvoke annotation to handle errors from the database. This appear to be necessary sometimes when we get an EJBTransactionRolledbackException (i.e when you are editing [not creating] an object, because the exception is launched in CMTTxInterceptor so we cannot catch it in the update method)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (FORGE-2490) Handling of unique constraint exceptions
by Aitor Fdez-Ceballos Jiménez (JIRA)
Aitor Fdez-Ceballos Jiménez created FORGE-2490:
--------------------------------------------------
Summary: Handling of unique constraint exceptions
Key: FORGE-2490
URL: https://issues.jboss.org/browse/FORGE-2490
Project: Forge
Issue Type: Feature Request
Components: Scaffold
Affects Versions: 2.19.2.Final
Environment: Faces 2.2, Hibernate, Oracle 11g, WildFly 8.2
Reporter: Aitor Fdez-Ceballos Jiménez
If you scaffold an Entity in which you have an unique constraint (i.e: java-add-annotation --onProperty testField --annotation Column(unique=true)) the generated code isn't able to handle the exception when you violate the unique, unlike other restrictions, and redirects the user to the general error page, losing the inserted data.
Reading about this my conclusion is that JPA doesn't manage this and delegates to the database. Anyway, It would be great if the generated Forge beans could handle the restriction just like with the others and show a validation error instead of redirecting to the error page.
I have tried with two different approaches to manage this:
1) Flush after the persist/merge in the bean so we can catch the SQLIntegrityConstraintViolationException in the update method and then add a proper message.
2) Launch a previous select query to the database to see if the value is already in the database (not very efficient / smart)
Following the option 1 we faced another problem and we have finally extended ours beans from a "general bean" in which we have an interceptor method with @AroundInvoke annotation to handle errors from the database. This appear to be necessary sometimes when we get an EJBTransactionRolledbackException (i.e when you are editing [not creating] an object, because the exception is launched in CMTTxInterceptor so we cannot catch it in the update method)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (FORGE-2489) i18n and labels
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2489?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-2489.
----------------------------------
Resolution: Duplicate Issue
Thanks for the feedback. Closing as this is a duplicate of FORGE-160
> i18n and labels
> ---------------
>
> Key: FORGE-2489
> URL: https://issues.jboss.org/browse/FORGE-2489
> Project: Forge
> Issue Type: Feature Request
> Affects Versions: 2.19.2.Final
> Reporter: Aitor Fdez-Ceballos Jiménez
> Fix For: 2.x Future
>
>
> It would be quite useful that forge scaffolding for JSF could generate the xhtml pages with all the labels replaced with #{messages['key']} and include in the project a properties file with the texts so you can easily change them globally.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (FORGE-2489) i18n and labels
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2489?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2489:
-----------------------------------
Fix Version/s: 2.x Future
> i18n and labels
> ---------------
>
> Key: FORGE-2489
> URL: https://issues.jboss.org/browse/FORGE-2489
> Project: Forge
> Issue Type: Feature Request
> Affects Versions: 2.19.2.Final
> Reporter: Aitor Fdez-Ceballos Jiménez
> Fix For: 2.x Future
>
>
> It would be quite useful that forge scaffolding for JSF could generate the xhtml pages with all the labels replaced with #{messages['key']} and include in the project a properties file with the texts so you can easily change them globally.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months