[JBoss JIRA] (FURNACE-105) Throw when AddonRegistry().getServices(Class) finds nothing
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FURNACE-105?page=com.atlassian.jira.plugi... ]
George Gastaldi edited comment on FURNACE-105 at 1/25/16 12:02 PM:
-------------------------------------------------------------------
Not sure I like having a findServices, as the Imported object returned by getServices already has information about the requested service state (isUnsatisfied, isAmbiguous)
was (Author: gastaldi):
Not sure I like having a findServices, as the Imported object returned by getServices already has information about the current service state (isUnsatisfied, isAmbiguous)
> Throw when AddonRegistry().getServices(Class) finds nothing
> -----------------------------------------------------------
>
> Key: FURNACE-105
> URL: https://issues.jboss.org/browse/FURNACE-105
> Project: Forge: Furnace
> Issue Type: Feature Request
> Components: Addon Manager
> Affects Versions: 2.20.1.Final
> Reporter: Ondrej Zizka
>
> This is just a suggestion to strenghten the contract of getServices(Class).
> Often, the code looks like this:
> {code}
> furnace.getAddonRegistry().getServices(GraphApiCompositeClassLoaderProvider.class).get();
> {code}
> And all works until something goes wrong with the addons setup.
> In that case, getServices() returns null and it may end up with user seeing a NullPointerException with a nasty stacktrace.
> For the sake of better usability,
> I suggest that there could be 2 methods, getServices() which would throw an informative exception if no such services are found, and findServices() which would return null, as the current getServices() does.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 10 months
[JBoss JIRA] (FURNACE-105) Throw when AddonRegistry().getServices(Class) finds nothing
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FURNACE-105?page=com.atlassian.jira.plugi... ]
George Gastaldi commented on FURNACE-105:
-----------------------------------------
I think we should find out why getServices is returning null in your use case
> Throw when AddonRegistry().getServices(Class) finds nothing
> -----------------------------------------------------------
>
> Key: FURNACE-105
> URL: https://issues.jboss.org/browse/FURNACE-105
> Project: Forge: Furnace
> Issue Type: Feature Request
> Components: Addon Manager
> Affects Versions: 2.20.1.Final
> Reporter: Ondrej Zizka
>
> This is just a suggestion to strenghten the contract of getServices(Class).
> Often, the code looks like this:
> {code}
> furnace.getAddonRegistry().getServices(GraphApiCompositeClassLoaderProvider.class).get();
> {code}
> And all works until something goes wrong with the addons setup.
> In that case, getServices() returns null and it may end up with user seeing a NullPointerException with a nasty stacktrace.
> For the sake of better usability,
> I suggest that there could be 2 methods, getServices() which would throw an informative exception if no such services are found, and findServices() which would return null, as the current getServices() does.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 10 months
[JBoss JIRA] (FURNACE-105) Throw when AddonRegistry().getServices(Class) finds nothing
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FURNACE-105?page=com.atlassian.jira.plugi... ]
George Gastaldi commented on FURNACE-105:
-----------------------------------------
Not sure I like having a findServices, as the Imported object returned by getServices already has information about the current service state (isUnsatisfied, isAmbiguous)
> Throw when AddonRegistry().getServices(Class) finds nothing
> -----------------------------------------------------------
>
> Key: FURNACE-105
> URL: https://issues.jboss.org/browse/FURNACE-105
> Project: Forge: Furnace
> Issue Type: Feature Request
> Components: Addon Manager
> Affects Versions: 2.20.1.Final
> Reporter: Ondrej Zizka
>
> This is just a suggestion to strenghten the contract of getServices(Class).
> Often, the code looks like this:
> {code}
> furnace.getAddonRegistry().getServices(GraphApiCompositeClassLoaderProvider.class).get();
> {code}
> And all works until something goes wrong with the addons setup.
> In that case, getServices() returns null and it may end up with user seeing a NullPointerException with a nasty stacktrace.
> For the sake of better usability,
> I suggest that there could be 2 methods, getServices() which would throw an informative exception if no such services are found, and findServices() which would return null, as the current getServices() does.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 10 months
[JBoss JIRA] (FURNACE-105) Throw when AddonRegistry().getServices(Class) finds nothing
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FURNACE-105?page=com.atlassian.jira.plugi... ]
George Gastaldi commented on FURNACE-105:
-----------------------------------------
getServices() should never return null and if no services are found, get() will throw an exception and isUnsatisfied() would return true.
> Throw when AddonRegistry().getServices(Class) finds nothing
> -----------------------------------------------------------
>
> Key: FURNACE-105
> URL: https://issues.jboss.org/browse/FURNACE-105
> Project: Forge: Furnace
> Issue Type: Feature Request
> Components: Addon Manager
> Affects Versions: 2.20.1.Final
> Reporter: Ondrej Zizka
>
> This is just a suggestion to strenghten the contract of getServices(Class).
> Often, the code looks like this:
> {code}
> furnace.getAddonRegistry().getServices(GraphApiCompositeClassLoaderProvider.class).get();
> {code}
> And all works until something goes wrong with the addons setup.
> In that case, getServices() returns null and it may end up with user seeing a NullPointerException with a nasty stacktrace.
> For the sake of better usability,
> I suggest that there could be 2 methods, getServices() which would throw an informative exception if no such services are found, and findServices() which would return null, as the current getServices() does.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 10 months
[JBoss JIRA] (FURNACE-105) Throw when AddonRegistry().getServices(Class) finds nothing
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FURNACE-105?page=com.atlassian.jira.plugi... ]
George Gastaldi moved FORGE-2589 to FURNACE-105:
------------------------------------------------
Project: Forge: Furnace (was: Forge)
Key: FURNACE-105 (was: FORGE-2589)
Component/s: Addon Manager
(was: Usability)
(was: Furnace (Container))
(was: Addon Manager)
Affects Version/s: 2.20.1.Final
(was: 2.20.1.Final)
> Throw when AddonRegistry().getServices(Class) finds nothing
> -----------------------------------------------------------
>
> Key: FURNACE-105
> URL: https://issues.jboss.org/browse/FURNACE-105
> Project: Forge: Furnace
> Issue Type: Feature Request
> Components: Addon Manager
> Affects Versions: 2.20.1.Final
> Reporter: Ondrej Zizka
>
> This is just a suggestion to strenghten the contract of getServices(Class).
> Often, the code looks like this:
> {code}
> furnace.getAddonRegistry().getServices(GraphApiCompositeClassLoaderProvider.class).get();
> {code}
> And all works until something goes wrong with the addons setup.
> In that case, getServices() returns null and it may end up with user seeing a NullPointerException with a nasty stacktrace.
> For the sake of better usability,
> I suggest that there could be 2 methods, getServices() which would throw an informative exception if no such services are found, and findServices() which would return null, as the current getServices() does.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 10 months
[JBoss JIRA] (FORGE-2588) support creating projects from archetypes which don't use maven
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2588?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2588:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 3.0.0.CR1
Resolution: Done
> support creating projects from archetypes which don't use maven
> ---------------------------------------------------------------
>
> Key: FORGE-2588
> URL: https://issues.jboss.org/browse/FORGE-2588
> Project: Forge
> Issue Type: Feature Request
> Reporter: James Strachan
> Assignee: James Strachan
> Fix For: 3.0.0.CR1
>
>
> we've a bunch of archetypes for projects like nodejs, golang, swift, python, ruby; we're also hoping to add archetypes for things like Gradle / SBT etc.
> It'd be nice to allow the project-new wizard to not always create a pom.xml and src/main/* src/test/* folders if the archetype does not contain a pom.xml file.
> PR on the way shortly...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 10 months