[JBoss JIRA] (ROASTER-105) addProperty with generic value doesn't transform import
by Nicolas Challut (JIRA)
[ https://issues.jboss.org/browse/ROASTER-105?page=com.atlassian.jira.plugi... ]
Nicolas Challut commented on ROASTER-105:
-----------------------------------------
[~gastaldi]I find where the problem is. In this commit, the regression is introduce : https://github.com/forge/roaster/commit/541472e80de5d7ac08d25479254cecd34...
This code doesn't return the same resolveType
{code:java}
String resolvedType = imprt != null ? Types.rebuildGenericNameWithArrays(imprt.getSimpleName(),innerType) : Types.toSimpleName(typeName);
{code}
than this code
{code:java}
String simpleName = Types.toSimpleName(typeName);
{code}
I'll try to provide a PR but it's a little bit touchy for me :S
> addProperty with generic value doesn't transform import
> -------------------------------------------------------
>
> Key: ROASTER-105
> URL: https://issues.jboss.org/browse/ROASTER-105
> Project: Roaster
> Issue Type: Bug
> Affects Versions: 2.14.0.Final
> Reporter: Nicolas Challut
>
> {code:java}
> @Test
> public void addGenericAndGetPropertyType()
> {
> JavaClassSource classSource = Roaster.create(JavaClassSource.class);
> classSource.addProperty("java.util.List<java.lang.String>", "list");
> PropertySource<JavaClassSource> property = classSource.getProperty("list");
> Type<JavaClassSource> propertyType = property.getType();
> assertEquals("List<String>", propertyType.toString());
> }
> @Test
> public void addGenericAndGetFieldType()
> {
> JavaClassSource classSource = Roaster.create(JavaClassSource.class);
> classSource.addProperty("java.util.List<java.lang.String>", "list");
> PropertySource<JavaClassSource> property = classSource.getProperty("list");
> FieldSource<JavaClassSource> field = property.getField();
> Type<JavaClassSource> fieldType = field.getType();
> assertEquals("List<String>", fieldType.toString());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (ROASTER-105) addProperty with generic value doesn't transform import
by Nicolas Challut (JIRA)
[ https://issues.jboss.org/browse/ROASTER-105?page=com.atlassian.jira.plugi... ]
Nicolas Challut updated ROASTER-105:
------------------------------------
Affects Version/s: 2.14.0.Final
> addProperty with generic value doesn't transform import
> -------------------------------------------------------
>
> Key: ROASTER-105
> URL: https://issues.jboss.org/browse/ROASTER-105
> Project: Roaster
> Issue Type: Bug
> Affects Versions: 2.14.0.Final
> Reporter: Nicolas Challut
>
> {code:java}
> @Test
> public void addGenericAndGetPropertyType()
> {
> JavaClassSource classSource = Roaster.create(JavaClassSource.class);
> classSource.addProperty("java.util.List<java.lang.String>", "list");
> PropertySource<JavaClassSource> property = classSource.getProperty("list");
> Type<JavaClassSource> propertyType = property.getType();
> assertEquals("List<String>", propertyType.toString());
> }
> @Test
> public void addGenericAndGetFieldType()
> {
> JavaClassSource classSource = Roaster.create(JavaClassSource.class);
> classSource.addProperty("java.util.List<java.lang.String>", "list");
> PropertySource<JavaClassSource> property = classSource.getProperty("list");
> FieldSource<JavaClassSource> field = property.getField();
> Type<JavaClassSource> fieldType = field.getType();
> assertEquals("List<String>", fieldType.toString());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (FORGE-2665) addon-watch command for developer mode where we can make the forge container watch for rebuilds of addons and auto-reload them
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2665?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-2665:
----------------------------------------
Implemented in https://github.com/gastaldi/watch-addon. Install using {{addon-install-from-git --url https://github.com/gastaldi/watch-addon.git}}
The command is {{addon-watch-start}} and it will listen for changes in your {{~/.m2/repository}}
Let me know how it goes so I can move that to core and make it available in the next version.
Thank you!
> addon-watch command for developer mode where we can make the forge container watch for rebuilds of addons and auto-reload them
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-2665
> URL: https://issues.jboss.org/browse/FORGE-2665
> Project: Forge
> Issue Type: Feature Request
> Components: Addon Development
> Affects Versions: 3.2.2.Final
> Reporter: James Strachan
> Assignee: George Gastaldi
> Fix For: 3.x Future
>
>
> its kinda clumsy and slow when working on a Forge addon; you try some code, rebuild it, then in your Forge app you run the remove / install commands to get the new code into your CLI install of Forge (or your web app running Forge, or your IDE etc...)
> What would be cooler is if we had an 'addon-watch wildcard' command. That lets you start/stop watching addons that have SNAPSHOT versions. Even ignore the wildcard and just watch all SNAPSHOT addons.
> When watching, every installed addon of version SNAPSHOT, we'd watch ~/.m2/repository for the builds of the addons. If you then rebuild an addon, it'd reload the addon automatically (remove it first, then re-install it)!
> This would make it much quicker and simpler to try things out! Its especially painful when testing out changes to Forge commands in a web app (e.g. hawtio-forge) as you typically need to build the addons then rebuild the addon repo then rebuild/restart the web app etc!
> So this simple approach would help folks get more rapid feedback on building any addon - however you run them (CLI, web, IDE)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (FORGE-2664) basic web app with forge
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2664?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-2664.
----------------------------------
Resolution: Rejected
Not a bug. The target was not selected in the prompt
> basic web app with forge
> ------------------------
>
> Key: FORGE-2664
> URL: https://issues.jboss.org/browse/FORGE-2664
> Project: Forge
> Issue Type: Quality Risk
> Environment: *Location*: http://forge.jboss.org/documentation
> *User-Agent*: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36
> *Referrer*: http://forge.jboss.org/
> *Screen Resolution*: 1360 x 768
> Reporter: Lincoln Baxter III
> Labels: collector-719046f7
>
> Tried to do the steps throughout the basic web app but it failed in:
> [Speaker.java]$ scaffold-generate --web-root /
> ***INFO*** Required inputs not satisfied, entering interactive mode
> [0] ( ) AngularJS
> [1] ( ) Faces
> Press <ENTER> to confirm, or <CTRL>+C to cancel.
> * Scaffold Type: [0-1] 1
> ? Web Root Path (The web root path where the scaffolding will be placed/accessible from the client browser (default '/').) [/]:
> [0] ( ) org.basic.java.web.app.model.Speaker
> Press <ENTER> to confirm, or <CTRL>+C to cancel.
> * Targets (The JPA entities to use as the basis for generating the scaffold.): [0]
> ? Facelet Template (The Facelets template file to be used in the generated facelets.): 2.2
> ***ERROR*** Targets must be specified.
> [Speaker.java]$
> *Reporter*: Mateus Souza da Silva
> *E-mail*: [mailto:rhinoceroshead@gmail.com]
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (FORGE-2665) addon-watch command for developer mode where we can make the forge container watch for rebuilds of addons and auto-reload them
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2665?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2665:
-----------------------------------
Fix Version/s: 3.x Future
> addon-watch command for developer mode where we can make the forge container watch for rebuilds of addons and auto-reload them
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-2665
> URL: https://issues.jboss.org/browse/FORGE-2665
> Project: Forge
> Issue Type: Feature Request
> Components: Addon Development
> Affects Versions: 3.2.2.Final
> Reporter: James Strachan
> Assignee: George Gastaldi
> Fix For: 3.x Future
>
>
> its kinda clumsy and slow when working on a Forge addon; you try some code, rebuild it, then in your Forge app you run the remove / install commands to get the new code into your CLI install of Forge (or your web app running Forge, or your IDE etc...)
> What would be cooler is if we had an 'addon-watch wildcard' command. That lets you start/stop watching addons that have SNAPSHOT versions. Even ignore the wildcard and just watch all SNAPSHOT addons.
> When watching, every installed addon of version SNAPSHOT, we'd watch ~/.m2/repository for the builds of the addons. If you then rebuild an addon, it'd reload the addon automatically (remove it first, then re-install it)!
> This would make it much quicker and simpler to try things out! Its especially painful when testing out changes to Forge commands in a web app (e.g. hawtio-forge) as you typically need to build the addons then rebuild the addon repo then rebuild/restart the web app etc!
> So this simple approach would help folks get more rapid feedback on building any addon - however you run them (CLI, web, IDE)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (FORGE-2665) addon-watch command for developer mode where we can make the forge container watch for rebuilds of addons and auto-reload them
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2665?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2665:
-----------------------------------
Affects Version/s: 3.2.2.Final
> addon-watch command for developer mode where we can make the forge container watch for rebuilds of addons and auto-reload them
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-2665
> URL: https://issues.jboss.org/browse/FORGE-2665
> Project: Forge
> Issue Type: Feature Request
> Components: Addon Development
> Affects Versions: 3.2.2.Final
> Reporter: James Strachan
> Assignee: George Gastaldi
> Fix For: 3.x Future
>
>
> its kinda clumsy and slow when working on a Forge addon; you try some code, rebuild it, then in your Forge app you run the remove / install commands to get the new code into your CLI install of Forge (or your web app running Forge, or your IDE etc...)
> What would be cooler is if we had an 'addon-watch wildcard' command. That lets you start/stop watching addons that have SNAPSHOT versions. Even ignore the wildcard and just watch all SNAPSHOT addons.
> When watching, every installed addon of version SNAPSHOT, we'd watch ~/.m2/repository for the builds of the addons. If you then rebuild an addon, it'd reload the addon automatically (remove it first, then re-install it)!
> This would make it much quicker and simpler to try things out! Its especially painful when testing out changes to Forge commands in a web app (e.g. hawtio-forge) as you typically need to build the addons then rebuild the addon repo then rebuild/restart the web app etc!
> So this simple approach would help folks get more rapid feedback on building any addon - however you run them (CLI, web, IDE)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (FORGE-2665) addon-watch command for developer mode where we can make the forge container watch for rebuilds of addons and auto-reload them
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2665?page=com.atlassian.jira.plugin... ]
Work on FORGE-2665 started by George Gastaldi.
----------------------------------------------
> addon-watch command for developer mode where we can make the forge container watch for rebuilds of addons and auto-reload them
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-2665
> URL: https://issues.jboss.org/browse/FORGE-2665
> Project: Forge
> Issue Type: Feature Request
> Components: Addon Development
> Reporter: James Strachan
> Assignee: George Gastaldi
>
> its kinda clumsy and slow when working on a Forge addon; you try some code, rebuild it, then in your Forge app you run the remove / install commands to get the new code into your CLI install of Forge (or your web app running Forge, or your IDE etc...)
> What would be cooler is if we had an 'addon-watch wildcard' command. That lets you start/stop watching addons that have SNAPSHOT versions. Even ignore the wildcard and just watch all SNAPSHOT addons.
> When watching, every installed addon of version SNAPSHOT, we'd watch ~/.m2/repository for the builds of the addons. If you then rebuild an addon, it'd reload the addon automatically (remove it first, then re-install it)!
> This would make it much quicker and simpler to try things out! Its especially painful when testing out changes to Forge commands in a web app (e.g. hawtio-forge) as you typically need to build the addons then rebuild the addon repo then rebuild/restart the web app etc!
> So this simple approach would help folks get more rapid feedback on building any addon - however you run them (CLI, web, IDE)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months