February 2017 - forge-issues - Jboss List Archives

[JBoss JIRA] (ROASTER-122) Method.setBody should not be empty if an invalid code is provided

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/ROASTER-122?page=com.atlassian.jira.plugi... ] Work on ROASTER-122 started by George Gastaldi. ----------------------------------------------- > Method.setBody should not be empty if an invalid code is provided > ----------------------------------------------------------------- > > Key: ROASTER-122 > URL: https://issues.jboss.org/browse/ROASTER-122 > Project: Roaster > Issue Type: Bug > Affects Versions: 2.19.4.Final > Reporter: George Gastaldi > Assignee: George Gastaldi > Fix For: 2.20.0.Final > > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-122) Method.setBody should not be empty if an invalid code is provided

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/ROASTER-122?page=com.atlassian.jira.plugi... ] George Gastaldi updated ROASTER-122: ------------------------------------ Fix Version/s: 2.19.5.Final > Method.setBody should not be empty if an invalid code is provided > ----------------------------------------------------------------- > > Key: ROASTER-122 > URL: https://issues.jboss.org/browse/ROASTER-122 > Project: Roaster > Issue Type: Bug > Affects Versions: 2.19.4.Final > Reporter: George Gastaldi > Fix For: 2.19.5.Final > > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-122) Method.setBody should not be empty if an invalid code is provided

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/ROASTER-122?page=com.atlassian.jira.plugi... ] George Gastaldi updated ROASTER-122: ------------------------------------ Affects Version/s: 2.19.4.Final > Method.setBody should not be empty if an invalid code is provided > ----------------------------------------------------------------- > > Key: ROASTER-122 > URL: https://issues.jboss.org/browse/ROASTER-122 > Project: Roaster > Issue Type: Bug > Affects Versions: 2.19.4.Final > Reporter: George Gastaldi > Fix For: 2.19.5.Final > > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-122) Method.setBody should not be empty if an invalid code is provided

by George Gastaldi (JIRA)

George Gastaldi created ROASTER-122: --------------------------------------- Summary: Method.setBody should not be empty if an invalid code is provided Key: ROASTER-122 URL: https://issues.jboss.org/browse/ROASTER-122 Project: Roaster Issue Type: Bug Reporter: George Gastaldi -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-121) Overridden interface has wrong signature

by plamen petkov (JIRA)

[ https://issues.jboss.org/browse/ROASTER-121?page=com.atlassian.jira.plugi... ] plamen petkov edited comment on ROASTER-121 at 2/22/17 9:22 AM: ---------------------------------------------------------------- If you give me a couple of pointers, I'll be glad to take a look and fix this issue. Because you are working with JDT under the hood, I was looking through the "[addUnimplementedMethods|https://github.com/eclipse/eclipse.jdt.ui/blob/89...]" implementation that eclipse is using and I might be able to figure out how to move the logic was (Author: plamen5kov): If you give me a couple of pointers, I'll be glad to take a look and fix this issue. Because you are working with JDT under the hood, I was looking through the "[addUnimplementedMethods|https://github.com/eclipse/eclipse.jdt.ui/blob/89...]" implementation that eclipse is using and if I might be able to figure out how to move the logic > Overridden interface has wrong signature > ---------------------------------------- > > Key: ROASTER-121 > URL: https://issues.jboss.org/browse/ROASTER-121 > Project: Roaster > Issue Type: Bug > Components: JDT > Affects Versions: 2.19.4.Final > Reporter: plamen petkov > > When you implement an interface that extends another interface that has generic parameters, these parameters are not taken into account, when generating the signature of the overridden method. Will explain more in the steps to reproduce. > Having: > {code:java} > abstract class A { > public interface Iface1<T extends A> { > void doSomething(T smth); > } > } > public classs C { > public interface Iface2 extends A.Iface1<C.D> { > } > public class D extends A{ > } > } > {code} > Now when we implement C.Iface2 we should get the method with signature: > _public void doSomething(C.D smth)_, > as C.D is specified for the generic type, but instead we get: > _public void doSomething(A smth)_ > which is wrong because class A is abstract for one, and type erasure was not done right because otherwise the method signature would have the right type of parameters. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-121) Overridden interface has wrong signature

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/ROASTER-121?page=com.atlassian.jira.plugi... ] George Gastaldi commented on ROASTER-121: ----------------------------------------- This is where the method addition happens: https://github.com/forge/roaster/blob/master/api/src/main/java/org/jboss/... That method is called by implementsInterface in the jdt/ module > Overridden interface has wrong signature > ---------------------------------------- > > Key: ROASTER-121 > URL: https://issues.jboss.org/browse/ROASTER-121 > Project: Roaster > Issue Type: Bug > Components: JDT > Affects Versions: 2.19.4.Final > Reporter: plamen petkov > > When you implement an interface that extends another interface that has generic parameters, these parameters are not taken into account, when generating the signature of the overridden method. Will explain more in the steps to reproduce. > Having: > {code:java} > abstract class A { > public interface Iface1<T extends A> { > void doSomething(T smth); > } > } > public classs C { > public interface Iface2 extends A.Iface1<C.D> { > } > public class D extends A{ > } > } > {code} > Now when we implement C.Iface2 we should get the method with signature: > _public void doSomething(C.D smth)_, > as C.D is specified for the generic type, but instead we get: > _public void doSomething(A smth)_ > which is wrong because class A is abstract for one, and type erasure was not done right because otherwise the method signature would have the right type of parameters. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-121) Overridden interface has wrong signature

by plamen petkov (JIRA)

[ https://issues.jboss.org/browse/ROASTER-121?page=com.atlassian.jira.plugi... ] plamen petkov edited comment on ROASTER-121 at 2/22/17 3:34 AM: ---------------------------------------------------------------- If you give me a couple of pointers, I'll be glad to take a look and fix this issue. Because you are working with JDT under the hood, I was looking through the "[addUnimplementedMethods|https://github.com/eclipse/eclipse.jdt.ui/blob/89...]" implementation that eclipse is using and if I might be able to figure out how to move the logic was (Author: plamen5kov): If you give me a couple of pointers, I'll be glad to take a look and fix this issue. Because you are working with JDT under the hood, I was looking through the "[addUnimplementedMethods|https://github.com/eclipse/eclipse.jdt.ui/blob/89...]" implementation and if I might be able to figure out how to move the logic > Overridden interface has wrong signature > ---------------------------------------- > > Key: ROASTER-121 > URL: https://issues.jboss.org/browse/ROASTER-121 > Project: Roaster > Issue Type: Bug > Components: JDT > Affects Versions: 2.19.4.Final > Reporter: plamen petkov > > When you implement an interface that extends another interface that has generic parameters, these parameters are not taken into account, when generating the signature of the overridden method. Will explain more in the steps to reproduce. > Having: > {code:java} > abstract class A { > public interface Iface1<T extends A> { > void doSomething(T smth); > } > } > public classs C { > public interface Iface2 extends A.Iface1<C.D> { > } > public class D extends A{ > } > } > {code} > Now when we implement C.Iface2 we should get the method with signature: > _public void doSomething(C.D smth)_, > as C.D is specified for the generic type, but instead we get: > _public void doSomething(A smth)_ > which is wrong because class A is abstract for one, and type erasure was not done right because otherwise the method signature would have the right type of parameters. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-121) Overridden interface has wrong signature

by plamen petkov (JIRA)

[ https://issues.jboss.org/browse/ROASTER-121?page=com.atlassian.jira.plugi... ] plamen petkov commented on ROASTER-121: --------------------------------------- If you give me a couple of pointers, I'll be glad to take a look and fix this issue. Because you are working with JDT under the hood, I was looking through the "[addUnimplementedMethods|https://github.com/eclipse/eclipse.jdt.ui/blob/89...]" implementation and if I might be able to figure out how to move the logic > Overridden interface has wrong signature > ---------------------------------------- > > Key: ROASTER-121 > URL: https://issues.jboss.org/browse/ROASTER-121 > Project: Roaster > Issue Type: Bug > Components: JDT > Affects Versions: 2.19.4.Final > Reporter: plamen petkov > > When you implement an interface that extends another interface that has generic parameters, these parameters are not taken into account, when generating the signature of the overridden method. Will explain more in the steps to reproduce. > Having: > {code:java} > abstract class A { > public interface Iface1<T extends A> { > void doSomething(T smth); > } > } > public classs C { > public interface Iface2 extends A.Iface1<C.D> { > } > public class D extends A{ > } > } > {code} > Now when we implement C.Iface2 we should get the method with signature: > _public void doSomething(C.D smth)_, > as C.D is specified for the generic type, but instead we get: > _public void doSomething(A smth)_ > which is wrong because class A is abstract for one, and type erasure was not done right because otherwise the method signature would have the right type of parameters. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-121) Overridden interface has wrong signature

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/ROASTER-121?page=com.atlassian.jira.plugi... ] George Gastaldi updated ROASTER-121: ------------------------------------ Description: When you implement an interface that extends another interface that has generic parameters, these parameters are not taken into account, when generating the signature of the overridden method. Will explain more in the steps to reproduce. Having: {code:java} abstract class A { public interface Iface1<T extends A> { void doSomething(T smth); } } public classs C { public interface Iface2 extends A.Iface1<C.D> { } public class D extends A{ } } {code} Now when we implement C.Iface2 we should get the method with signature: _public void doSomething(C.D smth)_, as C.D is specified for the generic type, but instead we get: _public void doSomething(A smth)_ which is wrong because class A is abstract for one, and type erasure was not done right because otherwise the method signature would have the right type of parameters. was: When you implement an interface that extends another interface that has generic parameters, these parameters are not taken into account, when generating the signature of the overridden method. Will explain more in the steps to reproduce. Having: abstract class A { public interface Iface1<T extends A> { void doSomething(T smth); } } public classs C { public interface Iface2 extends A.Iface1<C.D> { } public class D extends A{ } } Now when we implement C.Iface2 we should get the method with signature: _public void doSomething(C.D smth)_, as C.D is specified for the generic type, but instead we get: _public void doSomething(A smth)_ which is wrong because class A is abstract for one, and type erasure was not done right because otherwise the method signature would have the right type of parameters. > Overridden interface has wrong signature > ---------------------------------------- > > Key: ROASTER-121 > URL: https://issues.jboss.org/browse/ROASTER-121 > Project: Roaster > Issue Type: Bug > Components: JDT > Affects Versions: 2.19.4.Final > Reporter: plamen petkov > > When you implement an interface that extends another interface that has generic parameters, these parameters are not taken into account, when generating the signature of the overridden method. Will explain more in the steps to reproduce. > Having: > {code:java} > abstract class A { > public interface Iface1<T extends A> { > void doSomething(T smth); > } > } > public classs C { > public interface Iface2 extends A.Iface1<C.D> { > } > public class D extends A{ > } > } > {code} > Now when we implement C.Iface2 we should get the method with signature: > _public void doSomething(C.D smth)_, > as C.D is specified for the generic type, but instead we get: > _public void doSomething(A smth)_ > which is wrong because class A is abstract for one, and type erasure was not done right because otherwise the method signature would have the right type of parameters. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-121) Overridden interface has wrong signature

by plamen petkov (JIRA)

plamen petkov created ROASTER-121: ------------------------------------- Summary: Overridden interface has wrong signature Key: ROASTER-121 URL: https://issues.jboss.org/browse/ROASTER-121 Project: Roaster Issue Type: Bug Components: JDT Affects Versions: 2.19.4.Final Reporter: plamen petkov When you implement an interface that extends another interface that has generic parameters, these parameters are not taken into account, when generating the signature of the overridden method. Will explain more in the steps to reproduce. Having: abstract class A { public interface Iface1<T extends A> { void doSomething(T smth); } } public classs C { public interface Iface2 extends A.Iface1<C.D> { } public class D extends A{ } } Now when we implement C.Iface2 we should get the method with signature: _public void doSomething(C.D smth)_, as C.D is specified for the generic type, but instead we get: _public void doSomething(A smth)_ which is wrong because class A is abstract for one, and type erasure was not done right because otherwise the method signature would have the right type of parameters. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 10 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

forge-issues February 2017