[JBoss JIRA] (FORGE-2784) Forge.bat shows error with JDK version 10
by Rajesh Duggal (JIRA)
[ https://issues.jboss.org/browse/FORGE-2784?page=com.atlassian.jira.plugin... ]
Rajesh Duggal commented on FORGE-2784:
--------------------------------------
I see the bug in the shell script. The regex throws up the version err when the java version number contains /1.[1-6]/... So since I'm 10.0.1 so it doesn't get a complaint.. but come java version 10.1.1 through 10.1.6 we'll start seeing the error. I'll add the PR to this JIRA shortly.
> Forge.bat shows error with JDK version 10
…
[View More]> -----------------------------------------
>
> Key: FORGE-2784
> URL: https://issues.jboss.org/browse/FORGE-2784
> Project: Forge
> Issue Type: Bug
> Components: Init Scripts, Windows
> Affects Versions: 3.9.0.Final
> Environment: Windows command prompt
> Reporter: Rajesh Duggal
> Assignee: Rajesh Duggal
> Fix For: 3.9.1.Final
>
>
> I'm running forge.bat with JDK 10.0.1 and the script errors out complaining that Java 1.7 or higher is needed.
> See: https://github.com/forge/core/blob/master/dist/src/main/resources/bin/for...
> Maybe either the bat file should allow me run forge with JDK 10+ (maybe with a warning that it's not supported/or tested yet). Or, the error message should be more specific about which versions (lower and upper limits) of the JDK are supported. So I can be precise in deciding which older JDK version to install on my system.
> (Also, perhaps that the forge unix shell script should check the JDK version number carefully. Maybe in a separate JIRA ticket?)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
[View Less]
6 years, 6 months
[JBoss JIRA] (FORGE-2784) Forge.bat shows error with JDK version 10
by Anonymous (JIRA)
[ https://issues.jboss.org/browse/FORGE-2784?page=com.atlassian.jira.plugin... ]
Issue was automatically transitioned when George Gastaldi merged pull request #627 in GitHub
--------------------------------------------------------------------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Forge.bat shows error with JDK version 10
> -----------------------------------------
>
> Key: FORGE-2784
> …
[View More]URL: https://issues.jboss.org/browse/FORGE-2784
> Project: Forge
> Issue Type: Bug
> Components: Init Scripts, Windows
> Affects Versions: 3.9.0.Final
> Environment: Windows command prompt
> Reporter: Rajesh Duggal
> Assignee: Rajesh Duggal
> Fix For: 3.9.1.Final
>
>
> I'm running forge.bat with JDK 10.0.1 and the script errors out complaining that Java 1.7 or higher is needed.
> See: https://github.com/forge/core/blob/master/dist/src/main/resources/bin/for...
> Maybe either the bat file should allow me run forge with JDK 10+ (maybe with a warning that it's not supported/or tested yet). Or, the error message should be more specific about which versions (lower and upper limits) of the JDK are supported. So I can be precise in deciding which older JDK version to install on my system.
> (Also, perhaps that the forge unix shell script should check the JDK version number carefully. Maybe in a separate JIRA ticket?)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
[View Less]
6 years, 6 months
[JBoss JIRA] (FORGE-2784) Forge.bat shows error with JDK version 10
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2784?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-2784:
----------------------------------------
[~rajeshduggal] fantastic work! Yes, it is correct. If you could fix the Unix shell script that would be awesome too (oddly I haven't seen that error when running with JDK 10, maybe luck)
Thank you very much for your contribution! You rock!
> Forge.bat shows error with JDK version 10
> ---------------------------------------…
[View More]--
>
> Key: FORGE-2784
> URL: https://issues.jboss.org/browse/FORGE-2784
> Project: Forge
> Issue Type: Bug
> Components: Windows
> Affects Versions: 3.9.0.Final
> Environment: Windows command prompt
> Reporter: Rajesh Duggal
> Assignee: Rajesh Duggal
>
> I'm running forge.bat with JDK 10.0.1 and the script errors out complaining that Java 1.7 or higher is needed.
> See: https://github.com/forge/core/blob/master/dist/src/main/resources/bin/for...
> Maybe either the bat file should allow me run forge with JDK 10+ (maybe with a warning that it's not supported/or tested yet). Or, the error message should be more specific about which versions (lower and upper limits) of the JDK are supported. So I can be precise in deciding which older JDK version to install on my system.
> (Also, perhaps that the forge unix shell script should check the JDK version number carefully. Maybe in a separate JIRA ticket?)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
[View Less]
6 years, 6 months
[JBoss JIRA] (FORGE-2784) Forge.bat shows error with JDK version 10
by Rajesh Duggal (JIRA)
[ https://issues.jboss.org/browse/FORGE-2784?page=com.atlassian.jira.plugin... ]
Rajesh Duggal commented on FORGE-2784:
--------------------------------------
[~gastaldi] I linked the pull request to this JIRA ticket. I hope I did it correctly.. let me know. Also perhaps if you like the fix, you can keep this JIRA ticket open and I'll create a second PR on this JIRA ticket to fix the unix shell script too. (Just a suggestion, feel free to describe a different strategy)
> Forge.bat …
[View More]shows error with JDK version 10
> -----------------------------------------
>
> Key: FORGE-2784
> URL: https://issues.jboss.org/browse/FORGE-2784
> Project: Forge
> Issue Type: Bug
> Components: Windows
> Affects Versions: 3.9.0.Final
> Environment: Windows command prompt
> Reporter: Rajesh Duggal
> Assignee: Rajesh Duggal
>
> I'm running forge.bat with JDK 10.0.1 and the script errors out complaining that Java 1.7 or higher is needed.
> See: https://github.com/forge/core/blob/master/dist/src/main/resources/bin/for...
> Maybe either the bat file should allow me run forge with JDK 10+ (maybe with a warning that it's not supported/or tested yet). Or, the error message should be more specific about which versions (lower and upper limits) of the JDK are supported. So I can be precise in deciding which older JDK version to install on my system.
> (Also, perhaps that the forge unix shell script should check the JDK version number carefully. Maybe in a separate JIRA ticket?)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
[View Less]
6 years, 6 months