[forge-issues] [JBoss JIRA] (FORGE-1790) Make adding addon deps easier in getDeployment().

[ https://issues.jboss.org/browse/FORGE-1790?page=com.atlassian.jira.plugin... ] Lincoln Baxter III edited comment on FORGE-1790 at 1/26/15 2:22 PM: -------------------------------------------------------------------- [~ozizka] That isn't really a solution, more of a workaround. This needs to be addressed in the Forge test-harness API. In order to fix this, we need to: * Copy @AddonDependency to @AddonDeployment * Deprecate existing @AddonDependency() annotation: * Create a new @AddonDeployment annotation: {code} @Documented @Target(ElementType.METHOD) @Retention(RetentionPolicy.RUNTIME) public @interface AddonDeployment { /** The {@link AddonId} coordinates. String name(); /** Whether or not the specified addon should be imported as a dependency to the current @Deployment. **/ boolean imported(); /** Whether or not the specified addon should be exported to dependencies of the current @Deployment. **/ boolean exported(); /** Whether or not the specified addon should be marked as an optional dependency of the current @Deployment. **/ boolean optional(); /** * If version is empty, resolve to the version specified in the pom.xml of the project being tested */ String version() default ""; } {code} If we don't deprecate @AddonDependency, then we should also supplement it with the same new fields. was (Author: lincolnthree): [~ozizka] That isn't really a solution, more of a workaround. This needs to be addressed in the Forge test-harness API. In order to fix this, we need to: * Copy @AddonDependency to @AddonDeployment * Deprecate existing @AddonDependency() annotation: * Create a new @AddonDeployment annotation: {code} @Documented @Target(ElementType.METHOD) @Retention(RetentionPolicy.RUNTIME) public @interface AddonDeployment { /** The {@link AddonId} coordinates. String name(); /** Whether or not the specified addon should be imported as a dependency to the current @Deployment. **/ boolean imported(); /** Whether or not the specified addon should be exported to dependencies of the current @Deployment. **/ boolean exported(); /** Whether or not the specified addon should be marked as an optional dependency of the current @Deployment. **/ boolean optional(); /** * If version is empty, resolve to the version specified in the pom.xml of the project being tested */ String version() default ""; } {code} -- This message was sent by Atlassian JIRA (v6.3.11#6341)