[forge-issues] [JBoss JIRA] (FORGE-85) Shell cannot parse command values containing '!' exclaimation points

[ https://issues.jboss.org/browse/FORGE-85?page=com.atlassian.jira.plugin.s... ] Shameera Rathanayaka edited comment on FORGE-85 at 3/31/12 3:42 PM: -------------------------------------------------------------------- Hi, I went through the code base , encounter that exclaimation mark of the given parameters, is use to identify "Event Designators" in ConsoleReader class. If we allow to pass any string contain '!' marks then the existing "Event Designators" support will drop. This is because, In the expandEvents method it throws event not found IllegalArgumentException when it detect size of the history is zero or history event is not match with the given syntax. we can provide a chance to "echo" plugin as a special case(i have attached patch for this) but not for all if so we need to drop the "Event Destignators" support feature. was (Author: shameera): Hi, I went through the code base , encounter that "!-exclaimation" of the given parameters, is use to identify "Event Designators" in ConsoleReader class. If we allow to pass any string contain '!' marks then the existing "Event Designators" support will drop. This is because, In the expandEvents method it throws event not found IllegalArgumentException when it detect size of the history is zero or history event is not match with the given syntax. we can provide a chance to "echo" plugin as a special case(i have attached patch for this) but not for all if so we need to drop the "Event Destignators" support feature. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira