3:04 a.m.
[
https://issues.jboss.org/browse/FORGE-1067?page=com.atlassian.jira.plugin...
]
Max Rydahl Andersen commented on FORGE-1067:
--------------------------------------------
I like the idea but I do have my concerns since:
A) this would require webjar to have the exact version we support available. i.e. we would
need to somehow QE that the official bootstrap.* files we support is actually the ones
explicitly included into the files...
B) initial blog says you need to add additional repositories to your project:
<repositories>
<repository>
<id>webjars</id>
<url>http://webjars.github.com/m2</url>
</repository>
</repositories>
That is not good if true.
B) looks like users would have to update all their specific version references of css/js
in all their html pages when updates are made ?
C) how does it work in m2e/eclipse and other IDE integrations ? If I read it right the
actual javascript and css is not actually available in the filesystem making file://
viewing and things like livereload not working out of the box.
D) Is this is only for serverside processed html (i.e. JSF) since the resources are on the
classpath, not your project ?
E) Since the resources are on the classpath my assumption is you won't see changes to
these before restarting the module - this is probably not a big deal since it is just for
a dependendent library but debugging/tweaking does becomes harder with this on first look
at least.
...on the other hand I really like it since it does make dependency fetching much
saner...but is it worth the loss of livereload, incremental updates, ide tooling ?
Adopt WebJars as encapsulation for Bootstrap and JQuery resources
-----------------------------------------------------------------
Key: FORGE-1067
URL: https://issues.jboss.org/browse/FORGE-1067
Project: Forge
Issue Type: Enhancement
Components: Scaffold
Affects Versions: 1.3.3.Final
Reporter: Antonio Goncalves
Fix For: 1.x Future
At the moment JBoss Forge copies the {{bootstrap.css}} into the resources directory. It
would be nice to use WebJar [1] to package Bootstrap (and JQuery) into the war file.
For this to happen you just need to add the following Maven dependencies to the
{{pom.xml}} :
{code}
<dependency>
<groupId>org.webjars</groupId>
<artifactId>bootstrap</artifactId>
<version>2.3.2</version>
</dependency>
<dependency>
<groupId>org.webjars</groupId>
<artifactId>jquery</artifactId>
<version>2.0.3</version>
</dependency>
{code}
Then, change the {{pageTemplate.xhtml}} so it looks like this :
{code}
<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:ui="http://java.sun.com/jsf/facelets">
<h:head>
<title>#{empty pageTitle ? '{#pageTitle}' : pageTitle}</title>
<link rel="icon"
href="#{resource['favicon.ico']}"/>
<h:outputStylesheet library="webjars/bootstrap/2.3.2/css"
name="bootstrap.min.css"/>
<h:outputStylesheet name="forge-style.css"/>
</h:head>
<h:body>
...
...
...
<!-- Bootstrap core JavaScript
================================================== -->
<!-- Placed at the end of the document so the pages load faster -->
<h:outputScript name="webjars/jquery/2.0.3/jquery.min.js"/>
<h:outputScript library="webjars/bootstrap/2.3.2/js"
name="bootstrap.min.js"/>
</h:body>
</html>
{code}
And of course, get rid of the {{bootstrap.css}} file ;o)
[1] http://www.webjars.org/
[1] http://www.jamesward.com/2012/10/31/webjars-officially-launched
See also : https://issues.jboss.org/browse/RF-12584
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4090
days inactive
4090
days old
0 comments
1 participants
participants (1)
-
Max Rydahl Andersen (JIRA)