[JBoss JIRA] (FORGE-616) Automatically attempt to install a missing plugin if not found on current installation
8:53 p.m.
George Gastaldi created FORGE-616:
-------------------------------------
Summary: Automatically attempt to install a missing plugin if not found on
current installation
Key: FORGE-616
URL: https://issues.jboss.org/browse/FORGE-616
Project: Forge
Issue Type: Enhancement
Reporter: George Gastaldi
If would be nice if when you type a plugin that is not installed on a forge installation,
Forge could search through the available plugins and install them automatically.
Also, if a command is invalid, maybe the user could have typed wrong, so, it would be nice
to display a message like "Did you mean this?" and list the possible options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
noon
[
https://issues.jboss.org/browse/FORGE-616?page=com.atlassian.jira.plugin....
]
George Gastaldi reassigned FORGE-616:
-------------------------------------
Assignee: George Gastaldi
Automatically attempt to install a missing plugin if not found on
current installation
--------------------------------------------------------------------------------------
Key: FORGE-616
URL: https://issues.jboss.org/browse/FORGE-616
Project: Forge
Issue Type: Enhancement
Reporter: George Gastaldi
Assignee: George Gastaldi
If would be nice if when you type a plugin that is not installed on a forge installation,
Forge could search through the available plugins and install them automatically.
Also, if a command is invalid, maybe the user could have typed wrong, so, it would be
nice to display a message like "Did you mean this?" and list the possible
options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
noon
[
https://issues.jboss.org/browse/FORGE-616?page=com.atlassian.jira.plugin....
]
Work on FORGE-616 started by George Gastaldi.
Automatically attempt to install a missing plugin if not found on
current installation
--------------------------------------------------------------------------------------
Key: FORGE-616
URL: https://issues.jboss.org/browse/FORGE-616
Project: Forge
Issue Type: Enhancement
Reporter: George Gastaldi
Assignee: George Gastaldi
If would be nice if when you type a plugin that is not installed on a forge installation,
Forge could search through the available plugins and install them automatically.
Also, if a command is invalid, maybe the user could have typed wrong, so, it would be
nice to display a message like "Did you mean this?" and list the possible
options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:15 p.m.
[
https://issues.jboss.org/browse/FORGE-616?page=com.atlassian.jira.plugin....
]
George Gastaldi updated FORGE-616:
----------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/forge/core/pull/179
Automatically attempt to install a missing plugin if not found on
current installation
--------------------------------------------------------------------------------------
Key: FORGE-616
URL: https://issues.jboss.org/browse/FORGE-616
Project: Forge
Issue Type: Enhancement
Reporter: George Gastaldi
Assignee: George Gastaldi
If would be nice if when you type a plugin that is not installed on a forge installation,
Forge could search through the available plugins and install them automatically.
Also, if a command is invalid, maybe the user could have typed wrong, so, it would be
nice to display a message like "Did you mean this?" and list the possible
options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:42 p.m.
[
https://issues.jboss.org/browse/FORGE-616?page=com.atlassian.jira.plugin....
]
George Gastaldi updated FORGE-616:
----------------------------------
Status: Closed (was: Pull Request Sent)
Fix Version/s: 1.0.6.Final
Resolution: Done
Automatically attempt to install a missing plugin if not found on
current installation
--------------------------------------------------------------------------------------
Key: FORGE-616
URL: https://issues.jboss.org/browse/FORGE-616
Project: Forge
Issue Type: Enhancement
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 1.0.6.Final
If would be nice if when you type a plugin that is not installed on a forge installation,
Forge could search through the available plugins and install them automatically.
Also, if a command is invalid, maybe the user could have typed wrong, so, it would be
nice to display a message like "Did you mean this?" and list the possible
options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:40 p.m.
[
https://issues.jboss.org/browse/FORGE-616?page=com.atlassian.jira.plugin....
]
Lincoln Baxter III commented on FORGE-616:
------------------------------------------
Hey George! This is really really great. 1 comment, 1 question:
Comment: Forge should ask the user if they would like to install before going ahead. Looks
like it automatically does this right now?
Question: Have you checked for other locations where Status.SUCCESS / Status.FAILURE to
make sure that adding another enum won't cause issues? I ask because MISSING should
probably behave like FAILURE if not otherwise specified.
Thoughts?
Automatically attempt to install a missing plugin if not found on
current installation
--------------------------------------------------------------------------------------
Key: FORGE-616
URL: https://issues.jboss.org/browse/FORGE-616
Project: Forge
Issue Type: Enhancement
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 1.0.6.Final
If would be nice if when you type a plugin that is not installed on a forge installation,
Forge could search through the available plugins and install them automatically.
Also, if a command is invalid, maybe the user could have typed wrong, so, it would be
nice to display a message like "Did you mean this?" and list the possible
options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:10 a.m.
[
https://issues.jboss.org/browse/FORGE-616?page=com.atlassian.jira.plugin....
]
George Gastaldi commented on FORGE-616:
---------------------------------------
Hi Lincoln,
I totally agree with your comment. Will implement that today.
Also, I checked for other locations where the Status enum is used and is not used anywhere
besides the Execution class and ForgePlugin itself.
There are very few plugins which observes this CommandExecuted event and deals with the
status. One of them is the Undo plugin, which Jevgeni already checks for it ("Create
a commit only if Status == SUCESSS").
Anyway, I thought about that and I found out that it's a matter of interpretation:
Should Status.FAILURE indicate a failure in the plugin execution or it can be used to
indicate that a plugin is missing / wrongly typed ? The best way to detect that was with
this new MISSING enum afaik.
If you feel the need to change that, we can do it, no problem. Just let me know your
thoughts about it.
Best Regards,
George Gastaldi
Automatically attempt to install a missing plugin if not found on
current installation
--------------------------------------------------------------------------------------
Key: FORGE-616
URL: https://issues.jboss.org/browse/FORGE-616
Project: Forge
Issue Type: Enhancement
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 1.0.6.Final
If would be nice if when you type a plugin that is not installed on a forge installation,
Forge could search through the available plugins and install them automatically.
Also, if a command is invalid, maybe the user could have typed wrong, so, it would be
nice to display a message like "Did you mean this?" and list the possible
options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:20 a.m.
[
https://issues.jboss.org/browse/FORGE-616?page=com.atlassian.jira.plugin....
]
Lincoln Baxter III commented on FORGE-616:
------------------------------------------
No, I think it's a good change. I just wanted to make sure that the implications had
been considered :)
~Lincoln
Automatically attempt to install a missing plugin if not found on
current installation
--------------------------------------------------------------------------------------
Key: FORGE-616
URL: https://issues.jboss.org/browse/FORGE-616
Project: Forge
Issue Type: Enhancement
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 1.0.6.Final
If would be nice if when you type a plugin that is not installed on a forge installation,
Forge could search through the available plugins and install them automatically.
Also, if a command is invalid, maybe the user could have typed wrong, so, it would be
nice to display a message like "Did you mean this?" and list the possible
options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4539
days inactive
4546
days old
7 comments
2 participants
participants (2)
-
George Gastaldi (JIRA) -
Lincoln Baxter III (JIRA)