[
https://issues.jboss.org/browse/FORGE-2230?page=com.atlassian.jira.plugin...
]
Lincoln Baxter III commented on FORGE-2230:
-------------------------------------------
It's a shame we returned null here. You need to check for empty string anyway when
dealing with coordinates in most systems, so this is really adding unnecessary work.
CoordinateBuilder should set null for empty parts of G:A:P:C:V
--------------------------------------------------------------
Key: FORGE-2230
URL:
https://issues.jboss.org/browse/FORGE-2230
Project: Forge
Issue Type: Enhancement
Components: Dependencies
Affects Versions: 2.14.0.Final
Reporter: Ondrej Zizka
Labels: starter
Fix For: 2.x Future
CoordinateBuilder, when given "G:A:::V", should set P and C to null. Having
them empty strings is no good.
Consider machine-provided lists contaning:
org.foo:foo-bar:::4.1.2
This should end with the same result as parsing
org.foo:foo-bar:4.1.2
whereas it ends up with P and C set to empty strings, and forces the user of the api to
do extra check for an empty string value.
Related:
"Malformed coordinate. Should be
groupId:artifactId:[packaging]:[classifier]:[version]");
should read
"Malformed coordinate. Should be
groupId:artifactId:[packaging:[classifier:]][version]");
And javadoc's
<groupId>:<artifactId>[:<packaging>[:<classifier>]]:<version>
should read
<groupId>:<artifactId>[:<packaging>[:<classifier>]]:[<version>]
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)