[JBoss JIRA] (FORGE-895) Shell crops Strings with UTF-8 charaters
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-895?page=com.atlassian.jira.plugin.... ]
Lincoln Baxter III commented on FORGE-895:
------------------------------------------
This will be in the 1.3.0.Final release happening next Wednesday the 15th.
> Shell crops Strings with UTF-8 charaters
> ----------------------------------------
>
> Key: FORGE-895
> URL: https://issues.jboss.org/browse/FORGE-895
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell
> Affects Versions: 1.2.3.Final
> Reporter: Florian Hirsch
> Assignee: George Gastaldi
> Priority: Minor
> Fix For: 1.3.0.Final
>
>
> when I try to print some UTF-8 characters in the shell the end of the line is cropped. E.g.
> {code}
> shell.print("\u2501 Hello World");
> {code}
> results in
> {code}
> ━ Hello Wor
> {code}
> Looks like the org.jboss.forge.shell.buffers.JLineScreenBuffer is calculating the BufferSize wrong:
> {code}
> public synchronized void write(String s) {
> if (bufferSize + s.length() >= maxBufferSize)
> {
> flushBuffer();
> write(s);
> }
> buffer.put(s.getBytes());
> bufferSize += s.length();
> _flush();
> }
> {code}
> s.length() is returning the size of the used Characters, not the Size of the used Bytes. Could be replaced by s.getBytes("UTF-8").length or e.g. [this calculation method|http://stackoverflow.com/questions/8511490/calculating-length-in-u...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (FORGE-896) Different Facets for main and test sources/resources
by George Gastaldi (JIRA)
George Gastaldi created FORGE-896:
-------------------------------------
Summary: Different Facets for main and test sources/resources
Key: FORGE-896
URL: https://issues.jboss.org/browse/FORGE-896
Project: Forge
Issue Type: Enhancement
Components: Maven Integration
Affects Versions: 2.0.0.Alpha3
Reporter: George Gastaldi
Fix For: 2.0.0.Alpha4
It should be possible to have a facet to create the src/main/* structure and another facet for src/test/*.
JavaSourceFacet and ResourceFacet should be split into two different interfaces to allow that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (FORGE-895) Shell crops Strings with UTF-8 charaters
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-895?page=com.atlassian.jira.plugin.... ]
George Gastaldi closed FORGE-895.
---------------------------------
Fix Version/s: 1.3.0.Final
Resolution: Done
Fixed, thanks !
> Shell crops Strings with UTF-8 charaters
> ----------------------------------------
>
> Key: FORGE-895
> URL: https://issues.jboss.org/browse/FORGE-895
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell
> Affects Versions: 1.2.3.Final
> Reporter: Florian Hirsch
> Assignee: George Gastaldi
> Priority: Minor
> Fix For: 1.3.0.Final
>
>
> when I try to print some UTF-8 characters in the shell the end of the line is cropped. E.g.
> {code}
> shell.print("\u2501 Hello World");
> {code}
> results in
> {code}
> ━ Hello Wor
> {code}
> Looks like the org.jboss.forge.shell.buffers.JLineScreenBuffer is calculating the BufferSize wrong:
> {code}
> public synchronized void write(String s) {
> if (bufferSize + s.length() >= maxBufferSize)
> {
> flushBuffer();
> write(s);
> }
> buffer.put(s.getBytes());
> bufferSize += s.length();
> _flush();
> }
> {code}
> s.length() is returning the size of the used Characters, not the Size of the used Bytes. Could be replaced by s.getBytes("UTF-8").length or e.g. [this calculation method|http://stackoverflow.com/questions/8511490/calculating-length-in-u...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (FORGE-895) Shell crops Strings with UTF-8 charaters
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-895?page=com.atlassian.jira.plugin.... ]
George Gastaldi reassigned FORGE-895:
-------------------------------------
Assignee: George Gastaldi
> Shell crops Strings with UTF-8 charaters
> ----------------------------------------
>
> Key: FORGE-895
> URL: https://issues.jboss.org/browse/FORGE-895
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell
> Affects Versions: 1.2.3.Final
> Reporter: Florian Hirsch
> Assignee: George Gastaldi
> Priority: Minor
>
> when I try to print some UTF-8 characters in the shell the end of the line is cropped. E.g.
> {code}
> shell.print("\u2501 Hello World");
> {code}
> results in
> {code}
> ━ Hello Wor
> {code}
> Looks like the org.jboss.forge.shell.buffers.JLineScreenBuffer is calculating the BufferSize wrong:
> {code}
> public synchronized void write(String s) {
> if (bufferSize + s.length() >= maxBufferSize)
> {
> flushBuffer();
> write(s);
> }
> buffer.put(s.getBytes());
> bufferSize += s.length();
> _flush();
> }
> {code}
> s.length() is returning the size of the used Characters, not the Size of the used Bytes. Could be replaced by s.getBytes("UTF-8").length or e.g. [this calculation method|http://stackoverflow.com/questions/8511490/calculating-length-in-u...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (FORGE-895) Shell crops Strings with UTF-8 charaters
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-895?page=com.atlassian.jira.plugin.... ]
Work on FORGE-895 started by George Gastaldi.
> Shell crops Strings with UTF-8 charaters
> ----------------------------------------
>
> Key: FORGE-895
> URL: https://issues.jboss.org/browse/FORGE-895
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell
> Affects Versions: 1.2.3.Final
> Reporter: Florian Hirsch
> Assignee: George Gastaldi
> Priority: Minor
>
> when I try to print some UTF-8 characters in the shell the end of the line is cropped. E.g.
> {code}
> shell.print("\u2501 Hello World");
> {code}
> results in
> {code}
> ━ Hello Wor
> {code}
> Looks like the org.jboss.forge.shell.buffers.JLineScreenBuffer is calculating the BufferSize wrong:
> {code}
> public synchronized void write(String s) {
> if (bufferSize + s.length() >= maxBufferSize)
> {
> flushBuffer();
> write(s);
> }
> buffer.put(s.getBytes());
> bufferSize += s.length();
> _flush();
> }
> {code}
> s.length() is returning the size of the used Characters, not the Size of the used Bytes. Could be replaced by s.getBytes("UTF-8").length or e.g. [this calculation method|http://stackoverflow.com/questions/8511490/calculating-length-in-u...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (FORGE-895) Shell crops Strings with UTF-8 charaters
by Florian Hirsch (JIRA)
Florian Hirsch created FORGE-895:
------------------------------------
Summary: Shell crops Strings with UTF-8 charaters
Key: FORGE-895
URL: https://issues.jboss.org/browse/FORGE-895
Project: Forge
Issue Type: Bug
Components: UI - Shell
Affects Versions: 1.2.3.Final
Reporter: Florian Hirsch
Priority: Minor
when I try to print some UTF-8 characters in the shell the end of the line is cropped. E.g.
{code}
shell.print("\u2501 Hello World");
{code}
results in
{code}
━ Hello Wor
{code}
Looks like the org.jboss.forge.shell.buffers.JLineScreenBuffer is calculating the BufferSize wrong:
{code}
public synchronized void write(String s) {
if (bufferSize + s.length() >= maxBufferSize)
{
flushBuffer();
write(s);
}
buffer.put(s.getBytes());
bufferSize += s.length();
_flush();
}
{code}
s.length() is returning the size of the used Characters, not the Size of the used Bytes. Could be replaced by s.getBytes("UTF-8").length or e.g. [this calculation method|http://stackoverflow.com/questions/8511490/calculating-length-in-u...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (FORGE-894) Forge DependencyFacet cannot resolve dependencies in reactor projects without first installing necessary dependencies in the local Repository
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-894?page=com.atlassian.jira.plugin.... ]
Lincoln Baxter III updated FORGE-894:
-------------------------------------
Description:
As the title states, maven project building requests do not resolv reactor project dependencies.
{code}
parent/
- addon --> spi
- api
- impl
- spi
- tests --> addon
{code}
the tests/ module dependency resolution result does not contain a transitive dependency to the spi/ module, however, when building from maven cli, it clearly should and does have this dependency - so this is a pure tooling issue due to the fact that the addon/ sub-module actually cannot be resolved.
This can be reproduced in the branch: https://github.com/forge/core/tree/FORGE-894
Running the test:
{code}
Failed tests: testCreateAddonProject(org.jboss.forge.addons.AddonProjectConfiguratorTest): SPI module is not present in the TESTS module
{code}
Relevant code (where the resolution is performed) is here: https://github.com/forge/core/blob/FORGE-894/maven/impl-projects/src/main...
was:
As the title states, maven project building requests do not resolv reactor project dependencies.
{code}
parent/
- addon --> spi
- api
- impl
- spi
- tests --> addon
{code}
the tests/ module dependency resolution result does not contain a transitive dependency to the spi/ module, however, when building from maven cli, it clearly should and does have this dependency - so this is a pure tooling issue due to the fact that the addon/ sub-module actually cannot be resolved.
This can be reproduced in the branch: https://github.com/forge/core/tree/FORGE-894
Running the test:
{code}
Failed tests: testCreateAddonProject(org.jboss.forge.addons.AddonProjectConfiguratorTest): SPI module is not present in the TESTS module
{code}
> Forge DependencyFacet cannot resolve dependencies in reactor projects without first installing necessary dependencies in the local Repository
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-894
> URL: https://issues.jboss.org/browse/FORGE-894
> Project: Forge
> Issue Type: Bug
> Components: Maven Integration
> Affects Versions: 2.0.0.Alpha3
> Reporter: Lincoln Baxter III
> Assignee: Lincoln Baxter III
> Fix For: 2.0.0.Alpha4
>
>
> As the title states, maven project building requests do not resolv reactor project dependencies.
> {code}
> parent/
> - addon --> spi
> - api
> - impl
> - spi
> - tests --> addon
> {code}
> the tests/ module dependency resolution result does not contain a transitive dependency to the spi/ module, however, when building from maven cli, it clearly should and does have this dependency - so this is a pure tooling issue due to the fact that the addon/ sub-module actually cannot be resolved.
> This can be reproduced in the branch: https://github.com/forge/core/tree/FORGE-894
> Running the test:
> {code}
> Failed tests: testCreateAddonProject(org.jboss.forge.addons.AddonProjectConfiguratorTest): SPI module is not present in the TESTS module
> {code}
> Relevant code (where the resolution is performed) is here: https://github.com/forge/core/blob/FORGE-894/maven/impl-projects/src/main...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (FORGE-894) Forge DependencyFacet cannot resolve dependencies in reactor projects without first installing necessary dependencies in the local Repository
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-894?page=com.atlassian.jira.plugin.... ]
Lincoln Baxter III commented on FORGE-894:
------------------------------------------
gastaldi:
I am observing the object returning by ((MavenFacetImpl) maven).getFullProjectBuildingResult()
gastaldi:
The addon/ dependency is returned in ((MavenFacetImpl) maven).getFullProjectBuildingResult().getDependencyResolutionResult().getUnresolvedDependencies()
lincolnthree:
This is why the transitive spi/ dependency is not being resolved either, but since the addon/ dep is specified directly in the pom, it is returned in the result.
> Forge DependencyFacet cannot resolve dependencies in reactor projects without first installing necessary dependencies in the local Repository
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-894
> URL: https://issues.jboss.org/browse/FORGE-894
> Project: Forge
> Issue Type: Bug
> Components: Maven Integration
> Affects Versions: 2.0.0.Alpha3
> Reporter: Lincoln Baxter III
> Assignee: Lincoln Baxter III
> Fix For: 2.0.0.Alpha4
>
>
> As the title states, maven project building requests do not resolv reactor project dependencies.
> {code}
> parent/
> - addon --> spi
> - api
> - impl
> - spi
> - tests --> addon
> {code}
> the tests/ module dependency resolution result does not contain a transitive dependency to the spi/ module, however, when building from maven cli, it clearly should and does have this dependency - so this is a pure tooling issue due to the fact that the addon/ sub-module actually cannot be resolved.
> This can be reproduced in the branch: https://github.com/forge/core/tree/FORGE-894
> Running the test:
> {code}
> Failed tests: testCreateAddonProject(org.jboss.forge.addons.AddonProjectConfiguratorTest): SPI module is not present in the TESTS module
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (FORGE-894) Forge DependencyFacet cannot resolve dependencies in reactor projects without first installing necessary dependencies in the local Repository
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-894?page=com.atlassian.jira.plugin.... ]
Lincoln Baxter III updated FORGE-894:
-------------------------------------
Summary: Forge DependencyFacet cannot resolve dependencies in reactor projects without first installing necessary dependencies in the local Repository (was: Forge DependencyFacet cannot resolve transitive dependencies in reactor projects without first installing necessary dependencies in the local Repository)
> Forge DependencyFacet cannot resolve dependencies in reactor projects without first installing necessary dependencies in the local Repository
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-894
> URL: https://issues.jboss.org/browse/FORGE-894
> Project: Forge
> Issue Type: Bug
> Components: Maven Integration
> Affects Versions: 2.0.0.Alpha3
> Reporter: Lincoln Baxter III
> Assignee: Lincoln Baxter III
> Fix For: 2.0.0.Alpha4
>
>
> As the title states, maven project building requests do not resolve transitive reactor project dependencies.
> {code}
> parent/
> - addon --> spi
> - api
> - impl
> - spi
> - tests --> addon
> {code}
> the tests/ module dependency resolution result does not contain a transitive dependency to the spi/ module, however, when building from maven cli, it clearly should and does have this dependency - so this is a pure tooling issue.
> This can be reproduced in the branch: https://github.com/forge/core/tree/FORGE-894
> Running the test:
> {code}
> Failed tests: testCreateAddonProject(org.jboss.forge.addons.AddonProjectConfiguratorTest): SPI module is not present in the TESTS module
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (FORGE-894) Forge DependencyFacet cannot resolve dependencies in reactor projects without first installing necessary dependencies in the local Repository
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-894?page=com.atlassian.jira.plugin.... ]
Lincoln Baxter III updated FORGE-894:
-------------------------------------
Description:
As the title states, maven project building requests do not resolv reactor project dependencies.
{code}
parent/
- addon --> spi
- api
- impl
- spi
- tests --> addon
{code}
the tests/ module dependency resolution result does not contain a transitive dependency to the spi/ module, however, when building from maven cli, it clearly should and does have this dependency - so this is a pure tooling issue due to the fact that the addon/ sub-module actually cannot be resolved.
This can be reproduced in the branch: https://github.com/forge/core/tree/FORGE-894
Running the test:
{code}
Failed tests: testCreateAddonProject(org.jboss.forge.addons.AddonProjectConfiguratorTest): SPI module is not present in the TESTS module
{code}
was:
As the title states, maven project building requests do not resolve transitive reactor project dependencies.
{code}
parent/
- addon --> spi
- api
- impl
- spi
- tests --> addon
{code}
the tests/ module dependency resolution result does not contain a transitive dependency to the spi/ module, however, when building from maven cli, it clearly should and does have this dependency - so this is a pure tooling issue.
This can be reproduced in the branch: https://github.com/forge/core/tree/FORGE-894
Running the test:
{code}
Failed tests: testCreateAddonProject(org.jboss.forge.addons.AddonProjectConfiguratorTest): SPI module is not present in the TESTS module
{code}
> Forge DependencyFacet cannot resolve dependencies in reactor projects without first installing necessary dependencies in the local Repository
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-894
> URL: https://issues.jboss.org/browse/FORGE-894
> Project: Forge
> Issue Type: Bug
> Components: Maven Integration
> Affects Versions: 2.0.0.Alpha3
> Reporter: Lincoln Baxter III
> Assignee: Lincoln Baxter III
> Fix For: 2.0.0.Alpha4
>
>
> As the title states, maven project building requests do not resolv reactor project dependencies.
> {code}
> parent/
> - addon --> spi
> - api
> - impl
> - spi
> - tests --> addon
> {code}
> the tests/ module dependency resolution result does not contain a transitive dependency to the spi/ module, however, when building from maven cli, it clearly should and does have this dependency - so this is a pure tooling issue due to the fact that the addon/ sub-module actually cannot be resolved.
> This can be reproduced in the branch: https://github.com/forge/core/tree/FORGE-894
> Running the test:
> {code}
> Failed tests: testCreateAddonProject(org.jboss.forge.addons.AddonProjectConfiguratorTest): SPI module is not present in the TESTS module
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months