[JBoss JIRA] (FORGE-85) Shell cannot parse command values containing '!' exclaimation points
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-85?page=com.atlassian.jira.plugin.s... ]
Vineet Reynolds commented on FORGE-85:
--------------------------------------
Escaping of exclamation marks was fixed upstream in jline2, a few months back. I've ported it to a topic branch on my clone: https://github.com/VineetReynolds/forge-core/tree/FORGE-85.
But this alone does not solve the problem yet. The FSH parser tokenizes '!'s differently. Thus, a command invocation provided to the parser, like {{new-project --named example --finalName example!test}}, is turned into {{new-project --named example --finalName example ! test}}. The tokens '!' and 'test' are eventually ignored as arguments to the new-project plugin, due to the spaces injected by the FSH parser.
> Shell cannot parse command values containing '!' exclaimation points
> --------------------------------------------------------------------
>
> Key: FORGE-85
> URL: https://issues.jboss.org/browse/FORGE-85
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell
> Affects Versions: 1.0.0.Beta2
> Reporter: Lincoln Baxter III
> Labels: HackNight
> Fix For: 1.x Future
>
> Attachments: Forge-85.patch
>
>
> {code}
> [pfdemo] pfdemo $ echo sdfdf!
> sdfdf !
> [pfdemo] pfdemo $ echo sdfdf!sdf
> ***ERROR*** Exception encountered: !sdf: event not found (type "set VERBOSE true" to enable stack traces)
> [pfdemo] pfdemo $
> [pfdemo] pfdemo $ echo 'asdf!asdf`
> ***ERROR*** Exception encountered: !asdf`: event not found (type "set VERBOSE true" to enable stack traces)
> [pfdemo] pfdemo $
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-791) Forge auto complete in windows doesn't display command until after I forge again
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-791?page=com.atlassian.jira.plugin.... ]
Vineet Reynolds updated FORGE-791:
----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/forge/core/pull/332
This should be resolved by the fix made for FORGE-942. With the proposed fix, I am no longer able to reproduce this failure, since Jansi forwards the Tab keystroke to the Forge console reader on Windows.
> Forge auto complete in windows doesn't display command until after I forge again
> --------------------------------------------------------------------------------
>
> Key: FORGE-791
> URL: https://issues.jboss.org/browse/FORGE-791
> Project: Forge
> Issue Type: Bug
> Components: Usability, Windows
> Reporter: John Ament
> Fix For: 1.x Future
>
>
> If I attempt to type in "sp" then tab, the screen fills with some blanks, then tells me the command was not filled in properly. So it identified the command I wanted, but didn't show it on the screen.
> {code}
> [ooph] ooph $ sp ^C
> spartajs.io
> ***ERROR*** [spartajs.io] Missing command for plugin [spartajs.io], available commands: [addRestResource, addJackson, remove, setup, add, javascriptModel]
> [ooph] ooph $
> [ooph] ooph $ forge
> _____
> | ___|__ _ __ __ _ ___
> | |_ / _ \| `__/ _` |/ _ \ \\
> | _| (_) | | | (_| | __/ //
> |_| \___/|_| \__, |\___|
> |___/
> JBoss Forge, version [ 1.2.1.Final ] - JBoss, by Red Hat, Inc. [ http://forge.jboss.org ]
> {code}
> After hitting forge again it does auto complete properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-791) Forge auto complete in windows doesn't display command until after I forge again
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-791?page=com.atlassian.jira.plugin.... ]
Vineet Reynolds reassigned FORGE-791:
-------------------------------------
Assignee: Vineet Reynolds
> Forge auto complete in windows doesn't display command until after I forge again
> --------------------------------------------------------------------------------
>
> Key: FORGE-791
> URL: https://issues.jboss.org/browse/FORGE-791
> Project: Forge
> Issue Type: Bug
> Components: Usability, Windows
> Reporter: John Ament
> Assignee: Vineet Reynolds
> Fix For: 1.x Future
>
>
> If I attempt to type in "sp" then tab, the screen fills with some blanks, then tells me the command was not filled in properly. So it identified the command I wanted, but didn't show it on the screen.
> {code}
> [ooph] ooph $ sp ^C
> spartajs.io
> ***ERROR*** [spartajs.io] Missing command for plugin [spartajs.io], available commands: [addRestResource, addJackson, remove, setup, add, javascriptModel]
> [ooph] ooph $
> [ooph] ooph $ forge
> _____
> | ___|__ _ __ __ _ ___
> | |_ / _ \| `__/ _` |/ _ \ \\
> | _| (_) | | | (_| | __/ //
> |_| \___/|_| \__, |\___|
> |___/
> JBoss Forge, version [ 1.2.1.Final ] - JBoss, by Red Hat, Inc. [ http://forge.jboss.org ]
> {code}
> After hitting forge again it does auto complete properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-942) CommandHistory / Doskey display is not working in Windows.
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-942?page=com.atlassian.jira.plugin.... ]
Vineet Reynolds updated FORGE-942:
----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/forge/core/pull/332
The fix is to use Jansi for reading characters in Windows
This is the default jline2 behavior. Reading is delegated to WindowsSupport.getByte on Windows instead of reading directly from System.in. This makes keystrokes like arrow keys available as events to the ConsoleReader, thus triggering the browsing of the Forge command history correctly. Command history now works well in Windows as a result of this.
> CommandHistory / Doskey display is not working in Windows.
> ----------------------------------------------------------
>
> Key: FORGE-942
> URL: https://issues.jboss.org/browse/FORGE-942
> Project: Forge
> Issue Type: Bug
> Components: Windows
> Affects Versions: 1.3.0.Final
> Environment: Windows XP, java version "1.7.0_21", Forge 1.3.0-Final
> Reporter: Rajmahendra Hegde
> Fix For: 1.x Future
>
>
> When I try to use Forege in command prompt in Windows, After executing couple of forge commands and try to use arrow key Up and Down. I cant see the command history.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1012) Forge occassionally requires an additional keystroke to be terminated
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1012?page=com.atlassian.jira.plugin... ]
Vineet Reynolds updated FORGE-1012:
-----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/forge/core/pull/332
Set the console reader thread to a daemon.
This ensures that Forge terminates immediately upon exit without requiring another keystroke to unblock the blocked reader thread on System.in
Also modified the invocation of the exit command on Ctrl+D to issue a new line upon exit to ensure that the shell prompt appears in a new line.
> Forge occassionally requires an additional keystroke to be terminated
> ---------------------------------------------------------------------
>
> Key: FORGE-1012
> URL: https://issues.jboss.org/browse/FORGE-1012
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Assignee: Vineet Reynolds
> Priority: Minor
>
> This is related to the behavior described in FORGE-593. In that bug, a keystroke consumed by Forge was lost due to the blocking thread. The bugfix for that issue did not involve any fixes around the blocking read on System.in.
> Hence, the reader thread continues to block when reading System.in, thus requiring users to send another keystroke (again to be consumed by the blocking reader) on exiting Forge (since the reader operates in a non-daemon thread).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1012) Forge occassionally requires an additional keystroke to be terminated
by Vineet Reynolds (JIRA)
Vineet Reynolds created FORGE-1012:
--------------------------------------
Summary: Forge occassionally requires an additional keystroke to be terminated
Key: FORGE-1012
URL: https://issues.jboss.org/browse/FORGE-1012
Project: Forge
Issue Type: Bug
Components: UI - Shell
Affects Versions: 1.3.3.Final
Reporter: Vineet Reynolds
Assignee: Vineet Reynolds
Priority: Minor
This is related to the behavior described in FORGE-593. In that bug, a keystroke consumed by Forge was lost due to the blocking thread. The bugfix for that issue did not involve any fixes around the blocking read on System.in.
Hence, the reader thread continues to block when reading System.in, thus requiring users to send another keystroke (again to be consumed by the blocking reader) on exiting Forge (since the reader operates in a non-daemon thread).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1007) Furnace container should support pluggable service providers.
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1007?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III closed FORGE-1007.
-------------------------------------
Assignee: Lincoln Baxter III
Fix Version/s: 2.0.0.Alpha7
(was: 2.x Future)
Resolution: Done
Completed with introduction of "org.jboss.forge.furnace:container-api:forge-addon" and the org.jboss.forge.furnace.lifecycle.AddonLifecycleProducer SPI.
> Furnace container should support pluggable service providers.
> -------------------------------------------------------------
>
> Key: FORGE-1007
> URL: https://issues.jboss.org/browse/FORGE-1007
> Project: Forge
> Issue Type: Feature Request
> Components: Furnace (Container)
> Affects Versions: 2.0.0.Alpha6
> Reporter: Lincoln Baxter III
> Assignee: Lincoln Baxter III
> Fix For: 2.0.0.Alpha7
>
>
> {code}11:49:28 AM lincolnthree1: gastaldi: I am considering creating a furnace-cdi addon
> 11:50:22 AM lincolnthree1: if all addons depended on this, it would make it a lot easier to support pluggable addon containers, instead of assuming CDI based on beans.xml
> 11:50:32 AM lincolnthree1: they could depend on that instead of furnace-api
> 11:50:43 AM lincolnthree1: and it would no longer need to be <provided> scope
> 11:51:21 AM lincolnthree1: i would say that it could wait for Forge 2.1
> 11:51:23 AM lincolnthree1: but...
> 11:51:29 AM lincolnthree1: it would likely not be a backwards compatible change.
> 11:52:16 AM lincolnthree1: it's pretty complicated though
> 11:52:22 AM lincolnthree1: so i'll probably put it off
> 11:52:40 AM lincolnthree1: we need to get business value first
> 11:52:42 AM lincolnthree1: and we don't need that atm
> 11:53:08 AM lincolnthree1: but… what we could do is use the addon as a marker
> 11:53:18 AM lincolnthree1: that would be simpler than actually implementing it all
> 11:53:23 AM lincolnthree1: it would still bring in the APIs
> 11:53:29 AM lincolnthree1: but wouldn't really change the internals
> 11:55:24 AM gastaldi: hummm
> 11:55:31 AM gastaldi: that would be interesting
> 11:55:32 AM lincolnthree1: actually, that might very well work
> 11:55:57 AM gastaldi: I think we should do it for 2.0
> 11:56:00 AM lincolnthree1: in the end, this addon would register a service called "AddonInitializer" that handles the startup/shutdown of the addon (aka, addon Runnable)
> 11:56:02 AM lincolnthree1: yeah me too
> 11:56:15 AM lincolnthree1: Furnace could get that instance from the addon itself using ServiceLoader
> 11:56:32 AM lincolnthree1: then it would call it and the lifecycle comes from the addon itself!!
> 11:56:41 AM lincolnthree1: brilliant!
> 11:57:07 AM lincolnthree1: a classloading-only addon just becomes one, then, that doesnt have an AddonInitializer
> 11:57:10 AM lincolnthree1: I like it
> 11:57:11 AM lincolnthree1: a lot
> 11:57:58 AM gastaldi: JIRA that sh*t
> 11:58:18 AM lincolnthree1: it maybe already
> 11:58:23 AM lincolnthree1: but i'll add these notes if it is
> gegastaldi [~gastaldi@redhat/jboss/gastaldi] entered the room. (11:58:33 AM)
> mode (+o gegastaldi) by ChanServ (11:58:33 AM)
> 12:00:04 PM lincolnthree1: gastaldi: getting lunch and relocating
> 12:00:06 PM lincolnthree1: back in a bit
> 12:00:35 PM gegastaldi: K
> 12:02:17 PM gegastaldi: That would enable CDI extensions
> 12:02:26 PM gegastaldi: On each addon
> 12:02:43 PM lincolnthree1: gegastaldi: maybe
> 12:02:46 PM lincolnthree1: gegastaldi: hopefully{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-980) Failed retrieving forge modules (ClassNotFoundException: org.jboss.forge.maven.plugins.Configuration)
by Lennart Jörelid (JIRA)
[ https://issues.jboss.org/browse/FORGE-980?page=com.atlassian.jira.plugin.... ]
Lennart Jörelid commented on FORGE-980:
---------------------------------------
By "transitive dependencies" I mean Maven compile-scope transitive dependencies, i.e. dependencies declared
in a dependent POM. Normally, in Maven builds, these transitive dependencies are included
automagically by means of the standard Maven dependency resolution mechanism.
In the case of JBoss Forge, however, the transitive dependencies are placed in the location included by the
ClassLoader whose pathFilter is set to "REJECT", as shown in the first screenshot above. This implies that
they are not included in the standard Forge Plugin resolution.
> Failed retrieving forge modules (ClassNotFoundException: org.jboss.forge.maven.plugins.Configuration)
> -----------------------------------------------------------------------------------------------------
>
> Key: FORGE-980
> URL: https://issues.jboss.org/browse/FORGE-980
> Project: Forge
> Issue Type: Bug
> Reporter: Lennart Jörelid
> Assignee: Lennart Jörelid
> Labels: documentation
> Attachments: jbossForgeClassLoadingDebugging_1_incorrectRejectionMaybe.png, jbossForgeClassLoadingDebugging_2_okModuleClassLoader.png, jbossForgePlugin.txt
>
>
> https://community.jboss.org/message/825612
> Following a successful build, including unit tests for the Forge plugin, the installation (forge source-install . ) fails with a ClassNotFoundException: org.jboss.forge.maven.plugins.Configuration within the ~/.forge/runtime.log.
> This class is located in forge-maven-api, which should be available for all plugins being installed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months