July 2013 - forge-issues - Jboss List Archives

[JBoss JIRA] (FORGE-593) Forge swallows first character of user input after restarting (typically from plugin installation)

by Vineet Reynolds (JIRA)

[ https://issues.jboss.org/browse/FORGE-593?page=com.atlassian.jira.plugin.... ] Vineet Reynolds commented on FORGE-593: --------------------------------------- Just adding a comment about how this was fixed, so we're not confused by the earlier comment about an older proposed fix: The blocking queue in ConsoleInputSession is converted to a static shared queue to ensure that characters input by a user that are captured by an eventually terminating reader thread will not be lost (by pushing them in a per-thread queue). Instead, the characters are now pushed into a shared queue where they may be read without any loss. This is a hack to ensure that characters are not lost. Ideally, in a multiple reader thread situation, this should have been done by ensuring that the reader thread obtained just the right number of characters from System.in and eventually terminated gracefully. But, reads on System.in are blocking by nature, and Windows does not provide information on the number of characters to be read via InputStream.available(). Hence the hack. > Forge swallows first character of user input after restarting (typically from plugin installation) > -------------------------------------------------------------------------------------------------- > > Key: FORGE-593 > URL: https://issues.jboss.org/browse/FORGE-593 > Project: Forge > Issue Type: Bug > Components: UI - Shell > Affects Versions: 1.0.5.Final > Reporter: Lincoln Baxter III > Assignee: Vineet Reynolds > Labels: annoying > Fix For: 1.3.3.Final > > Attachments: threaddump-1373073105033.tdump > > > 'forge install-plugin openshift' > Then type something. The first character you type will not be displayed or read. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

[JBoss JIRA] (FORGE-593) Forge swallows first character of user input after restarting (typically from plugin installation)

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-593?page=com.atlassian.jira.plugin.... ] George Gastaldi updated FORGE-593: ---------------------------------- Status: Closed (was: Pull Request Sent) Fix Version/s: 1.3.3.Final (was: 1.x Future) Resolution: Done Good job [~vineet.reynolds] > Forge swallows first character of user input after restarting (typically from plugin installation) > -------------------------------------------------------------------------------------------------- > > Key: FORGE-593 > URL: https://issues.jboss.org/browse/FORGE-593 > Project: Forge > Issue Type: Bug > Components: UI - Shell > Affects Versions: 1.0.5.Final > Reporter: Lincoln Baxter III > Assignee: Vineet Reynolds > Labels: annoying > Fix For: 1.3.3.Final > > Attachments: threaddump-1373073105033.tdump > > > 'forge install-plugin openshift' > Then type something. The first character you type will not be displayed or read. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

[JBoss JIRA] (FORGE-974) Faces scaffolding does not correctly update collection members involved in bi-directional relationships when saving an edited entity

by RH Bugzilla Integration (JIRA)

[ https://issues.jboss.org/browse/FORGE-974?page=com.atlassian.jira.plugin.... ] RH Bugzilla Integration commented on FORGE-974: ----------------------------------------------- Sneha <snagarwa(a)redhat.com> made a comment on [bug 978076|https://bugzilla.redhat.com/show_bug.cgi?id=978076] Updated doc text. > Faces scaffolding does not correctly update collection members involved in bi-directional relationships when saving an edited entity > ------------------------------------------------------------------------------------------------------------------------------------ > > Key: FORGE-974 > URL: https://issues.jboss.org/browse/FORGE-974 > Project: Forge > Issue Type: Bug > Components: Scaffold > Affects Versions: 1.3.1.Final > Reporter: Vineet Reynolds > Assignee: Vineet Reynolds > > The generated scaffold does not contain any logic to update collection properties of a JPA entity. This results in incorrect behavior when the collection is part of a bi-directional relationship in JPA. > This is because no logic exists to remove both sides of the relationship when an entity instance is removed from the collection. The result of this absence in logic is that removal of entities from collection properties do not succeed. Upon save, the collection returns to it's previous state. > Addition of members to the collection property are however performed correctly. Since the Faces scaffold does not allow updates to properties of the the individual members in the collection, no other issue is observed, except for the inability to update the collection state correctly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

[JBoss JIRA] (FORGE-914) Rework the handling of 1:M relationships by the Faces/RichFaces scaffold

by RH Bugzilla Integration (JIRA)

[ https://issues.jboss.org/browse/FORGE-914?page=com.atlassian.jira.plugin.... ] RH Bugzilla Integration commented on FORGE-914: ----------------------------------------------- Vineet Reynolds <vpereira(a)redhat.com> made a comment on [bug 977956|https://bugzilla.redhat.com/show_bug.cgi?id=977956] @Sneha, confirmed as correct. > Rework the handling of 1:M relationships by the Faces/RichFaces scaffold > ------------------------------------------------------------------------ > > Key: FORGE-914 > URL: https://issues.jboss.org/browse/FORGE-914 > Project: Forge > Issue Type: Bug > Components: Scaffold > Affects Versions: 1.0.5.Final, 1.3.0.Final > Reporter: Vineet Reynolds > Assignee: Vineet Reynolds > Fix For: 1.x Future > > > The generated Faces scaffold for 1:M relationships does not handle certain usability aspects. > For example, a new row is automatically added by default when displaying a 1:M relationship upon create. However, unless the add button is clicked, the contents of the row are not added to the underlying managed bean. If the add button is not clicked, the contents of the row are not treated as a new item to be added. This is very confusing. > Also, if bean validation is performed on the entities (in the rows of the 1:M relationship), and if it fails, then the contents need to be corrected, even though they may not be persisted in the database. Again, this is confusing behavior. > Additionally, deletion of entities from the collection (1-side of the association) seems to be broken (FORGE-974). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

[JBoss JIRA] (FORGE-914) Rework the handling of 1:M relationships by the Faces/RichFaces scaffold

by RH Bugzilla Integration (JIRA)

[ https://issues.jboss.org/browse/FORGE-914?page=com.atlassian.jira.plugin.... ] RH Bugzilla Integration commented on FORGE-914: ----------------------------------------------- Sneha <snagarwa(a)redhat.com> made a comment on [bug 977956|https://bugzilla.redhat.com/show_bug.cgi?id=977956] Updated doc text. Vineet please confirm. > Rework the handling of 1:M relationships by the Faces/RichFaces scaffold > ------------------------------------------------------------------------ > > Key: FORGE-914 > URL: https://issues.jboss.org/browse/FORGE-914 > Project: Forge > Issue Type: Bug > Components: Scaffold > Affects Versions: 1.0.5.Final, 1.3.0.Final > Reporter: Vineet Reynolds > Assignee: Vineet Reynolds > Fix For: 1.x Future > > > The generated Faces scaffold for 1:M relationships does not handle certain usability aspects. > For example, a new row is automatically added by default when displaying a 1:M relationship upon create. However, unless the add button is clicked, the contents of the row are not added to the underlying managed bean. If the add button is not clicked, the contents of the row are not treated as a new item to be added. This is very confusing. > Also, if bean validation is performed on the entities (in the rows of the 1:M relationship), and if it fails, then the contents need to be corrected, even though they may not be persisted in the database. Again, this is confusing behavior. > Additionally, deletion of entities from the collection (1-side of the association) seems to be broken (FORGE-974). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1002) Faces scaffold should treat properties lacking suitable converters differently

by Vineet Reynolds (JIRA)

Vineet Reynolds created FORGE-1002: -------------------------------------- Summary: Faces scaffold should treat properties lacking suitable converters differently Key: FORGE-1002 URL: https://issues.jboss.org/browse/FORGE-1002 Project: Forge Issue Type: Feature Request Components: Scaffold Affects Versions: 1.3.2.Final Reporter: Vineet Reynolds This is from the [Sakila-H2 model|https://github.com/maxandersen/sakila-h2]. The {{Staff}} JPA entity generated using the Forge Hibernate Tools plugin, contains a {{byte[]}} property in the form of a {{picture}}. The property is rendered as a {{h:inputText}} widget in the create/edit screens and as a {{h:outputText}} widget in the view screen. This results in errors like the following being reported during operations in such screens: {{Conversion Error setting value '' for 'null Converter'.}} Since a default converter cannot be applied, mostly due to the possibility of changing semantics of such properties across applications, it would be better to * either omit such properties for functional scaffolds, * or generate converters for every such type. Also see the TicketMonster model, where a {{long[][]}} property is present in the {{SectionAllocation}} entity. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1001) Duplicate local variables are created in the View beans of the generated Faces scaffold

by Vineet Reynolds (JIRA)

Vineet Reynolds created FORGE-1001: -------------------------------------- Summary: Duplicate local variables are created in the View beans of the generated Faces scaffold Key: FORGE-1001 URL: https://issues.jboss.org/browse/FORGE-1001 Project: Forge Issue Type: Bug Components: Scaffold Affects Versions: 1.3.2.Final Reporter: Vineet Reynolds Local variables generated in the {{delete()}} method containing the deletion logic are named after the types of the properties. Multiple properties of the same type or parameterized type can exist in the JPA entity. This was noticed in the JPA entities generated from the [Sakila-H2 model|https://github.com/maxandersen/sakila-h2]. A better naming convention needs to be used to prevent naming conflicts and eventually syntax errors in the generated scaffold. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1000) Forge scaffold should allow newly created un-persisted instances to be associated with each other in the views

by Vineet Reynolds (JIRA)

Vineet Reynolds created FORGE-1000: -------------------------------------- Summary: Forge scaffold should allow newly created un-persisted instances to be associated with each other in the views Key: FORGE-1000 URL: https://issues.jboss.org/browse/FORGE-1000 Project: Forge Issue Type: Feature Request Components: Scaffold Affects Versions: 1.3.2.Final Reporter: Vineet Reynolds This is from the [Sakila-H2 model|https://github.com/maxandersen/sakila-h2]. In the create stores screen, we have new Staff that can be added to a store, as well as a manager (another Staff) that can be assigned to a store. The manager to be assigned to the store is not nullable (and is required to be provided when creating/editing a store; see FORGE-999). When no Staff has been created yet, the list of staff that can be assigned as a manager is empty, thus making it impossible to create a new Store without modifying the scaffold. This could be improved by allowing new Staff to be created in the Create Stores screen, and allowing the newly created but un-persisted Staff to be assigned as Managers to the Store. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

[JBoss JIRA] (FORGE-999) Forge scaffold should render not-nullable database columns as required columns

by Vineet Reynolds (JIRA)

[ https://issues.jboss.org/browse/FORGE-999?page=com.atlassian.jira.plugin.... ] Vineet Reynolds updated FORGE-999: ---------------------------------- Summary: Forge scaffold should render not-nullable database columns as required columns (was: Forge scaffold should render not-nullable columns as required columns) > Forge scaffold should render not-nullable database columns as required columns > ------------------------------------------------------------------------------ > > Key: FORGE-999 > URL: https://issues.jboss.org/browse/FORGE-999 > Project: Forge > Issue Type: Feature Request > Components: Scaffold > Affects Versions: 1.3.2.Final > Reporter: Vineet Reynolds > > This is from the [Sakila-H2 model|https://github.com/maxandersen/sakila-h2]. > JPA entities generated from the Sakila model through the Hibernate tools Forge plugin, contain several instances of {{@JoinColumn(name="foo", nullable=false)}}. No JSR-303 {{@NotNull}} constraints were declared. Such properties should be rendered as required properties in the generated scaffold. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

[JBoss JIRA] (FORGE-999) Forge scaffold should render not-nullable columns as required columns

by Vineet Reynolds (JIRA)

Vineet Reynolds created FORGE-999: ------------------------------------- Summary: Forge scaffold should render not-nullable columns as required columns Key: FORGE-999 URL: https://issues.jboss.org/browse/FORGE-999 Project: Forge Issue Type: Feature Request Components: Scaffold Affects Versions: 1.3.2.Final Reporter: Vineet Reynolds This is from the [Sakila-H2 model|https://github.com/maxandersen/sakila-h2]. JPA entities generated from the Sakila model through the Hibernate tools Forge plugin, contain several instances of {{@JoinColumn(name="foo", nullable=false)}}. No JSR-303 {{@NotNull}} constraints were declared. Such properties should be rendered as required properties in the generated scaffold. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 9 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

forge-issues July 2013