[JBoss JIRA] (FORGE-2057) Attributes of Mapped Superclass should be protected and not private
by Antonio Goncalves (JIRA)
Antonio Goncalves created FORGE-2057:
----------------------------------------
Summary: Attributes of Mapped Superclass should be protected and not private
Key: FORGE-2057
URL: https://issues.jboss.org/browse/FORGE-2057
Project: Forge
Issue Type: Feature Request
Components: Java EE
Affects Versions: 2.12.0.Final
Reporter: Antonio Goncalves
When creating a new Mapped Superclass, attributes are private. So the following command :
{code}
jpa-new-mapped-superclass --named Person ;
jpa-new-field --named firstName --length 50 --columnName first_name ;
{code}
Will generate :
{code}
@MappedSuperclass
public class Person {
@Column(length = 50, name = "first_name")
private String firstName;
...
}
{code}
Because mapped superclass are to be inherited, it would be better to have protected attributes so subclasses could use the attributes
{code}
@MappedSuperclass
public class Person {
@Column(length = 50, name = "first_name")
protected String firstName;
...
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (FORGE-2057) Attributes of Mapped Superclass should be protected and not private
by Antonio Goncalves (JIRA)
[ https://issues.jboss.org/browse/FORGE-2057?page=com.atlassian.jira.plugin... ]
Antonio Goncalves updated FORGE-2057:
-------------------------------------
Fix Version/s: 2.x Future
> Attributes of Mapped Superclass should be protected and not private
> -------------------------------------------------------------------
>
> Key: FORGE-2057
> URL: https://issues.jboss.org/browse/FORGE-2057
> Project: Forge
> Issue Type: Feature Request
> Components: Java EE
> Affects Versions: 2.12.0.Final
> Reporter: Antonio Goncalves
> Fix For: 2.x Future
>
>
> When creating a new Mapped Superclass, attributes are private. So the following command :
> {code}
> jpa-new-mapped-superclass --named Person ;
> jpa-new-field --named firstName --length 50 --columnName first_name ;
> {code}
> Will generate :
> {code}
> @MappedSuperclass
> public class Person {
> @Column(length = 50, name = "first_name")
> private String firstName;
> ...
> }
> {code}
> Because mapped superclass are to be inherited, it would be better to have protected attributes so subclasses could use the attributes
> {code}
> @MappedSuperclass
> public class Person {
> @Column(length = 50, name = "first_name")
> protected String firstName;
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (FORGE-2019) Compilation errors in JDK 1.8.0_20
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2019?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-2019:
----------------------------------------
I am not sure this is a good idea as it defeats the purpose of modularity and container isolation on each addon (Eg: addons using cdi container should not care about other containers).
> Compilation errors in JDK 1.8.0_20
> ----------------------------------
>
> Key: FORGE-2019
> URL: https://issues.jboss.org/browse/FORGE-2019
> Project: Forge
> Issue Type: Bug
> Components: Forge Build
> Affects Versions: 2.10.1.Final
> Environment: Fedora 20
> java version "1.8.0_20"
> Java(TM) SE Runtime Environment (build 1.8.0_20-b26)
> Java HotSpot(TM) 64-Bit Server VM (build 25.20-b23, mixed mode)
> Reporter: George Gastaldi
> Priority: Blocker
> Fix For: 2.x Future
>
>
> {code}
> [ERROR] /usr/local/workspace/forge-core-2.0/shell/impl/src/main/java/org/jboss/forge/addon/shell/command/CatCommand.java:[89,27] cannot access org.jboss.forge.furnace.container.simple.Service
> class file for org.jboss.forge.furnace.container.simple.Service not found
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project javaee-impl: Compilation failure
> [ERROR] /usr/local/workspace/forge-core-2.0/javaee/impl/src/main/java/org/jboss/forge/addon/javaee/rest/generator/ResourceGeneratorUtil.java:[42,65] cannot access org.jboss.forge.furnace.container.simple.Service
> [ERROR] class file for org.jboss.forge.furnace.container.simple.Service not found
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (FORGE-2019) Compilation errors in JDK 1.8.0_20
by Adam Siemion (JIRA)
[ https://issues.jboss.org/browse/FORGE-2019?page=com.atlassian.jira.plugin... ]
Adam Siemion commented on FORGE-2019:
-------------------------------------
I have also encountered this issue. How about just adding the org.jboss.forge.furnace.container:simple-api maven dependency with the provided scope, this fixes the issue:
{code}
diff --git a/javaee/impl/pom.xml b/javaee/impl/pom.xml
index 231bc20..6e4747f 100644
--- a/javaee/impl/pom.xml
+++ b/javaee/impl/pom.xml
@@ -11,6 +11,12 @@
<dependencies>
<dependency>
<groupId>org.jboss.forge.furnace.container</groupId>
+ <artifactId>simple-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.jboss.forge.furnace.container</groupId>
<artifactId>cdi-api</artifactId>
<scope>provided</scope>
</dependency>
diff --git a/shell/impl/pom.xml b/shell/impl/pom.xml
index 26a5b4d..8fbbd28 100644
--- a/shell/impl/pom.xml
+++ b/shell/impl/pom.xml
@@ -12,6 +12,11 @@
<dependencies>
<dependency>
+ <groupId>org.jboss.forge.furnace.container</groupId>
+ <artifactId>simple-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
<groupId>org.jboss.forge.addon</groupId>
<artifactId>shell-api</artifactId>
<scope>provided</scope>
{code}
> Compilation errors in JDK 1.8.0_20
> ----------------------------------
>
> Key: FORGE-2019
> URL: https://issues.jboss.org/browse/FORGE-2019
> Project: Forge
> Issue Type: Bug
> Components: Forge Build
> Affects Versions: 2.10.1.Final
> Environment: Fedora 20
> java version "1.8.0_20"
> Java(TM) SE Runtime Environment (build 1.8.0_20-b26)
> Java HotSpot(TM) 64-Bit Server VM (build 25.20-b23, mixed mode)
> Reporter: George Gastaldi
> Priority: Blocker
> Fix For: 2.x Future
>
>
> {code}
> [ERROR] /usr/local/workspace/forge-core-2.0/shell/impl/src/main/java/org/jboss/forge/addon/shell/command/CatCommand.java:[89,27] cannot access org.jboss.forge.furnace.container.simple.Service
> class file for org.jboss.forge.furnace.container.simple.Service not found
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project javaee-impl: Compilation failure
> [ERROR] /usr/local/workspace/forge-core-2.0/javaee/impl/src/main/java/org/jboss/forge/addon/javaee/rest/generator/ResourceGeneratorUtil.java:[42,65] cannot access org.jboss.forge.furnace.container.simple.Service
> [ERROR] class file for org.jboss.forge.furnace.container.simple.Service not found
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (FORGE-2055) Introduce caching in CommandFactory to improve performance
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2055?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-2055.
----------------------------------
Fix Version/s: 2.11.1.Final
Resolution: Done
> Introduce caching in CommandFactory to improve performance
> ----------------------------------------------------------
>
> Key: FORGE-2055
> URL: https://issues.jboss.org/browse/FORGE-2055
> Project: Forge
> Issue Type: Feature Request
> Components: UI - API
> Affects Versions: 2.11.0.Final
> Reporter: Vineet Reynolds
> Assignee: Vineet Reynolds
> Fix For: 2.11.1.Final
>
>
> Currently {{UICommands}} are not cached, especially in scenarios where commands need to be looked up for metadata. For instance, in the Eclipse Quick Action menu, every launch of the menu, creates new {{UICommand}} instances and invokes the {{isEnabled}} method on them. We should minimize the number of times this occurs, since it is wasteful and results in slower launch times.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (FORGE-2055) Introduce caching in CommandFactory to improve performance
by Vineet Reynolds (JIRA)
Vineet Reynolds created FORGE-2055:
--------------------------------------
Summary: Introduce caching in CommandFactory to improve performance
Key: FORGE-2055
URL: https://issues.jboss.org/browse/FORGE-2055
Project: Forge
Issue Type: Feature Request
Components: UI - API
Affects Versions: 2.11.0.Final
Reporter: Vineet Reynolds
Assignee: Vineet Reynolds
Currently {{UICommands}} are not cached, especially in scenarios where commands need to be looked up for metadata. For instance, in the Eclipse Quick Action menu, every launch of the menu, creates new {{UICommand}} instances and invokes the {{isEnabled}} method on them. We should minimize the number of times this occurs, since it is wasteful and results in slower launch times.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months