[JBoss JIRA] (FORGE-2109) Refactoring the UICommands
by Antonio Goncalves (JIRA)
[ https://issues.jboss.org/browse/FORGE-2109?page=com.atlassian.jira.plugin... ]
Antonio Goncalves commented on FORGE-2109:
------------------------------------------
I'm not suggesting to remove the interfaces, I just wonder why some commands have interfaces and others don't. I would like to find a "pattern" on writing commands and apply it all over the place. If you say that interfaces are useful for addons, let's add interfaces.
> Refactoring the UICommands
> --------------------------
>
> Key: FORGE-2109
> URL: https://issues.jboss.org/browse/FORGE-2109
> Project: Forge
> Issue Type: Enhancement
> Components: UI - API
> Affects Versions: 2.12.1.Final
> Reporter: Antonio Goncalves
> Attachments: UIForgeNow.png, UIForgeRefactor.png, UIForgeStructure.png
>
>
> _From the Mailing List [https://developer.jboss.org/thread/249733]_
> I'm trying to add more commands in Forge... but I have to say, I'm a bit lost. So, I've made a quick UML class diagram.
> As you can see in the attached diagram (UIForgeNow.png), most of the Java EE commands extend {{AbstractJavaEECommand}}, which makes sense. But not all of them ({{NewBeanCommand}} (CDI), {{ValidationNewAnnotationCommandImpl}}, {{NewQualifierCommand}}....). And some times you have an extra level of abstraction ({{AbstractFacesCommand}}). Same for the Java commands. {{JavaClassCommandImpl}} extend {{AbstractJavaSourceCommand}} but {{JavaAddAnnotationCommand}} and {{JavaFieldCommand}} inherit from {{AbstractProjectCommand}}. Some other commands, just use the {{@Command}} annotation.
> Then, when you dive into a command (UIForgeStructure.png), some commands use interface and implementation (see in the second diagram {{JavaAddAnnotationCommandImpl}} implementing {{JavaAddAnnotationCommand}}), some don't (e.g. {{NewQualifierCommand}}).
> Correct me if I'm wrong, but the way I see it would be (UIForgeRefactor.png) : under {{AbstractJavaEECommand}} you have a set of {{AbstractValidationCommand}}, {{AbstractCDICommand}}, {{AbstractJPACommand}}.... each implementing {{PrerequisiteCommandsProvider}} (this way, each command sets up its own pre-requisite). And then, under {{AbstractCDICommand}} you have all the {{NewQualifierCommand}}, {{NewBeanCommand}}....
> *The idea of this JIRA is to brainstorm about refactoring the commands, and see if we do it and how*
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 6 months
[JBoss JIRA] (FORGE-2103) Quickstart the Asciidoc structure of the HOL support
by Ivan St. Ivanov (JIRA)
[ https://issues.jboss.org/browse/FORGE-2103?page=com.atlassian.jira.plugin... ]
Ivan St. Ivanov updated FORGE-2103:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Quickstart the Asciidoc structure of the HOL support
> ----------------------------------------------------
>
> Key: FORGE-2103
> URL: https://issues.jboss.org/browse/FORGE-2103
> Project: Forge
> Issue Type: Sub-task
> Components: Documentation
> Reporter: Antonio Goncalves
> Assignee: Ivan St. Ivanov
>
> In [https://github.com/forge/docs] we should create a {{hols}} directory to create our Hands on Lab material. Under this directory, we will have one (several ?) Asciidoc document with the following (draft) structure :
> * First page title : JBoss Forge Hands on Lab
> * Table of Content
> * Introduction
> ** JBoss Forge
> ** What's this HoL is about?
> ** How it works?
> ** What do you have to do?
> ** Software requirement
> * Using Forge
> ** Installing JBoss Forge
> ** Creating a new project
> ** Scaffolding JSF
> ** Deploying on JBoss
> ** Creating Arquillian Tests
> ** Scaffolding AngularJS
> * Developing with Forge
> ** Developing a Web Application in Few Seconds
> ** Developing an Hibernate Envers addon
> ** Developing a Logger Addon
> * Appendix
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 6 months
[JBoss JIRA] (FORGE-2109) Refactoring the UICommands
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-2109?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III commented on FORGE-2109:
-------------------------------------------
You suggested removing the Interfaces and moving the commands to the API. Unless I misunderstood, it may actually be difficult to move commands that use addon*-impl specific functionality from within the addon itself. That is an additional motivation for using an interface.
> Refactoring the UICommands
> --------------------------
>
> Key: FORGE-2109
> URL: https://issues.jboss.org/browse/FORGE-2109
> Project: Forge
> Issue Type: Enhancement
> Components: UI - API
> Affects Versions: 2.12.1.Final
> Reporter: Antonio Goncalves
> Attachments: UIForgeNow.png, UIForgeRefactor.png, UIForgeStructure.png
>
>
> _From the Mailing List [https://developer.jboss.org/thread/249733]_
> I'm trying to add more commands in Forge... but I have to say, I'm a bit lost. So, I've made a quick UML class diagram.
> As you can see in the attached diagram (UIForgeNow.png), most of the Java EE commands extend {{AbstractJavaEECommand}}, which makes sense. But not all of them ({{NewBeanCommand}} (CDI), {{ValidationNewAnnotationCommandImpl}}, {{NewQualifierCommand}}....). And some times you have an extra level of abstraction ({{AbstractFacesCommand}}). Same for the Java commands. {{JavaClassCommandImpl}} extend {{AbstractJavaSourceCommand}} but {{JavaAddAnnotationCommand}} and {{JavaFieldCommand}} inherit from {{AbstractProjectCommand}}. Some other commands, just use the {{@Command}} annotation.
> Then, when you dive into a command (UIForgeStructure.png), some commands use interface and implementation (see in the second diagram {{JavaAddAnnotationCommandImpl}} implementing {{JavaAddAnnotationCommand}}), some don't (e.g. {{NewQualifierCommand}}).
> Correct me if I'm wrong, but the way I see it would be (UIForgeRefactor.png) : under {{AbstractJavaEECommand}} you have a set of {{AbstractValidationCommand}}, {{AbstractCDICommand}}, {{AbstractJPACommand}}.... each implementing {{PrerequisiteCommandsProvider}} (this way, each command sets up its own pre-requisite). And then, under {{AbstractCDICommand}} you have all the {{NewQualifierCommand}}, {{NewBeanCommand}}....
> *The idea of this JIRA is to brainstorm about refactoring the commands, and see if we do it and how*
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 6 months
[JBoss JIRA] (FORGE-2110) Website should display/tweet most recent/top contributors automatically
by Lincoln Baxter III (JIRA)
Lincoln Baxter III created FORGE-2110:
-----------------------------------------
Summary: Website should display/tweet most recent/top contributors automatically
Key: FORGE-2110
URL: https://issues.jboss.org/browse/FORGE-2110
Project: Forge
Issue Type: Task
Components: Website
Reporter: Lincoln Baxter III
We should put a git hook in that tweets community contribution. Maybe some process monthly to also capture top participation and shares it too. That way as the community builds, they feel like their contribution is appreciated and provides them some recognition.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 6 months
[JBoss JIRA] (FORGE-2109) Refactoring the UICommands
by Antonio Goncalves (JIRA)
[ https://issues.jboss.org/browse/FORGE-2109?page=com.atlassian.jira.plugin... ]
Antonio Goncalves updated FORGE-2109:
-------------------------------------
Attachment: UIForgeStructure.png
UIForgeRefactor.png
> Refactoring the UICommands
> --------------------------
>
> Key: FORGE-2109
> URL: https://issues.jboss.org/browse/FORGE-2109
> Project: Forge
> Issue Type: Enhancement
> Components: UI - API
> Affects Versions: 2.12.1.Final
> Reporter: Antonio Goncalves
> Attachments: UIForgeNow.png, UIForgeRefactor.png, UIForgeStructure.png
>
>
> _From the Mailing List [https://developer.jboss.org/thread/249733]_
> I'm trying to add more commands in Forge... but I have to say, I'm a bit lost. So, I've made a quick UML class diagram.
> As you can see in the attached diagram (UIForgeNow.png), most of the Java EE commands extend {{AbstractJavaEECommand}}, which makes sense. But not all of them ({{NewBeanCommand}} (CDI), {{ValidationNewAnnotationCommandImpl}}, {{NewQualifierCommand}}....). And some times you have an extra level of abstraction ({{AbstractFacesCommand}}). Same for the Java commands. {{JavaClassCommandImpl}} extend {{AbstractJavaSourceCommand}} but {{JavaAddAnnotationCommand}} and {{JavaFieldCommand}} inherit from {{AbstractProjectCommand}}. Some other commands, just use the {{@Command}} annotation.
> Then, when you dive into a command (UIForgeStructure.png), some commands use interface and implementation (see in the second diagram {{JavaAddAnnotationCommandImpl}} implementing {{JavaAddAnnotationCommand}}), some don't (e.g. {{NewQualifierCommand}}).
> Correct me if I'm wrong, but the way I see it would be (UIForgeRefactor.png) : under {{AbstractJavaEECommand}} you have a set of {{AbstractValidationCommand}}, {{AbstractCDICommand}}, {{AbstractJPACommand}}.... each implementing {{PrerequisiteCommandsProvider}} (this way, each command sets up its own pre-requisite). And then, under {{AbstractCDICommand}} you have all the {{NewQualifierCommand}}, {{NewBeanCommand}}....
> *The idea of this JIRA is to brainstorm about refactoring the commands, and see if we do it and how*
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 6 months
[JBoss JIRA] (FORGE-2109) Refactoring the UICommands
by Antonio Goncalves (JIRA)
[ https://issues.jboss.org/browse/FORGE-2109?page=com.atlassian.jira.plugin... ]
Antonio Goncalves updated FORGE-2109:
-------------------------------------
Attachment: UIForgeNow.png
> Refactoring the UICommands
> --------------------------
>
> Key: FORGE-2109
> URL: https://issues.jboss.org/browse/FORGE-2109
> Project: Forge
> Issue Type: Enhancement
> Components: UI - API
> Affects Versions: 2.12.1.Final
> Reporter: Antonio Goncalves
> Attachments: UIForgeNow.png, UIForgeRefactor.png, UIForgeStructure.png
>
>
> _From the Mailing List [https://developer.jboss.org/thread/249733]_
> I'm trying to add more commands in Forge... but I have to say, I'm a bit lost. So, I've made a quick UML class diagram.
> As you can see in the attached diagram (UIForgeNow.png), most of the Java EE commands extend {{AbstractJavaEECommand}}, which makes sense. But not all of them ({{NewBeanCommand}} (CDI), {{ValidationNewAnnotationCommandImpl}}, {{NewQualifierCommand}}....). And some times you have an extra level of abstraction ({{AbstractFacesCommand}}). Same for the Java commands. {{JavaClassCommandImpl}} extend {{AbstractJavaSourceCommand}} but {{JavaAddAnnotationCommand}} and {{JavaFieldCommand}} inherit from {{AbstractProjectCommand}}. Some other commands, just use the {{@Command}} annotation.
> Then, when you dive into a command (UIForgeStructure.png), some commands use interface and implementation (see in the second diagram {{JavaAddAnnotationCommandImpl}} implementing {{JavaAddAnnotationCommand}}), some don't (e.g. {{NewQualifierCommand}}).
> Correct me if I'm wrong, but the way I see it would be (UIForgeRefactor.png) : under {{AbstractJavaEECommand}} you have a set of {{AbstractValidationCommand}}, {{AbstractCDICommand}}, {{AbstractJPACommand}}.... each implementing {{PrerequisiteCommandsProvider}} (this way, each command sets up its own pre-requisite). And then, under {{AbstractCDICommand}} you have all the {{NewQualifierCommand}}, {{NewBeanCommand}}....
> *The idea of this JIRA is to brainstorm about refactoring the commands, and see if we do it and how*
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 6 months